https://gitlab.synchro.net/main/sbbs/-/merge_requests/68#note_1285
I'm on "vacation" right now, so I have very little time to review anything until next week.
Please avoid bundling whitespace changes in with unrelated requests. I can't tell at a glance if there are any functional changes to home.xjs or games.xjs.
Is checkbox.css and all of the related "checkbox" stuff just there to facilitate an "enable dark mode" checkbox? (Just curious.)
An option should be added to modopts.ini->[web] so that the sysop can decide whether they want to offer dark mode. This option should control whether the checkbox is shown and whether checkbox.css (or any other unnecessary-if-disabled) stuff is sent. (If you did this, great - I may have missed it.)
I see some inline styling added to index.xjs:
`.hidden { display:none; }`
I'd rather this kind of thing be in style.css unless it really needs to be inline (eg. to override something). Just an organizational consideration.
I have no problem with their being a default "dark mode"; the sysop can make the light and dark modes look however they want via custom.css. (We don't need to offer "hot pink mode" or anything else; that's up to the sysop to define - but light/dark makes sense.)
I'd like to make some changes eventually to how the user's preference is retained, possibly including time-of-day options, but leave that to me for later on as this ties into some other work.
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net