1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/syncterm/ripper.c

    From Deuce@VERT to Git commit to sbbs/master on Friday, September 04, 2020 13:10:24
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/510c424ae04cffe8bff9582d
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    stat.st_atim.tv_sec -> stat.st_atime

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Stephen Hurd@VERT to Git commit to sbbs/master on Tuesday, November 10, 2020 12:55:53
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/feda0dba2b685f33191472d5
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Use sockwrap.h for arpa/inet.h and strwrap.h for stdndup()

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Stephen Hurd@VERT to Git commit to sbbs/master on Saturday, November 14, 2020 00:48:57
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/ee0df4bd61c6188df34cdc92
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Stop using ASCII caret for power of two.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Stephen Hurd@VERT to Git commit to sbbs/master on Sunday, November 15, 2020 23:47:05
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/480206149919a240a539cf40
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix most of the RIP issues found by coverity.

    Most are simple memory leaks, but some would cause crashes, and
    others would cause unexpected behaviour.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Stephen Hurd@VERT to Git commit to sbbs/master on Tuesday, November 17, 2020 00:02:01
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/0f4eab23df7aab55c31b473b
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Remove duplicate fclose()

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, March 13, 2021 22:44:47
    https://gitlab.synchro.net/main/sbbs/-/commit/61022e183d56d3e58411a441
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Don't make parse_rip() do anything when RIP is disabled.

    Should fix file transfer issues.
    (SF bug #38)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Sunday, March 14, 2021 22:57:48
    https://gitlab.synchro.net/main/sbbs/-/commit/21763a1df8ad975a60fe1147
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Add comments for all the things.

    Just copied out of the documentation.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, April 30, 2021 12:01:41
    https://gitlab.synchro.net/main/sbbs/-/commit/730c324235093b61f658e947
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Start of minimal RIPv2 support.

    Just the easy stuff (scaling, extended colours, border toggle, filled rectangle)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, April 30, 2021 12:57:01
    https://gitlab.synchro.net/main/sbbs/-/commit/2c23c1a3218b32b9d05aba9a
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Remove debug, optimize

    Generate conversion tables rather than do float math twice for each
    virtual pixel.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, April 30, 2021 20:15:45
    https://gitlab.synchro.net/main/sbbs/-/commit/b9d43a4c3c635070dba52dc2
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Implement disabled text for RIP.

    We still need to pass ANSI through to the parser though because
    Synchronet goes apeshit if it doesn't get a response to a location
    request... it tries twice and eats any data it receives that isn't
    a valid position report, which obviously breaks menus.

    It's also very weird that on Booch's BBS at least it's sent during
    the main menu display rather than just on answering. Not sure why
    this is, but it means we can't implement the RIP requirement of
    "ignoring all non-RIPscrip bytes" with a zero window without digging
    deep into Synchronet guts.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, May 01, 2021 07:36:50
    https://gitlab.synchro.net/main/sbbs/-/commit/f5a3570f92d9b8844cd56e4b
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix merge issue.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, May 01, 2021 12:31:51
    https://gitlab.synchro.net/main/sbbs/-/commit/1a5fe6e2f0be45c3d8b4f5d2
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Some optimizations and clearing realloc()ed data.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Sunday, May 02, 2021 07:48:56
    https://gitlab.synchro.net/main/sbbs/-/commit/1075cd28c2e431aca992a1f6
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Add save/resotore mouse fields commands.

    Used extensively on Black Flag BBS.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Tuesday, May 04, 2021 18:02:29
    https://gitlab.synchro.net/main/sbbs/-/commit/59053de5e06c260d968f7b5f
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Make some changes

    Mostly tightening things up and fixed some text things.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, May 05, 2021 20:56:53
    https://gitlab.synchro.net/main/sbbs/-/commit/faca73d3d0f6ae524be38e40
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix palette calculations, and add support for RIPv2 'b' command.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Thursday, May 06, 2021 19:06:55
    https://gitlab.synchro.net/main/sbbs/-/commit/19f0c215a6cc9402df40e158
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    More improvements...

    Consistently use map_rip_color()
    Optimize flood fill to not clobber the stack
    Fix small full ellipses to match RIPTerm 1.54

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Monday, May 10, 2021 09:27:58
    https://gitlab.synchro.net/main/sbbs/-/commit/461d36a14af5b78d0632e3e5
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Draw the ellipse pixel when the angle is equal to start/end as well

    Being stritly less/greater causes a one pixel gap at the start/end
    of the ellipse, meaning flood fills can escape.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Monday, May 10, 2021 09:56:33
    https://gitlab.synchro.net/main/sbbs/-/commit/37d8d708cb66298fb6848f6d
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Add extended comment on do_fill() and why it's terrible.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Tuesday, May 11, 2021 09:07:54
    https://gitlab.synchro.net/main/sbbs/-/commit/498187eb3ef005678e9fa92f
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix angle calculations on Win32

    Do multiple before divide, and use an lround() to get the same results
    on Win32 with mingw32 as Clang on FreeBSD.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, May 15, 2021 01:02:25
    https://gitlab.synchro.net/main/sbbs/-/commit/88480afbb740365557ff502a
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Don't guard #pragma

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, May 19, 2021 23:34:16
    https://gitlab.synchro.net/main/sbbs/-/commit/2cc6b5d95b825488dd791c64
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Use fexistcase() for RIP assets

    It seems that at least LORD has upper-case in the ZIPs and lower-case
    in the queries.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Thursday, May 20, 2021 01:33:48
    https://gitlab.synchro.net/main/sbbs/-/commit/ab0256208977d1d2633be7f1
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    ifdef out an unused static function for now.

    It will be used in the future, so the code shouldn't be deleted,
    but not using it causes a warning.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, May 21, 2021 16:23:13
    https://gitlab.synchro.net/main/sbbs/-/commit/040172431ecfac608bf832a7
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix auto-transfers

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, May 21, 2021 16:23:13
    https://gitlab.synchro.net/main/sbbs/-/commit/05b3074f28d0352c216db376
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Send CRLF instead of the specified CR on a file status.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Tuesday, December 20, 2022 21:18:30
    https://gitlab.synchro.net/main/sbbs/-/commit/0898c565823c2ef6dbd59741
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Separate RIP enabled from suspended.

    Previously, a file transfer would unconditionally enable RIP.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, December 24, 2022 11:42:51
    https://gitlab.synchro.net/main/sbbs/-/commit/bc6daf3f47edd4a37873fb7f
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Only check the filename for a dot, not the whole cachepath

    Fixes icon displays in RIPs that don't use the .ICN extension.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, December 24, 2022 13:46:02
    https://gitlab.synchro.net/main/sbbs/-/commit/8fd40b34e995ee25bfe410b9
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Some ellipse improvements to fix Violet's chat bubble when she's busy.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, December 24, 2022 22:10:13
    https://gitlab.synchro.net/main/sbbs/-/commit/c3b827088b502bbeef11fe6c
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix RIP_FILE_QUERY

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wednesday, March 29, 2023 16:29:18
    https://gitlab.synchro.net/main/sbbs/-/commit/41cd8c3af2366120df56154c
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix GCC 12.2 warning

    warning: argument 1 value `18446744073709551608' exceeds maximum
    object size 9223372036854775807 [-Walloc-size-larger-than=]

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, April 26, 2023 12:14:15
    https://gitlab.synchro.net/main/sbbs/-/commit/ac4a967c92244c8c12ac6398
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix Win32 console (and likely curses) crash on connect

    RIP initialization was trying to obtain a lock that only exists when
    using a bitmap console. Don't allow RIP to be enabled, and don't
    perform the operations that require the lock when the CONIO_OPT_SET_PIXEL ciolib option is not set.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, August 02, 2023 22:57:40
    https://gitlab.synchro.net/main/sbbs/-/commit/236064ee462ca2be3b81cd77
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Properly read extended keys in non-graphics builds.

    Fixes SF issue 118

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Thursday, February 15, 2024 15:04:14
    https://gitlab.synchro.net/main/sbbs/-/commit/ec4a8c96c24994cb157ac491
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Move fiddling with rip.x_max and rip.y_max out of the vstat mutex.

    Apparently, fiddling with them in there "strongly implies" to Coverity
    that vstatlock needs to be held to access them, and it's good form
    to have the lock held for the least span possible.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, March 22, 2024 02:16:53
    https://gitlab.synchro.net/main/sbbs/-/commit/4ed27ca97ae7f21f56d038b6
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Use safer string things...

    We really need strlcpy()/strlcat() wrappers in xpdev.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, September 27, 2024 23:15:55
    https://gitlab.synchro.net/main/sbbs/-/commit/75008b3055306224ca0272cc
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix a couple use-after-free bugs in RIP

    This likely is the cause of bug 140.

    The first one, the LCF flag is copied out of the cterm struct
    after cterm_end() is called (which frees the struct). Copy moved
    to before cterm_end().

    The second one is trickier... it's executing the commands in a mouse
    button, and one of the commands is to delete all the mouse button
    commands. This ends up free()ing the string that's currently being
    parsed while it's being parsed. We now use a strdup() of the string
    which we free at the end of the function.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, September 27, 2024 23:40:23
    https://gitlab.synchro.net/main/sbbs/-/commit/9fefe60690d8c378c13ccd96
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix builds that don't support any graphics.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Monday, October 28, 2024 09:47:57
    https://gitlab.synchro.net/main/sbbs/-/commit/1a74630f9654033b92b0fe28
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    When RIP changes the vstat mode, also change the cursor

    When changing between 8 and 16 row fonts in RIP mode, the cursor
    start and end was left for the old font size... 16 -> 8 would leave
    the cursor one line below the current position, and 8 -> 16 would
    leave the cursor in the middle of the cell.

    This hacks the vstat deeper to fix up the cursor as well.

    Reported by skipperdoodle1947.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Tuesday, October 29, 2024 12:11:28
    https://gitlab.synchro.net/main/sbbs/-/commit/0a78d39dd2e3389140dff826
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix handling of broken CRLF pairs in RIP mode

    If telnet binary mode is enabled (the new default), and a CR and LF
    come in on separate recv() calls, the RIP parser would stop at the
    CR, and pass the LF back to the ANSI parser.

    Ah, dura-bbs.net, always pushing the limits.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, October 30, 2024 09:54:01
    https://gitlab.synchro.net/main/sbbs/-/commit/9b3aa58cf998d1c1015560b3
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix up previous commit

    RIPtel reset to the font configured by the user, not the current
    font. Do the same here.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net