exec/load binkp.js NONE 1.1
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv17665/load

Added Files:
binkp.js
Log Message:
Start of BinkP implementation in JavaScript.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

deuce wrote to CVS commit <=-

exec/load binkp.js NONE 1.1
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv17665/load

Added Files:
binkp.js
Log Message:
Start of BinkP implementation in JavaScript.

Interesting.... :)


--

Bill

Telnet: tequilamockingbirdonline.net
Web: bbs.tequilamockingbirdonline.net
FTP: ftp.tequilamockingbirdonline.net:2121
IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
Radio: radio.tequilamockingbirdonline.net:8010/live


... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
--- MultiMail/Win32 v0.50
þ Synchronet þ TequilaMockingbird Online - Toms River, NJ

exec/load binkp.js 1.1 1.2
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv4625/load

Modified Files:
binkp.js
Log Message:
Add CRAM-MD5 support, start working making it so you set up an entire
session, then call the session() method rather than requiring any logic
in the user of the class.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.2 1.3
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv7356/load

Modified Files:
binkp.js
Log Message:
Move some stuff around... this is capable of establishing a password-protected session using MD5 with binkd.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.3 1.4
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv13473/load

Modified Files:
binkp.js
Log Message:
This is now capable of a complete session... only open TODOs are related
to the socket going away, and not having the latest js_socket.c.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.4 1.5
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv16140/load

Modified Files:
binkp.js
Log Message:
Handle socket disconnection correctly.
A file is not successfully sent until we get an M_GOT from the remote.
That takes care of all the TODO items.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.5 1.6
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv26829/load

Modified Files:
binkp.js
Log Message:
Add some documentation.
Add an rx_callback property that is called whenever we successfully receive
a file.
Fix up skipfiles so it doesn't try sending until all the remotes files are skipped.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.6 1.7
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv31841/load

Modified Files:
binkp.js
Log Message:
Move cram calculation into a separate method to prepare for authentication callbacks.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.7 1.8
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv32282/load

Modified Files:
binkp.js
Log Message:
Make stuff from the system object configurable.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.8 1.9
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv32507/load

Modified Files:
binkp.js
Log Message:
Fix M_ADR command.
Fix bugs in previous commit.
Use Date.toString() instead of system.timestr for TIME value.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.9 1.10
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv651/load

Modified Files:
binkp.js
Log Message:
Mention that the auth callback should call addFile()




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.10 1.11
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv1883/load

Modified Files:
binkp.js
Log Message:
Add accept() and connect() methods to indicate the side you're on.

Add name_ver argument to the constructor and corresponding property so that consumers of binkp.js can indicate their program name correctly.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.11 1.12
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv2005/load

Modified Files:
binkp.js
Log Message:
And finally, run 'er through syncjslint and fix problems.
This may now be completely good to go!




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

Hello deuce,

On 13 Jan 16 15:49, deuce wrote to CVS commit:

exec/load binkp.js 1.11 1.12
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv2005/load

Modified Files:
binkp.js
Log Message:
And finally, run 'er through syncjslint and fix problems.
This may now be completely good to go!

Not sure if you did already, but you might want to test it with Irex along with
binkd. I remember a bunch of workarounds that needed to be done in order to play nice with Irex. I just remember Mystic's mailer went through a bunch of issues and workarounds for some of the older mailers that didn't follow the binkp implementations properly.

Offhand, I know Irex reports that it's binkp v1.1, but really isn't. MBSE and Mystic both have some sort of fallback to binkp v1.0 when connecting with Irex mailers. Also, I think it was something like Argus, sent extra characters or spaces at the end of the md5 authentication that needed to be coped with in order to make successful md5 connections with it. There's more, I just don't remember all of them. :/

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20151129
* Origin: thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin) (723:1/701)
þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

exec/load binkp.js 1.12 1.13
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv6165/load

Modified Files:
binkp.js
Log Message:
Remove the skipfiles property in favour of a want_callback callback. Since binkp/1.1 requires rescanning the outbound after every received file after
an M_EOB, and binkd at least will re-offer previously skipped files, we
can't implement this as a simple boolean.

The want_callback will need to track skipped files and whatnot to get this effect.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.13 1.14
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv6472/load

Modified Files:
binkp.js
Log Message:
Fix handling of file.REJECT from want_callback().
Reset senteob when addFile() is called on a 1.1 session.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.14 1.15
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv6647/load

Modified Files:
binkp.js
Log Message:
Fix OPT VER genration.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.15 1.16
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv7114/load

Modified Files:
binkp.js
Log Message:
Add session timeout support.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

Re: Re: exec/load/binkp.js
By: Accession to deuce on Wed Jan 13 2016 07:14 pm

Not sure if you did already, but you might want to test it with Irex along with binkd. I remember a bunch of workarounds that needed to be done in order to play nice with Irex. I just remember Mystic's mailer went through a bunch of issues and workarounds for some of the older mailers that didn't follow the binkp implementations properly.

To be completely honest, if Irex is broken, I'm not going to add work-arounds for it unless my hub starts using it (he's running Radius now).

If people report problems, and are willing to work with me to add work-arounds, I'll get them later if it ever matters. I'm not really interested in breaking my stuff so that other people think their stuff isn't broken.

The perceived need to support old broken software is a big part of what went wrong with FidoNet in the first place.


---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
Mro is an idiot. Please ignore him, we keep hoping he'll go away.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)

exec/load binkp.js 1.16 1.17
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv4256/load

Modified Files:
binkp.js
Log Message:
Make the default handler a bit more magical... REJECT files already received this session, SKIP files that already exist, and ACCEPT all others.

No longer try to append extra data packets to the end of the file to allow files to grow in transit... the protocol is really not well suited to this anyway. Instead, truncate to the advertised length.

If the want_callback changes the file name, still ACK the correct file.

Escape filenames more consistantly.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.17 1.18
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv4345/load

Modified Files:
binkp.js
Log Message:
It's not clear from the binkp/1.1 spec if "A Mailer MAY switch to NR mode at any moment without notice" means that it won't sent an OPT ND. Just in case, handle a -1 offset as though NR mode is enabled when version is 1.1.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.18 1.19
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv4598/load

Modified Files:
binkp.js
Log Message:
Make it syncjslint clean.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.20 1.21
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv8794/load

Modified Files:
binkp.js
Log Message:
Always put the JSBinkP revision in the VER text, if no name/ver is specified
to the constructor, use "UnknownScript/0.0".




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.21 1.22
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv9447/load

Modified Files:
binkp.js
Log Message:
Add an auth_cb to the connect method as well. This is needed so that the caller can addFiles() after the address list is received, hopefully knowing
if it's a secure session or not.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

Hello Deuce,

On 13 Jan 16 18:29, Deuce wrote to Accession:

Not sure if you did already, but you might want to test it with
Irex along with binkd. I remember a bunch of workarounds that
needed to be done in order to play nice with Irex. I just remember
Mystic's mailer went through a bunch of issues and workarounds for
some of the older mailers that didn't follow the binkp
implementations properly.

To be completely honest, if Irex is broken, I'm not going to add work-arounds for it unless my hub starts using it (he's running Radius now).

If people report problems, and are willing to work with me to add work-arounds, I'll get them later if it ever matters. I'm not really interested in breaking my stuff so that other people think their stuff isn't broken.

The perceived need to support old broken software is a big part of
what went wrong with FidoNet in the first place.

I agree completely. I was just giving you a heads up as to things you or others
may run into in the future, is all.

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20151129
* Origin: thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin) (723:1/701)
þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

exec/load binkp.js 1.22 1.23
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv28957/load

Modified Files:
binkp.js
Log Message:
Add a this argument to the end of all callback parameters so the object
will be available regardless of the scope of the callback.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.23 1.24
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv14515/load

Modified Files:
binkp.js
Log Message:
Make tx_queue and pending_ack lists hold objects with the file object and
the send as name property.
Add another "sendas" parameter to the addFile() method.

This allows renaming on the fly (which is required for packets).




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.24 1.25
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv14619/load

Modified Files:
binkp.js
Log Message:
Fix bug in last commit.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.25 1.26
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv16796/load

Modified Files:
binkp.js
Log Message:
We don't need to use file_getname() with the sendas property.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.26 1.27
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv17357/load

Modified Files:
binkp.js
Log Message:
Add a TX callback as well since we are required to delete flow files as soon
as "all the information" is sent... per FTS-5005: "The mailer should not wait for the end of the session when deleting the flow file."



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.27 1.28
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv18453/load

Modified Files:
binkp.js
Log Message:
Add logging when adding files.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.28 1.29
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv19670/load

Modified Files:
binkp.js
Log Message:
Don't call auth_cb() if it's undefined, parse remote addresses in try/catch.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.29 1.30
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv3117/load

Modified Files:
binkp.js
Log Message:
Change the auth_cb for accept() method to pass the passwords and the object.
If the rx_callback function returns false, send an M_SKIP and continue.
Fix the advertised program name in accept() method.
Don't ACK the file until you have the whole thing.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.30 1.31
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv3855/load

Modified Files:
binkp.js
Log Message:
Create the BinkP.cram object during accept() as well as during connect()



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.31 1.32
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv4775/load

Modified Files:
binkp.js
Log Message:
Treat NULLs "as end-of-line" per FTS-1026




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.32 1.33
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv29505/load

Modified Files:
binkp.js
Log Message:
Fix M_GOT response
Don't break out of the session until all ACKs are received.
Better handling of timeouts and poll() errors.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.33 1.34
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv15559/load

Modified Files:
binkp.js
Log Message:
Log when connect() fails.
Make timeouts at different points in the protocol use different log messages. When a frame is sent, use a single send() call to avoid small packets on the wire.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.34 1.35
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv15938/load

Modified Files:
binkp.js
Log Message:
Fix incorrect variable name when skipping a file.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.35 1.36
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv20386/load

Modified Files:
binkp.js
Log Message:
Only clear the senteob flag when we add a new file or when get get an M_EOB command.

Fixes issue with Radius thinking we left because we sent an empty batch.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.36 1.37
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv29556/load

Modified Files:
binkp.js
Log Message:
Add encryption support per binkd.
I epxect to actually require this by default in the near future.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.37 1.38
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv29906/load

Modified Files:
binkp.js
Log Message:
Fix accept() handling of passwords.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.38 1.39
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv30288/load

Modified Files:
binkp.js
Log Message:
Add a require_crypt property (defaults to true).
If this is set, and there is a connection attempt which does not support encryption, an error will be returned.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.39 1.40
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv30390/load

Modified Files:
binkp.js
Log Message:
Document changes to the auth_cb




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.40 1.41
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv3015/load

Modified Files:
binkp.js
Log Message:
And finally, ensure all outbounds are locked before scanning.
This is now being tested live on my system... watch this space for more updates.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.41 1.42
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv5789/load

Modified Files:
binkp.js
Log Message:
Lower header recv timeout log priority from error to warning... this is
how Radius appears to say goodbye.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.42 1.43
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv24439/load

Modified Files:
binkp.js
Log Message:
Fix bug detecting remote disconnection. This resulted in an incorrect
error message being logged.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.43 1.44
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv32587/load

Modified Files:
binkp.js
Log Message:
If there is no password, do not require MD5 and don't encrypt.
This works around an apparent bug in binkp where it doesn't appear to initialize the BinkD compatible crypto correctly when using an empty
password.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.44 1.45
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv326/load

Modified Files:
binkp.js
Log Message:
Apparently, recv() returns null if the socket is disconnected... handle that gracefully.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.45 1.46
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv410/load

Modified Files:
binkp.js
Log Message:
Don't encrypt of we don't send OPT CRYPT.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.46 1.47
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv531/load

Modified Files:
binkp.js
Log Message:
Turn off require_crypt if we turn on wont_crypt.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.47 1.48
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv15897/load

Modified Files:
binkp.js
Log Message:
Support wont_crypt for incoming sessions as well (not likely to be used)



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.48 1.49
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv7432/load

Modified Files:
binkp.js
Log Message:
Add TODO comment regarding disabling encryption when not using a password.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.50 1.51
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv23005/load

Modified Files:
binkp.js
Log Message:
Multiple bug-fixes:
1) Correctly truncate/delete files per the FLO instructions.
2) If we can't add a file to the queue, we still need to track it in the
flo status to know if we can delete the flow file.
3) Don't truncate the first character of a flow line that doesn't have a
know prefix (is supposed to be a send and don't delete)
4) Fix exception when calling an unconfigured node.
5) Fix error when detecting the session is done in BinkP 1.1 mode. If BinkIT
was connecting to itself, and infinite loop would occur with both ends
continuously sending empty batches.
6) When calling the tx_callback, pass the filename, not the pending_ack entry.

Additional features:
Call fullpath() in the outbound directory so that symlinks used to work around sbbsecho's lack of 5D support work correctly.
Fix rx/tx_callback documentation.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.51 1.52
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv28148/load

Modified Files:
binkp.js
Log Message:
Remove debug output in previous commit.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.52 1.53
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv4716/load

Modified Files:
binkp.js
Log Message:
Fix first argument to tx_callback (again).




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.54 1.55
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv5280/load

Modified Files:
binkp.js
Log Message:
Fix variable name. May fix "M_FILE Offset of -1 in reliable mode!" error reported by DeepEND.

Thanks!




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.55 1.56
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv21998/load

Modified Files:
binkp.js
Log Message:
Handle inccorect v1.0 non-reliable mode transfers when we're not in NR mode.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.56 1.57
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv15140/load

Modified Files:
binkp.js
Log Message:
First attempt to fix NR mode.

Reported by Accession of The Pharcyde (running binkd 1.1a-94), with BinkIT running on RetroDigital BBS and Shodan's Core (Both running BinkIT/1.40,JSBinkP/1.56).

When in NR mode, send the M_FILE with an offset of -1 then wait for the
remote to send an M_GET. Please note that NR mode should not really be used when the connection is stable, or is quick. It appears that The Pharcyde is requesting NR mode... so sould keep running it until this fix is confirmed.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

Hello deuce,

On 13 Apr 16 01:14, deuce wrote to CVS commit:

exec/load binkp.js 1.56 1.57
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv15140/load

Modified Files:
binkp.js
Log Message:
First attempt to fix NR mode.

Reported by Accession of The Pharcyde (running binkd 1.1a-94), with
BinkIT running on RetroDigital BBS and Shodan's Core (Both
running BinkIT/1.40,JSBinkP/1.56).

When in NR mode, send the M_FILE with an offset of -1 then wait for
the remote to send an M_GET. Please note that NR mode should not
really be used when the connection is stable, or is quick. It appears that The Pharcyde is requesting NR mode... so sould keep running it
until this fix is confirmed.

I only started using -nr mode for those two nodes within a day or two ago to see if it would fix anything. It didn't. My normal options are -md and -nd and that is all.

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20160322
þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

Hello Deuce,

On 13 Apr 16 15:35, Accession wrote to deuce:

Hello deuce,

On 13 Apr 16 01:14, deuce wrote to CVS commit:

exec/load binkp.js 1.56 1.57
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv15140/load

Modified Files:
binkp.js
Log Message:
First attempt to fix NR mode.

Reported by Accession of The Pharcyde (running binkd 1.1a-94),
with BinkIT running on RetroDigital BBS and Shodan's Core (Both
running BinkIT/1.40,JSBinkP/1.56).

When in NR mode, send the M_FILE with an offset of -1 then wait
for the remote to send an M_GET. Please note that NR mode should
not really be used when the connection is stable, or is quick.
It appears that The Pharcyde is requesting NR mode... so sould
keep running it until this fix is confirmed.

I only started using -nr mode for those two nodes within a day or two
ago to see if it would fix anything. It didn't. My normal options are
-md and -nd and that is all.

*EDIT*, also I notice in my logs when connecting to those systems "Remote is in NR mode" which would suggest they are using that option?

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20160322
þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

Re: Re: exec/load/binkp.js
By: Accession to deuce on Wed Apr 13 2016 03:35 pm

I only started using -nr mode for those two nodes within a day or two ago to see if it would fix anything. It didn't. My normal options are -md and -nd and that is all.

Well, the problem the logs showed was absolutely triggered by your system sending "OPT NR". Maybe it sends it regardless of the -nr option? The binkd documentation suggests that the -nr flag is only used on outbound connections, so perhaps binkd sends OPT NR on all incoming connections?

---
þ Synchronet þ The future of BBSing

Re: Re: exec/load/binkp.js
By: Accession to Deuce on Wed Apr 13 2016 03:37 pm

*EDIT*, also I notice in my logs when connecting to those systems "Remote is in NR mode" which would suggest they are using that option?

The first system send an "NR" option in an OPT string is the one initiating NR mode. I'm pretty sure in the logs, your system sends it first.

---
þ Synchronet þ The future of BBSing

exec/load binkp.js 1.57 1.58
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv9842/load

Modified Files:
binkp.js
Log Message:
Compare the sendas property of sending, not the entire object to the M_GET filename.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.58 1.59
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv10985/load

Modified Files:
binkp.js
Log Message:
Send an M_FILE .. ... 0 after an M_GET after an M_FILE .. ... -1
Should finish fixing the problem reported by Accession and Android 8675.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

Hello Deuce,

On 14 Apr 16 00:32, Deuce wrote to Accession:

I only started using -nr mode for those two nodes within a day or
two ago to see if it would fix anything. It didn't. My normal
options are -md and -nd and that is all.

Well, the problem the logs showed was absolutely triggered by your
system sending "OPT NR". Maybe it sends it regardless of the -nr
option? The binkd documentation suggests that the -nr flag is only
used on outbound connections, so perhaps binkd sends OPT NR on all incoming connections?

I don't see it with any other systems. But I did indeed have -nr set for those two nodes when I gave you the logs. I have since removed that option from their node line in binkd and am still seeing the same results (including "remote is in NR mode" which I assume is telling me THEY are in NR mode), and with connections still failing with both of them.

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20160322
þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

Hello Deuce,

On 14 Apr 16 00:33, Deuce wrote to Accession:

*EDIT*, also I notice in my logs when connecting to those systems
"Remote is in NR mode" which would suggest they are using that
option?

The first system send an "NR" option in an OPT string is the one initiating NR mode. I'm pretty sure in the logs, your system sends it first.

You're correct there. In the logs I sent you, I did have it enabled. Now I don't, I see no OPT NR or anything from my side, yet I still see "remote is in NR mode".

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20160322
þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

Re: Re: exec/load/binkp.js
By: Accession to Deuce on Wed Apr 13 2016 08:06 pm

I don't see it with any other systems. But I did indeed have -nr set for those two nodes when I gave you the logs. I have since removed that option from their node line in binkd and am still seeing the same results (including "remote is in NR mode" which I assume is telling me THEY are in NR mode), and with connections still failing with both of them.

"remote is in NR mode" is printed when you get an M_FILE with the offset set to -1... which indicates the remote is using NR mode for that transfer. The reason BinkIT is sending that is because it got an "OPT NR" from your end.

This may be related to the "ND" mode that is also being requested by your end, but is so poorly documented on ftsc.org that I simply can't possibly implement it.

Regardless, I just worked with the sysop of Shodan's core and got the NR issue resolved.

---
þ Synchronet þ The future of BBSing

Re: Re: exec/load/binkp.js
By: Accession to Deuce on Wed Apr 13 2016 08:19 pm

The first system send an "NR" option in an OPT string is the one initiating NR mode. I'm pretty sure in the logs, your system sends it first.

You're correct there. In the logs I sent you, I did have it enabled. Now I don't, I see no OPT NR or anything from my side, yet I still see "remote is in NR mode".

I would like to see a log of that... BinkIT should NOT be seinding an M_FILE with an offset of -1 until after it gets an OPT NR from the remote. Looking at the code, I don't see how it's possible.

---
þ Synchronet þ The future of BBSing

Hello deuce,

On 13 Apr 16 18:20, deuce wrote to CVS commit:

exec/load binkp.js 1.58 1.59
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv10985/load

Modified Files:
binkp.js
Log Message:
Send an M_FILE .. ... 0 after an M_GET after an M_FILE .. ... -1
Should finish fixing the problem reported by Accession and Android
8675.

Thank you kindly, sir! He applied the changes, and we just had our first successful connection in months! :)

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20160322
þ Synchronet þ thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

exec/load binkp.js 1.59 1.60
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv23425/load

Modified Files:
binkp.js
Log Message:
Fix non-NR transfers broken in last commit.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.61 1.62
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv4141/load

Modified Files:
binkp.js
Log Message:
BinkP.js requires FIDO, not SBBSEchoCfg.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.64 1.65
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv26323/load

Modified Files:
binkp.js
Log Message:
Handle new send() return value in the same manner. This can be fixed more correctly now though.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec/load binkp.js 1.70 1.71
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv10844/load

Modified Files:
binkp.js
Log Message:
Set sentempty if we send an eob while senteob is true.
May fix infinite M_EOB ping-pong on some v1.1 connections.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.71 1.72
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv29878

Modified Files:
binkp.js
Log Message:
For outgoing connections, if there is a password, and the remote accepts it, mark the session as secure. Works around Radius/4.010/21.01.2005,13:56(Final-Release)/Win32
not sending the reccomended M_OK argument.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.72 1.73
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv1807/load

Modified Files:
binkp.js
Log Message:
Send M_ERR instead of M_OK when a link's password doesn't match.
I'm probably doing something wrong here, since I didn't write this code (particularly if there are multiple advertised addresses in the session
which we have configured links for) - but this should at least give Al something to test.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.73 1.74
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv20760/load

Modified Files:
binkp.js
Log Message:
Work around issue with Internet Rex 2.29 Win32 (binkp/1.1)
Does not support CRAM-MD5 challenges longer than 16 bytes (32 hex chars)




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.74 1.75
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv21073/load

Modified Files:
binkp.js
Log Message:
Added some helpful log messages when starting/finishing the transfer of
files (sending or receiving).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.75 1.76
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv11402/load

Modified Files:
binkp.js
Log Message:
Inlcude more more version details in the log output (so I can stop having
to ask sysops after they've already pasted log output into a help request). Also, include the sbbs version in the BinkP "VER" message excahanged with
the BinkP peer.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.76 1.77
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv11366/load

Modified Files:
binkp.js
Log Message:
Allow the default CRAM challenge length (16 bytes) to be overridden
(e.g. for experimental purposes) via binkit.ini:
cram_challenge_length = <length in bytes>



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.77 1.78
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv30675

Modified Files:
binkp.js
Log Message:
Log the peer mailer version report with a LOG_INFO level message.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.78 1.79
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv4249/load

Modified Files:
binkp.js
Log Message:
Add TLS support to binkp.

The *first* packet from the answering side *must* be an M_NUL "OPT TLS".
If this is the case, the originating size responds with an M_NUL "OPT TLS". After this, the answering system performs a server TLS handshake, and the originating system performs a client TLS handshake.

OPT CRYPT is not used in this case (ie: not crypt over TLS)




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.79 1.80
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv6697

Modified Files:
binkp.js
Log Message:
Remove magical return type of auth callback.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.80 1.81
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv7825

Modified Files:
binkp.js
Log Message:
Copy the comment about VER Internet Rex 2.29 Win32 (binkp/1.1) to where
the challenge length is set and add a TODO comment there.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.81 1.82
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv3897

Modified Files:
binkp.js
Log Message:
We need to send M_NUL "OPT TLS" before M_NUL "OPT CRYPT".




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.82 1.83
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv8552

Modified Files:
binkp.js
Log Message:
Since we're supporting TLS now, use the sock.recv() timeout parameter instead of poll()ing for each byte.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.83 1.84
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv10472

Modified Files:
binkp.js
Log Message:
Don't use a separate OPT line for TLS, it seems to mess up Radius/4.010/21.01.2005,13:56(Final-Release)/Win32



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.84 1.85
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv30624/load

Modified Files:
binkp.js
Log Message:
Fix handling of timeouts vs. errors... they're not the same, so don't treat them that way. Also, ensure there's a timeout on the second byte of the
packet header since we toss out the first byte if the second byte times out (they should pretty much always be in the same packet, but why take the risk?)




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.85 1.86
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv32581/load

Modified Files:
binkp.js
Log Message:
Add a new send_chunks() method which will deal with short send() calls.
We can't rely on our send buffers being infinite anymore.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.86 1.87
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv4584/load

Modified Files:
binkp.js
Log Message:
Push an M_SKIP into the failed_sent_files() from the pending_ack array, not from the currently sending file, since the pending ack should always be there, but sending often won't be. Also, log a warning when pending_ack isn't empty and we get an M_EOB.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.87 1.88
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv21088/load

Modified Files:
binkp.js
Log Message:
Add some temporary debug logspam.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.88 1.89
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv21475/load

Modified Files:
binkp.js
Log Message:
Terminate string.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.89 1.90
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv24625/load

Modified Files:
binkp.js
Log Message:
Overhaul EOB handling... just count them, and reset both to zero on non-EOB
in either direction.

For v1.0, a single EOB in both directions terminates the session and for
v1.1, two EOBs in both directions terminates.

This should greatly simplify the overly complicated senteob/sentempty/goteob/ gotempty logic and completely eliminate loops. Biggest risk with this change is issues with v1.0 servers.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.90 1.91
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv26747/load

Modified Files:
binkp.js
Log Message:
Fixes for v1.0 mode...
1) Don't reset eob counts for sent or got.
2) Ensure M_GET is never sent in v1.0 mode.
3) Only send one M_EOB in v1.0 mode, even if we add to the list with M_GET

This should cover all the bases, but FREQ may be non-conformant.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.91 1.92
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv24456

Modified Files:
binkp.js
Log Message:
TLS is apparently causing issues, remove it since nobody else supports it anyway.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.92 1.93
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv27765/load

Modified Files:
binkp.js
Log Message:
Pass the timeout argument to the data recv() call




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.93 1.94
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv27129/load

Modified Files:
binkp.js
Log Message:
No need to send M_EOB while receiving a file, it'll settle out at the end.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.94 1.95
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv27321/load

Modified Files:
binkp.js
Log Message:
For v1.1 connections, send two EOBs before raising the timeout. It seems that Radius/4.010/21.01.2005,13:56(Final-Release)/Win32 will not send an M_EOB
until it receives two from the remote.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.95 1.96
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv27882/load

Modified Files:
binkp.js
Log Message:
Add comment (pending testing), and fix bug in last commit.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.96 1.97
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv29069/load

Modified Files:
binkp.js
Log Message:
Don't send a second M_EOB until we get an M_EOB from the remote.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.97 1.98
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv29871/load

Modified Files:
binkp.js
Log Message:
Only use reset_eob() to reset eob counts. Don't reset the EOB counts except for in file transfer related times.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.98 1.99
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv1286

Modified Files:
binkp.js
Log Message:
More log details with regards to timeouts and successful authentication.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.99 1.100
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv28809/load

Modified Files:
binkp.js
Log Message:
On a recv() of zero bytes, check if the socket is still connected.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.100 1.101
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv17152/load

Modified Files:
binkp.js
Log Message:
Inspired by revision 1.36, only reset senteob when we add a file. Appears
to work around Radius hang. Also, in v2 mode, when we're close()ing, try
to send two M_EOB to help work around weird/broken remotes.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.101 1.102
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv10087

Modified Files:
binkp.js
Log Message:
Fix line 1196: ReferenceError: reset_eob is not defined



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.102 1.103
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv23847

Modified Files:
binkp.js
Log Message:
Raise the log-level severity (from DEBUG to NOTICE) when sending any M_ERR messages. There's a lot of places in this script where we just send a
(somewhat explanatory) M_ERR string, but don't log anything locally unless debug-level logging is enabled, now we'll at least log those messages with
a bit higher severity.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.103 1.104
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv32126/load

Modified Files:
binkp.js
Log Message:
Attept to work around Mystic CRAM+CRYPT issue.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.104 1.105
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv32701/load

Modified Files:
binkp.js
Log Message:
Add comment in binkp about why we detect Mystic as well.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.105 1.106
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv1118/load

Modified Files:
binkp.js
Log Message:
Store the remote software version in the BinkP object, don't do special
stuff in binkp.js, only the protocol. BinkIT now does the Mystic check.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.106 1.107
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv31064

Modified Files:
binkp.js
Log Message:
More log output around connecting to a node.
I suspect that connect() may be blocking and causing Al's reported issue
(A BinkIT poll never returns from the script and goes into some kind of infinite busy loop).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.107 1.108
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv545

Modified Files:
binkp.js
Log Message:
Fix what appears to be a few potential infinite loops where
recvFrame() is being called in a loop and only breaking on specific
conditions or if recvFrame returned undefined. Problem is, on timeout, recvFrame returns null (and when using === comparision, undefined !== null). Also added more debug output around sends where I suspect there might be another potential infinite loop.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.108 1.109
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv11895

Modified Files:
binkp.js
Log Message:
Fix potential infinite loop in send_chunks(), some versions of Socket.send() can return false on error, which is >= 0, so this will just add 0 to the
length and keep on looping forever in that case.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.110 1.111
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv27619

Modified Files:
binkp.js
Log Message:
Can't be the current 'sending' file if we ain't sending no file.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.111 1.112
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv5423

Modified Files:
binkp.js
Log Message:
Log the 'remote_addrs' value with each log message of LOG_ERR severity
(yeah, those should all be LOG_ERR, not LOG_ERROR - oh well) since LOG_ERR messages go to the data/error.log and including this information is helpful
to sysops that monitor this file and use it to help find/debug issues.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.112 1.113
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv16347

Modified Files:
binkp.js
Log Message:
3 new BinkP properties:
.remote_operator (the value of the 'ZYZ' message, if received) .remote_capabilities (the value of the 'NDL' message, if received) .remote_info[], an associative array of any/all *other* M_NUL BinkP
commands/messages (e.g. bp.remote_info['TIME'] contains the remote TIME
message arguments, if such a message was received).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.113 1.114
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv26978

Modified Files:
binkp.js
Log Message:
New BinkP properties:
.connect_host
.connect_port
.connect_error
Allows the application (binkit.js) to log detailed BinkP.connect() failures.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.115 1.116
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv23631

Modified Files:
binkp.js
Log Message:
When connecting a linked-node configured for PlainAuthOnly:
- don't advertise support for encryption (by sending an "OPT CRYPT" message)
- don't complain (send "Encryption requires CRAM-MD5" M_ERR) if the remote
doesn't support CRAM-MD5



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.116 1.117
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv18909

Modified Files:
binkp.js
Log Message:
If plain_auth_only (PlainAuthOnly) is true, then we won't be encrypting.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.117 1.118
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv12179

Modified Files:
binkp.js
Log Message:
Better error message (consistent with binkit.js):
"CRAM-MD5 authentication required" instead of "MD5 required"



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.118 1.119
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv27843/load

Modified Files:
binkp.js
Log Message:
Since Revision 1.36 of load/fidocfg.js (Jan-8-2019), a blank/unconfigured
BinkP session password ("SessionPwd") in sbbsecho.ini would cause BinkIT/BinkP to behave as though a session password was specified. The reason for the change to fidocfg.js (specifying a default value for "SessionPwd" as a blank string) was to force the return value to a string so that numeric passwords were not returned as numbers but rather strings.
The binkit.js and binkp.js code assumed that a blank password would be 'undefined' and not a blank string.
This commit changes binkit.js and binkp.js to treat all of the following session password values as "no password" with respect to BinkP:
- false
- undefined
- blank string ('')




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.120 1.121
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv22124/load

Modified Files:
binkp.js
Log Message:
Use ConnectedSocket class to support outgoing IPv6 connections.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec/load binkp.js 1.122 1.123
Update of /cvsroot/sbbs/exec/load
In directory cvs:/tmp/cvs-serv22684

Modified Files:
binkp.js
Log Message:
When a file fails to open, log the error value, e.g. this:
Error 24 opening '../fido/outbound/5e7a2520.pkt'. Not sending.
instead of this:
Unable to open '../fido/outbound/5e7ab832.pkt'. Not sending.

Error 24 is "too many open files", btw. Another problem to solve.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d1566e7d7b3a9e013f244cea
Modified Files:
exec/load/binkp.js
Log Message:
Don't assume the BinkP VER message contains 3-space-delimited fields.

According to both FTS-1026 and FSP-1024, the "mailer version" portion of this msg may contain spaces. Some mailers (e.g. Internet Rex), provide their version information with spaces, e.g. "Internet Rex 2.67 beta 1a OS/2 (binkp/1.1)", which also include a non-conformant protocol version indicator:
" (binkp/1.1)" instead of " binkp/1.1".
Additionally, only require that "binkp/" exist in the string, to find and
parse the protocol version number, which is apparently critical to the proper operation of the protocol. This should resolve issue #185 reported by altere.

I'm also storing the entire VER response in the binkp.remote_ver property and this will break the older Mystic/BinkP work-arounds in binkit.js. I dont' think we really need those workarounds any longer however. We'll soon see I guess.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b846192f8b436fac248fd9d9
Modified Files:
exec/load/binkp.js
Log Message:
Just parse VER using /^VER (.*) ([^ ]*?)$/

This restores the meaning of remote_ver and still has a hack for
broken, unfixable mailers that don't advertise protocol v1.1
correctly (ie: Irex)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6b6a6f506c94d2ae98735741
Modified Files:
exec/load/binkp.js
Log Message:
Log warning when peer does not indicate binkp/1.1 correctly, but
we assume it's 1.1 anyway.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/aba949fa751a58c9e781372d
Modified Files:
exec/load/binkp.js
Log Message:
Add comment containing what Internet Rex sends.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d218c8de9ff3cd359f101409
Modified Files:
exec/load/binkp.js
Log Message:
"Handle" frames with a data length of zero.

These frames were already not allowed in the binkp/1.0 protocol,
and it is mentioned in the spec (issued in 2005) as "Some old
implementations do send empty frames as the last frame.".

It's certainly not allowed now, and any mailer which does it is
broken.

For zero-length data packets, it will be seen as a frame containing
zero data bytes which will also be logged as being after the file
if it comes after the file has already been completely transferred.

A zero-length command packet will abort with M_ERR, logging an error
regarding command number NaN or something like that.

This may fix #185 since attempting a recv() of zero bytes and
succeeding is the only way I can see for a zero second timeout to
have been logged in receving frame data. The software assumed that
receiving zero bytes was a timeout, but if that's what you asked for,
it's actually success.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f6cc52385b146eb2def3ad21
Modified Files:
exec/load/binkp.js
Log Message:
Apparently we're editing file revisions like cavemen now.

Call this one "2"
Flashbacks to manually editing zone files here.
I may end up going with YYYYMMDD numbers like I sometimes did in
zone files, but maybe I'll just do the single number thing... not
really sure yet.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a0b4a7cf8e4e1b79e75805ed
Modified Files:
exec/load/binkp.js
Log Message:
Perform super-graceful shutdown of the socket on success.

This should guard against a RST being sent on success. It's possible
that the remote has sent data (ie: M_EOB) we would recv() after we
commit to ending the session. If the script terminates while there
is data to be read, this would result in sending a RST.

To prevent this, we call shutdown(sock, SHUT_WR) via setting is_writeable
to false (because that's how we roll), then recv() all data until the
remote closes the session, or the timeout passes.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4322be29d519e065d4ba114a
Modified Files:
exec/load/binkp.js
Log Message:
Fix this.sock is undefined error.

Not sure how we get a successful shutdown after closing the socket,
but the issue was reported by altere as happening in the wild.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3b166abe0fbe19a8bbfd8f01
Modified Files:
exec/load/binkp.js
Log Message:
The property is ver1_1, not ver_1.1

This should fix the binkd issue.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b3a0377ee41701681e2723c2
Modified Files:
exec/load/binkp.js
Log Message:
And bump rev.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/93c9d7e0bf770a5a3b626ec4
Modified Files:
exec/load/binkp.js
Log Message:
Log the error on first-byte recv() timeout.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8ef5e6c9dbaa2e086e2adc5a
Modified Files:
exec/load/binkp.js
Log Message:
Address "TypeError: buf is null" reported by Melkor

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4dd32231f18bcb4f67833c36
Modified Files:
exec/load/binkp.js
Log Message:
Resolve undetected or infinitely-retried socket-send failures

My hub (1:218/700) is currently having what appears to be a TCP/IP
connectivity issue that was resulting in infinite "Send failure"
log messages and "We got an M_EOB, but there are still N files pending M_GOT" log messages.

I first added better socket-send failure detection (checking return value of sendCmd() and sendData() where needed) and then noticed that failure to send
a file was not detected (the sending.file.position is advanced even if sendData() fails), so now handling that condition too.

Also added more diagnostics around socket-send failures (is socket writable?) in this particular case, the socket is not writable and socket-send is returning 0.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c3a41492a79aa3c6b3a41b37
Modified Files:
exec/load/binkp.js
Log Message:
More errno details in file open and socket-send failure warning log msgs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0ea1ce1d2600b79a77d41b7e
Modified Files:
exec/load/binkp.js
Log Message:
Use socket.poll() to check socket for writability before send()

This is the real fix for infinite-wait on send() problem that was attempted
in commit f0127e9d457, but caused other issues. Thanks Deuce.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net