• src/conio/x_events.c

    From deuce@VERT to CVS commit on Monday, August 24, 2015 18:30:34
    src/conio x_events.c 1.27 1.28
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv23104

    Modified Files:
    x_events.c
    Log Message:
    Fix warning.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Thursday, February 08, 2018 17:38:52
    src/conio x_events.c 1.40 1.41
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv14483

    Modified Files:
    x_events.c
    Log Message:
    Give X11 output some love...

    Dont allocate/free the xim every rectange
    Don't allow updates from ciolib to starve the X event queue (ie: key strokes)




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Tuesday, February 13, 2018 09:06:54
    src/conio x_events.c 1.43 1.44
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv18274

    Modified Files:
    x_events.c
    Log Message:
    Translate bitmap_con.c RGB values to visual pixel values.
    Set all unused bits 'cause they may be transparency.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Tuesday, February 13, 2018 21:41:25
    src/conio x_events.c 1.44 1.45
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv17490

    Modified Files:
    x_events.c
    Log Message:
    Not everyone runs FreeBSD, so put a bit of FreeBSD libc in here.

    Too lazy to write me own fls() basically.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Thursday, February 15, 2018 12:48:10
    src/conio x_events.c 1.45 1.46
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv31398

    Modified Files:
    x_events.c
    Log Message:
    Some updates to make X11 mode more efficient for remote terminals...
    1) Send updates in 16-lines chunks rather than a single large update.
    2) Keep the last screen rectangle around, and compare against it.
    3) pre-calculate values.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Thursday, February 15, 2018 12:49:08
    src/conio x_events.c 1.46 1.47
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv31579

    Modified Files:
    x_events.c
    Log Message:
    Free and NULL the last rect when resizing the xim.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Thursday, February 15, 2018 12:54:00
    src/conio x_events.c 1.47 1.48
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv32108

    Modified Files:
    x_events.c
    Log Message:
    More optimization... track top and bottom.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Tuesday, February 20, 2018 11:31:51
    src/conio x_events.c 1.48 1.49
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv23100

    Modified Files:
    x_events.c
    Log Message:
    Serious error in local_draw_rect() here.
    Thanks Coverity!



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Monday, July 15, 2019 12:23:53
    src/conio x_events.c 1.49 1.50
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv5692

    Modified Files:
    x_events.c
    Log Message:
    Fix some resizing issues.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Thursday, July 18, 2019 13:38:06
    src/conio x_events.c 1.51 1.52
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv18353

    Modified Files:
    x_events.c
    Log Message:
    Fix copy/paste error.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Thursday, July 25, 2019 11:51:20
    src/conio x_events.c 1.52 1.53
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv16635

    Modified Files:
    x_events.c
    Log Message:
    Sanity check last.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Thursday, July 25, 2019 11:51:57
    src/conio x_events.c 1.53 1.54
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv16692

    Modified Files:
    x_events.c
    Log Message:
    Add TODO because CVS is down.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Thursday, July 25, 2019 11:53:23
    src/conio x_events.c 1.54 1.55
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv17014

    Modified Files:
    x_events.c
    Log Message:
    Fix er up.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Thursday, July 25, 2019 12:10:20
    src/conio x_events.c 1.55 1.56
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv20140

    Modified Files:
    x_events.c
    Log Message:
    Don't raw anything but currently-correct rect sizes.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Friday, March 06, 2020 23:26:47
    src/conio x_events.c 1.56 1.57
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv4478

    Modified Files:
    x_events.c
    Log Message:
    Always redraw the screen on an expose event (this was actually a bug)
    Avoid gratuitous xim reallocations (not a bug)
    Avoid gratuitous redraws (not a bug)
    Avoid posting and waiting on a semaphore from the same thread (ehhhh....)
    After blocking on XNextEvent(), drain all X events in the queue (not a bug)




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Monday, April 13, 2020 11:05:35
    src/conio x_events.c 1.59 1.60
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv19003

    Modified Files:
    x_events.c
    Log Message:
    Clean up copy/paste per ICCCM.
    If this doesn't fix the copy/paste issues nelgin was having, nothing will.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Tuesday, April 14, 2020 12:11:44
    src/conio x_events.c 1.61 1.62
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv29839

    Modified Files:
    x_events.c
    Log Message:
    Fix issue with X11 textmode() implementation.
    The xim wasn't scaled to the new size (ever)



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Tuesday, April 14, 2020 12:25:50
    src/conio x_events.c 1.62 1.63
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv32048

    Modified Files:
    x_events.c
    Log Message:
    Resize the window if X and Y aren't scaled the same amount.
    Resize the xim if the window isn't scaled.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Friday, April 17, 2020 10:12:23
    src/conio x_events.c 1.66 1.67
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv18803

    Modified Files:
    x_events.c
    Log Message:
    XA_STRING is explicitly ISO-8859-1




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Friday, April 17, 2020 13:00:41
    src/conio x_events.c 1.68 1.69
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv12931

    Modified Files:
    x_events.c
    Log Message:
    Use chars if neither of ALT or CTRL are pressed, scancodes otherwise.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Friday, April 17, 2020 13:20:02
    src/conio x_events.c 1.69 1.70
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv16558

    Modified Files:
    x_events.c
    Log Message:
    Throw out the last rect when changing modes.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Monday, April 20, 2020 14:05:22
    src/conio x_events.c 1.71 1.72
    Update of /cvsroot/sbbs/src/conio
    In directory cvs:/tmp/cvs-serv32525

    Modified Files:
    x_events.c
    Log Message:
    Fix input translation... default cpchar is zero.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Tuesday, May 04, 2021 18:02:29
    https://gitlab.synchro.net/main/sbbs/-/commit/2e41ce253c9ee33ae32f5732
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Optimize pixel calculations.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, May 14, 2021 17:43:55
    https://gitlab.synchro.net/main/sbbs/-/commit/b41875882ed704448e5cd439
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Clear the entire window when the xim size is potentially changed.

    This fixes issues where "leftovers" from the previous mode would
    remain in a new screen mode.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, May 14, 2021 17:50:59
    https://gitlab.synchro.net/main/sbbs/-/commit/62b34c6173d9962581a6792e
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Support ALT-Left/ALR-Right for scaling adjustment in X11 mode.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, May 14, 2021 21:57:22
    https://gitlab.synchro.net/main/sbbs/-/commit/ca22bd6d57b9c2b6ce5293ba
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fix issue where X11 window would be blank on an Expose event.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Monday, May 17, 2021 21:52:16
    https://gitlab.synchro.net/main/sbbs/-/commit/30921159174c7a59fe366d57
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Add a function to translate event coordinates to screen

    Fixes issue 56

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, May 19, 2021 18:08:44
    https://gitlab.synchro.net/main/sbbs/-/commit/0748cc1e70b9361fb311b931
    Modified Files:
    src/conio/x_events.c
    Log Message:
    No need to resize window just because it moved.

    Fixes X11 window dragging blinkiness.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thursday, May 20, 2021 00:38:49
    https://gitlab.synchro.net/main/sbbs/-/commit/99eec30f33a00c0f80daeb44
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Eliminate unused variable that I guess clang doesn't warn about but gcc does.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, May 21, 2021 16:23:13
    https://gitlab.synchro.net/main/sbbs/-/commit/a7a1c2689791e8e721946f8f
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fix newly-introduced memory leak...

    I was going to start keeping the old rect around again, but that
    idea didn't pan out. This massive memory leak is what I get for
    not doing more commits while tuning.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, June 02, 2021 23:08:27
    https://gitlab.synchro.net/main/sbbs/-/commit/4c89829e0d5f7aaa9153b364
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Avoid directly manipulating XImage data for now.

    The previous tests to detect RGB8 appear to have been insufficient.
    This may have resulted in various artifacts such as transparency with
    some drivers on some hardware in X11 mode.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, June 02, 2021 23:08:27
    https://gitlab.synchro.net/main/sbbs/-/commit/c38a9758a15a7f51d41f0cce
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Remove debug output introduced in last commit

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Thursday, May 04, 2023 13:18:39
    https://gitlab.synchro.net/main/sbbs/-/commit/646c7e10fe6c138fa7e095f8
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Remove unised variable.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Thursday, May 04, 2023 18:48:57
    https://gitlab.synchro.net/main/sbbs/-/commit/0544e9c52e731ffa4d157918
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Handle all possible failure paths before calling bitmap_drv_init()

    Should fix auto-curses mode crash.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, May 06, 2023 23:47:15
    https://gitlab.synchro.net/main/sbbs/-/commit/c6d284b31bd859b9b70587d7
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Swap the order of defaults so vstat.scaling only gets written once

    This is just to make it less noise to watch vstat.scaling from gdb.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Sunday, May 07, 2023 01:02:20
    https://gitlab.synchro.net/main/sbbs/-/commit/96252a524edfdd8b7952062f
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Call resize_window() after initing a mode, call XResizeWindow() if x_cvstat doesn't match cvstat.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Sunday, May 07, 2023 01:16:56
    https://gitlab.synchro.net/main/sbbs/-/commit/acc0bffc446abdbb27455127
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fixup vstat after bitmap_drv_init_mode()

    Now that vstat is what was last drawn on the screen we need to
    save/restore the width/height around calls to bitmap_drv_init_mode().

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Sunday, May 14, 2023 20:34:06
    https://gitlab.synchro.net/main/sbbs/-/commit/cf317d5db18cfadec0a2a6fa
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fix (unlikely) deadlock when load_vmode() fails.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Sunday, May 14, 2023 20:42:45
    https://gitlab.synchro.net/main/sbbs/-/commit/87f05b6d89fd176435a80fd0
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Use vstat.scaling not x_cvstat.scaling to scale to screen.

    Also, do not try to display frames where the scaled height or width
    is less than the frame bitmap height or width.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Sunday, May 14, 2023 21:10:08
    https://gitlab.synchro.net/main/sbbs/-/commit/00aeb6ecf848d69ccecad87e
    Modified Files:
    src/conio/x_events.c
    Log Message:
    More X optimizations

    Now that bitmap_drv_request_some_pixels() just calls bitmap_drv_request_pixels(), there's no point in calling expose_rect()
    when ev->xexpose.count isn't zero.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Sunday, May 14, 2023 21:26:27
    https://gitlab.synchro.net/main/sbbs/-/commit/9b165510cb465af2403e014d
    Modified Files:
    src/conio/x_events.c
    Log Message:
    On a ConfigureNotify event, only call handle_resize_event() if size changed.

    This mirrors commit 0748cc1e about a year ago that optimized window
    dragging, and performs basically the same check (removed a week ago
    with commit b4ce023c)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Tuesday, May 16, 2023 08:55:29
    https://gitlab.synchro.net/main/sbbs/-/commit/d8de9251cafb98c47857bccd
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Use video mode aspect ratio when defined rather than pixel size.

    There's no good argument for this aside from "it feels more right".

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, June 02, 2023 11:25:51
    https://gitlab.synchro.net/main/sbbs/-/commit/860680f59f8790f0893f3fdc
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fix inverted logic in last commit

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, June 02, 2023 12:55:19
    https://gitlab.synchro.net/main/sbbs/-/commit/4bfdec46f56ca4ae0711bf0d
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fiddle with WM_NORMAL_HINTS a bit.

    USize was wrong, PSize wasn't set, and PBaseSize was set, but flag wasn't.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, June 02, 2023 15:18:20
    https://gitlab.synchro.net/main/sbbs/-/commit/fcf101424c46e57a3ff36b87
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Ye old typo in last commit

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to Git commit to main/sbbs/master on Friday, June 02, 2023 18:31:56
    https://gitlab.synchro.net/main/sbbs/-/commit/ae643313d5df9f3dfe4fe6be
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Disable X Synchronize and some minr optimizations in set_icon()

    The XSynchronize disablement is the most important here... didn't
    realize it defaulted to enabled, which has been slowing down a *lot*
    of stuff for a long time... not that there's much left that benefits
    from disabling Synchronized XLib except this new terrible icon thing.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to Git commit to main/sbbs/master on Friday, June 02, 2023 19:10:04
    https://gitlab.synchro.net/main/sbbs/-/commit/76641ca7d66bdd0eaa86bc9e
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Set _NET_WM_PID

    Seems like a good idea, should allow WMs to kill hung processes and
    stuff like that.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to Git commit to main/sbbs/master on Friday, June 02, 2023 19:54:56
    https://gitlab.synchro.net/main/sbbs/-/commit/20d77d5a501bcb51eb98d31c
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Implement the _NET_WM_PING protcol

    Implied by _NET_WM_PID being set, so may as well do it.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, June 03, 2023 01:05:25
    https://gitlab.synchro.net/main/sbbs/-/commit/b0feed94406571e18586f8fb
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fix use of uninitialized value

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, June 03, 2023 01:12:36
    https://gitlab.synchro.net/main/sbbs/-/commit/11050ff199521fe2b09686ff
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fix up source/last for external scaling

    This was ending up using an uninitialized value

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, June 03, 2023 02:35:51
    https://gitlab.synchro.net/main/sbbs/-/commit/d3a6cc915ab802da7f0fbdf3
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fix typo in line 666

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, June 03, 2023 18:24:42
    https://gitlab.synchro.net/main/sbbs/-/commit/f3817229ab1a1eafac543d49
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Increment offset in the loop when reading _NET_WORKAREA

    Previously, if there was more than one work area, this would be
    an infinite loop, re-reading the first workarea repeatedly.

    Reported by Ragnarok (thanks!)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to Git commit to main/sbbs/master on Sunday, June 04, 2023 07:11:56
    https://gitlab.synchro.net/main/sbbs/-/commit/08f465dbb94c3a6580f702de
    Modified Files:
    src/conio/x_events.c
    Log Message:
    More fullscreen work, get resize working

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to Git commit to main/sbbs/master on Monday, June 05, 2023 08:26:33
    https://gitlab.synchro.net/main/sbbs/-/commit/3b7791526d3cd7263c2d654d
    Modified Files:
    src/conio/x_events.c
    Log Message:
    For Sommelier (ie: ChromeOS), use CLIPBOARD not PRIMARY

    ChromeOS (as of Jun 2023) effectivly makes PRIMARY useless. Just
    do the wrong thing and use CLIPBOARD instead. This makes it much
    more likely that SyncTERM selections will clobber CLIPBOARD
    unintentionally, but we have no choice... DigitalMan doesn't use
    X11 mode solely because ChromeOS sucks at X11.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Monday, June 05, 2023 10:55:30
    https://gitlab.synchro.net/main/sbbs/-/commit/6ec4d431f63669f30b07f4be
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fix some highly unlikely memory leaks

    - Ensure last is cleared even if we manage external scaling without Xrender
    - Free the bitmap rectangle in the same situation
    - Make a copy of x_internal_scaling so it's used consistently
    (not mutex protected, and accessed from multiple threads)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Monday, June 05, 2023 11:48:32
    https://gitlab.synchro.net/main/sbbs/-/commit/7f01faf0ca9f9fd0939e0184
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fix wildly incorrect usage of set_win_property().

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Monday, June 05, 2023 15:25:23
    https://gitlab.synchro.net/main/sbbs/-/commit/d0280d9d8272860d4523eb09
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fix fullscreen external scaled X11 mode

    Was not using struts, and was scaling to window size, not aspect
    ratio size.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Monday, June 05, 2023 16:16:39
    https://gitlab.synchro.net/main/sbbs/-/commit/2d3f4e18c1168e575175bf18
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fix black bar generation

    Was wrong and therefore causing flickering.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to Git commit to main/sbbs/master on Tuesday, June 06, 2023 22:33:12
    https://gitlab.synchro.net/main/sbbs/-/commit/9ef4042cfdc943eb7a75cd29
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Some minor fixups...

    On expose, always redraw the entire screen. The calculations were
    wrong and with fractional scaling, some of them will always be wrong.

    Don't clear the screen when xim is resized.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, June 07, 2023 20:19:00
    https://gitlab.synchro.net/main/sbbs/-/commit/e1a6e1ac8e83d2e41a394bc6
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Attempt to set resource name/class correctly for XIM

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to Git commit to main/sbbs/master on Thursday, June 08, 2023 08:56:39
    https://gitlab.synchro.net/main/sbbs/-/commit/325bafccd9c2a51c17cdd1ed
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Missed a 'C' in ICCCM

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Sunday, June 11, 2023 20:29:01
    https://gitlab.synchro.net/main/sbbs/-/commit/04efb20ca85d82b36d5b554e
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Don't require caller to call textmode() before showing window

    Fixes recent regression with scfg

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Monday, June 12, 2023 17:31:20
    https://gitlab.synchro.net/main/sbbs/-/commit/503cff8671462889d573ee26
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fix GCC v10.2 warnings about ignored return values of 'write'

    The return value of x11_event() isn't actually checked anywhere currently, but still Deuce might want to adjust the new return value here (__LINE__ or -1?).

    Some indicental trailing whitespace was auto-cleaned up part of this commit. Unexpected as I thought this code had been uncrustified already.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Monday, June 12, 2023 17:35:24
    https://gitlab.synchro.net/main/sbbs/-/commit/58ed4743698f8f3539c27931
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Make x11_event() a bool

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Monday, June 12, 2023 17:50:01
    https://gitlab.synchro.net/main/sbbs/-/commit/00ab0718520a123a36113a43
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Actually, this is a blocking write, just compare with -1

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Monday, June 12, 2023 18:00:27
    https://gitlab.synchro.net/main/sbbs/-/commit/777fb6d8bec3c7dd85e6d919
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Actually, don't bother returning a value that's never used.

    Still be sure to check the return value of write() though.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Thursday, June 15, 2023 15:34:31
    https://gitlab.synchro.net/main/sbbs/-/commit/e61a1aa6c7b27242fc1d0340
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Use XDG_ENVIRONMENT_TYPE to switch to CLIPBOARD

    It appears that XDG_ENVIRONMENT_TYPE will always equal "wayland"
    when XWayland is in use, so when we see that, switch to CLIPBOARD
    instead of PRIMARY. This should fix WSL and ChromeOS, and be
    irritating on GNOME, so it's a win all around.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to Git commit to main/sbbs/master on Thursday, June 15, 2023 17:32:20
    https://gitlab.synchro.net/main/sbbs/-/commit/4f504677859909d59443a17b
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Revert "Use XDG_ENVIRONMENT_TYPE to switch to CLIPBOARD"

    This reverts commit e61a1aa6c7b27242fc1d03401b4240c6f58ac311.

    It turns out neither platform this targeted actually set that
    variable correctly.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, June 28, 2023 09:52:07
    https://gitlab.synchro.net/main/sbbs/-/commit/d60cc9637f418ab7aa897945
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Remove stale code from net_wm_state_is_cb()

    It's unlikely this is what Digitalman reported from ASan and UBSan

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Monday, July 03, 2023 20:26:18
    https://gitlab.synchro.net/main/sbbs/-/commit/0a6fdb956890d029bfdb230f
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fix crash in net_wm_state_is_cb when running GCC ASan-enabled build

    Check size of X11 property before dereferencing as an Atom.
    This fixes:
    ==10203==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000065970 at pc 0x5c5834fb8812 bp 0x7819c717c220 sp 0x7819c717c218
    READ of size 8 at 0x602000065970 thread T2 (X11 Events)
    #0 0x5c5834fb8811 in net_wm_state_is_cb ../conio/x_events.c:1541

    But I'm not clear when nitems_return (nir) might represent > 8-bit items or how to detect that, so perhaps there's a *better* fix?

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Monday, July 03, 2023 22:32:04
    https://gitlab.synchro.net/main/sbbs/-/commit/e32a036b1b615aa2c07cbefc
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Revert "Fix crash in net_wm_state_is_cb when running GCC ASan-enabled build"

    This reverts commit 0a6fdb956890d029bfdb230f3fec17110690a471.

    This simply caused the callback to never be called.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Monday, July 03, 2023 22:58:58
    https://gitlab.synchro.net/main/sbbs/-/commit/60668a729f1fdb570284a70c
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Ensure we get at least one item before passing to the callback

    Should fix ASan "crash".

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, July 29, 2023 14:00:52
    https://gitlab.synchro.net/main/sbbs/-/commit/f2d5534ae72cd7994e25ec77
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fix CTRL + CAPS issue in X11

    Previously, both the shift key, and the "implied shift" from CAPS
    were treated as a higher priority than the CTRL modifier. With
    this change, only the explicit shift key has priority, and the
    implicit one is only checked after CTRL is checked.

    Fixes SourceForge bug 117

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Sunday, July 30, 2023 05:25:08
    https://gitlab.synchro.net/main/sbbs/-/commit/bc3d9e44b16a9a6d06cbb909
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Move call to bitmap_drv_free_rect() out of vstatlock

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, February 07, 2024 23:16:48
    https://gitlab.synchro.net/main/sbbs/-/commit/bb9b789ca8fc185fcdfda32d
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Bow to GCC harder.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, February 14, 2024 21:38:28
    https://gitlab.synchro.net/main/sbbs/-/commit/57283c51fac9860dd350e639
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fix pasting in X11 mode... pastebuf should be UTF-8, not ISO-Latin1.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, February 16, 2024 01:19:43
    https://gitlab.synchro.net/main/sbbs/-/commit/b9c51d8b9f5aab7f368c5c76
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fix warning.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, February 16, 2024 01:52:13
    https://gitlab.synchro.net/main/sbbs/-/commit/36d37a5184d5263f8d1de3f4
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Move saved_scaling inside vstatlock.

    This shouldn't be necessary, but Coverity thinks it's a good idea,
    and it's simple enough to do without hurting anything.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Monday, February 19, 2024 16:27:34
    https://gitlab.synchro.net/main/sbbs/-/commit/904d202aa2b0c906cf5ef25b
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Call map_window() to update size hints when resizing the window.

    This way, WMs that enforce aspect ratio etc, won't get potentially
    block the update.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to Git commit to main/sbbs/master on Tuesday, February 20, 2024 21:14:06
    https://gitlab.synchro.net/main/sbbs/-/commit/375bdb7806d6ef2996a6a7b7
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Use max when we have it, only restore size/scaling in fullscreen mode

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, February 21, 2024 09:14:06
    https://gitlab.synchro.net/main/sbbs/-/commit/f616a09a6bf5bdd88e247850
    Modified Files:
    src/conio/x_events.c
    Log Message:
    First attempt to fix "black bars" startup issue.

    The first time we receive a MapNotify or ConfigureNotify that sets
    the width and height, resize the window instead of accepting the
    current window size.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to Git commit to main/sbbs/master on Wednesday, February 21, 2024 09:30:24
    https://gitlab.synchro.net/main/sbbs/-/commit/129dd7db9d00fe4be9f9b93a
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Only count it as the "first resize" if it's not from SendEvent()

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, February 21, 2024 10:54:09
    https://gitlab.synchro.net/main/sbbs/-/commit/bd1c91e6bf0a98cb6f3ef43c
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Always base scaling on size, and alwayse resize xim.

    Fixes issue with possible corrupt display when "weird" scaling
    changes occured.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to Git commit to main/sbbs/master on Wednesday, February 21, 2024 12:17:18
    https://gitlab.synchro.net/main/sbbs/-/commit/37c79a65585b06197c219697
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Count flushes to disable resize hack.

    Instead of strictly using "first resize", also count flushes and
    assume the hack isn't needed after five. Experimentation on my
    ChromeBook shows 3 to be sufficient, so I'm sing five for now.

    Odds are that this will still mess with tiling WMs, but I don't use
    one, so I don't mind yet. I expect this will be better, but likely
    still not great.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, February 21, 2024 13:00:02
    https://gitlab.synchro.net/main/sbbs/-/commit/a130c61289d7bc2217d61665
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Lower flush count to 3.

    This is my happy place on the desktop system running xfce4... any
    higher, and it interferes with how I manage my windows.

    Hopefully, this value convers the initialization portion perfectly
    on all systems (hah!).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Thursday, February 22, 2024 05:37:17
    https://gitlab.synchro.net/main/sbbs/-/commit/fd0b6150ce3fb8c64b9ec0e3
    Modified Files:
    src/conio/x_events.c
    Log Message:
    Fix some weirdness around window sizing.

    This should fix the recent issue when a larger or smaller version
    is painted inside the window after resize, as well as fix ALT-
    when the current size is not an integer multiple.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net