• src/sbbs3/ssl.c

    From deuce@VERT to CVS commit on Thursday, August 20, 2015 01:30:32
    src/sbbs3 ssl.c 1.2 1.3
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv15095

    Modified Files:
    ssl.c
    Log Message:
    Initialize ssl_context to silence Win32 debug assertion.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Thursday, August 20, 2015 01:52:52
    src/sbbs3 ssl.c 1.3 1.4
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv15671

    Modified Files:
    ssl.c
    Log Message:
    Fix get_error_string() to terminate the temporary string, not the target string.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Sunday, August 23, 2015 13:06:33
    src/sbbs3 ssl.c 1.6 1.7
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv19924

    Modified Files:
    ssl.c
    Log Message:
    Use get_crypt_error() in get_error_string() as well.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Sunday, August 23, 2015 13:09:58
    src/sbbs3 ssl.c 1.7 1.8
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv19983

    Modified Files:
    ssl.c
    Log Message:
    Fix get_crypt_attribute()




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Sunday, August 23, 2015 13:14:04
    src/sbbs3 ssl.c 1.8 1.9
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv20046

    Modified Files:
    ssl.c
    Log Message:
    Fix get_error_string() some more.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Sunday, October 04, 2015 15:22:13
    src/sbbs3 ssl.c 1.11 1.12
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv16955

    Modified Files:
    ssl.c
    Log Message:
    Return a value from do_cryptInit().




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Wednesday, February 14, 2018 14:55:46
    src/sbbs3 ssl.c 1.12 1.13
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv27584

    Modified Files:
    ssl.c
    Log Message:
    Try adding DNS and Country names to the certificate.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Wednesday, February 14, 2018 15:14:58
    src/sbbs3 ssl.c 1.13 1.14
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv29704

    Modified Files:
    ssl.c
    Log Message:
    Adding the country doesn't help... leave the DNS name in there though.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Wednesday, February 14, 2018 21:48:11
    src/sbbs3 ssl.c 1.15 1.16
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv8473

    Modified Files:
    ssl.c
    Log Message:
    sesop -> sysop



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Wednesday, February 14, 2018 22:24:24
    src/sbbs3 ssl.c 1.16 1.17
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv12170

    Modified Files:
    ssl.c
    Log Message:
    Add the country ("ZZ") to self-signed certificates.
    Add the Organization Name (BBS name) to self-signed certificates.
    Fix the sysop email for self-signed certificates.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Wednesday, February 14, 2018 22:29:42
    src/sbbs3 ssl.c 1.17 1.18
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv13489

    Modified Files:
    ssl.c
    Log Message:
    We also need to set the SELFSIGNED attribute.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Wednesday, February 14, 2018 22:57:37
    src/sbbs3 ssl.c 1.18 1.19
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv16468

    Modified Files:
    ssl.c
    Log Message:
    Set validity to 10 years.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Monday, February 19, 2018 09:02:20
    src/sbbs3 ssl.c 1.20 1.21
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv17820

    Modified Files:
    ssl.c
    Log Message:
    Various callers tread do_cryptInit() as though it returns if cryptlib
    was successfully initialized. Make it do that.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, February 19, 2018 16:31:21
    src/sbbs3 ssl.c 1.21 1.22
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv12895

    Modified Files:
    ssl.c
    Log Message:
    Removed unused variable (scfg).


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Thursday, March 01, 2018 11:09:47
    src/sbbs3 ssl.c 1.22 1.23
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv9856

    Modified Files:
    ssl.c
    Log Message:
    Open the certificate keyset in readonly mode when we're not going to write.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Sunday, March 04, 2018 21:01:31
    src/sbbs3 ssl.c 1.24 1.25
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv32622

    Modified Files:
    ssl.c
    Log Message:
    Work around MSVC error which assumes ssl_context is used without being initialized (it's not).




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Sunday, March 04, 2018 21:02:20
    src/sbbs3 ssl.c 1.25 1.26
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv32707

    Modified Files:
    ssl.c
    Log Message:
    Add comment.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Friday, March 09, 2018 12:25:12
    src/sbbs3 ssl.c 1.26 1.27
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv7338

    Modified Files:
    ssl.c
    Log Message:
    Copy error descriptions from cryptlib.h into get_error_string() so we should always get a string in cryptlib errors. Places that don't get an error
    string should now since it should always be useful.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Friday, March 09, 2018 20:20:17
    src/sbbs3 ssl.c 1.33 1.34
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv2530

    Modified Files:
    ssl.c
    Log Message:
    #include xpprintf.h to resolve msvc warning:
    ssl.c(210): warning C4013: 'asprintf' undefined; assuming extern returning int



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Friday, March 09, 2018 20:47:51
    src/sbbs3 ssl.c 1.34 1.35
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv6089

    Modified Files:
    ssl.c
    Log Message:
    CRYPT_ENVELOPE_RESOURCE is debug-level as well.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Friday, March 09, 2018 22:05:40
    src/sbbs3 ssl.c 1.35 1.36
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv15690

    Modified Files:
    ssl.c
    Log Message:
    Fix get_ssl_cert() initialization of the error string pointer.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Friday, March 09, 2018 23:32:14
    src/sbbs3 ssl.c 1.36 1.37
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv27297

    Modified Files:
    ssl.c
    Log Message:
    Make CRYPT_ERROR_NOTAVAIL LOG_INFO level.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Saturday, March 10, 2018 02:04:18
    src/sbbs3 ssl.c 1.37 1.38
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv16002

    Modified Files:
    ssl.c
    Log Message:
    Lower CRYPT_ERROR_INTERNAL to NOTICE. Not sure the sysop can do anything
    about these.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Monday, March 12, 2018 19:00:16
    src/sbbs3 ssl.c 1.38 1.39
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv23383

    Modified Files:
    ssl.c
    Log Message:
    Make CRYPT_ERROR_NOSECURE a warning, not an error. There appear to be
    SSLv3 (!) and even SSLv2(!!) clients still in the wild. Sysops aren't
    expected to be able to fix other peoples ancient broken stuff.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wednesday, April 18, 2018 22:47:19
    src/sbbs3 ssl.c 1.39 1.40
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv29046

    Modified Files:
    ssl.c
    Log Message:
    Lower the log level of "BADDATA" cryptlib errors (-32) from ERROR to
    WARNING.
    Also fixed a couple of typos in strings.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, June 11, 2018 22:19:23
    src/sbbs3 ssl.c 1.40 1.41
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv2678

    Modified Files:
    ssl.c
    Log Message:
    Fix TLS/SSL failure/error: "creating SSL context"
    If the ctrl/ssl.cert file did not exist, the various TLS/SSL services would fail to create it and (sometimes) log the "creating SSL context" error.
    This problem was introduced with rev 1.30 (Mar-9) and the fix/patch
    provided by Deuce via irc. Thanks to Psi-Jack for the bug report.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, April 20, 2020 23:05:33
    src/sbbs3 ssl.c 1.42 1.43
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv21793

    Modified Files:
    ssl.c
    Log Message:
    Lower CRYPT_ERROR_INVALID severity from ERROR to WARNING to prevent error-log: TLS ERROR 'Received TLS alert message: Certificate unknown' (-26) setting session active


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Monday, June 05, 2023 17:47:57
    https://gitlab.synchro.net/main/sbbs/-/commit/c350764c62000603d455dabb
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    Fix error in previous commit to this file

    C allows char* p = '\0' (which is clearly wrong)
    C++ does not.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, December 18, 2023 22:03:04
    https://gitlab.synchro.net/main/sbbs/-/commit/6ae3c80132f7f2707a4aaa1e
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    Add lprintf declaration here (hack)

    This is always going to call the terminal server's lprintf function (when used with libsbbs.so/sbbs.dll) which is probably not what was intended.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Tuesday, December 19, 2023 01:36:24
    https://gitlab.synchro.net/main/sbbs/-/commit/c9a18cc4dffcd3be240d32aa
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    Don't load a cert unless the scfg_t is prepped.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Tuesday, December 19, 2023 01:37:33
    https://gitlab.synchro.net/main/sbbs/-/commit/e3365aa3e9db55b43c07d21d
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    No point checking prepped here

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, December 20, 2023 15:15:17
    https://gitlab.synchro.net/main/sbbs/-/commit/8f089bf01169601da4275d7a
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    Fix DO() macro in ssl.c

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, December 20, 2023 15:44:22
    https://gitlab.synchro.net/main/sbbs/-/commit/9d06452d26d4495e10bcbb9d
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    Properly handle the cert when adding private key fails

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, December 20, 2023 15:47:32
    https://gitlab.synchro.net/main/sbbs/-/commit/c56af712ad619df69b93b0ad
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    Fix bug in last commit to this file.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, December 20, 2023 15:49:24
    https://gitlab.synchro.net/main/sbbs/-/commit/6b0df81a4a032587c2486460
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    A little bit more fixins...

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thursday, December 21, 2023 18:07:29
    https://gitlab.synchro.net/main/sbbs/-/commit/798f1d058a73c9549830f787
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    Check return value of malloc() and log failure

    Fix CID 471381

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Tuesday, January 09, 2024 09:15:22
    https://gitlab.synchro.net/main/sbbs/-/commit/7d157b980e97dbb87258b49e
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    You can't just screw around with a pair of shared linked lists
    without locking! That's chaos!

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Tuesday, January 09, 2024 09:18:47
    https://gitlab.synchro.net/main/sbbs/-/commit/4050fabe5ff89660555f9183
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    Eliminate LOR introduced in previous commit.

    Since lock_ssl_cert() is a reader lock, there shouldn't be a whole
    lot of contention on aquiring it anyway, and we can thundering herd
    our way out of it when it clears.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, January 19, 2024 12:09:37
    https://gitlab.synchro.net/main/sbbs/-/commit/88bbe26bf67384f213df0dc1
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    Use new rwlock for ssl certificate.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Friday, January 19, 2024 12:09:37
    https://gitlab.synchro.net/main/sbbs/-/commit/c2499626c59ea535f8dc2b5e
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    Merge branch 'use-rwlock' into 'master'

    Use new rwlock for ssl certificate.

    See merge request main/sbbs!386

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, January 19, 2024 16:22:20
    https://gitlab.synchro.net/main/sbbs/-/commit/c47e29612c1f78bf1bb835ba
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    Clean up and push down locks.

    Now each lock has an easily understandable purpose, and covers the
    lowest possible amount of code.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Friday, January 19, 2024 16:30:19
    https://gitlab.synchro.net/main/sbbs/-/commit/9fdb5950548fe41960d8bbe0
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    Fix GCC warnings

    warning: value computed is not used

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, January 19, 2024 16:49:50
    https://gitlab.synchro.net/main/sbbs/-/commit/5e3c60b9a154ee1e64710f83
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    Have get_sess_list_entry() verify the correct epoch

    With this, it's not strictly necessary to clear cert_list in ssl_sync()
    when the certificate changes, but it's still a good idea to prevent
    unusable memory from being held onto.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, January 19, 2024 16:49:50
    https://gitlab.synchro.net/main/sbbs/-/commit/a437c173ec7c7dfa35625e2e
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    May as well make sure internal_do_cryptInit() actually works.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Monday, January 22, 2024 14:57:23
    https://gitlab.synchro.net/main/sbbs/-/commit/0700951f70912e516305c181
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    Mutex-protect access to cryptfail.

    Totally not sketchy, trust me.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, January 22, 2024 19:40:40
    https://gitlab.synchro.net/main/sbbs/-/commit/0aa72717d5701c3d52259674
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    Friendly cryptlib version check failure handling

    <Deuce> Feel free to not lock the mutex and never free/NULLify that string. <Deuce> Should be nicer for people with separate logs, and a few bytes never hurt anyone.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, February 07, 2024 23:00:19
    https://gitlab.synchro.net/main/sbbs/-/commit/bffceeba0fcdcacfd828351e
    Modified Files:
    src/sbbs3/ssl.c
    Log Message:
    asprintf() on Linux does not guarantee to set the ptr to NULL on error.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net