src/sbbs3 bat_xfer.cpp 1.35 1.36
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv11280

Modified Files:
bat_xfer.cpp
Log Message:
Fix bug reported by echicken in batch_add_list():
If a filename had no extension, it could not be added via batch download
list since this code was truncating all white-space off each line read.
Now it will just truncate end-of-line characters.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/sbbs3 bat_xfer.cpp 1.36 1.37
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv5250

Modified Files:
bat_xfer.cpp
Log Message:
Use SAFECAT() to address Coverity-reported concerns.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 bat_xfer.cpp 1.39 1.40
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22705

Modified Files:
bat_xfer.cpp
Log Message:
For Electrosys:
- Move files from temp directory to uploads directory *before* determining what the short filename is going to be (since the underlying file system can change the short filename during that process). This should resovle the issue of blind-uploading multiple files with long filenames that begin with the same prefix of 6-8 characters.
- Batch upload queue processing wasn't touched as part of this change. That logic probably also could use a similar fix.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 bat_xfer.cpp 1.40 1.41
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv13913

Modified Files:
bat_xfer.cpp
Log Message:
Fix previous commit (use of uninitialized variable f).


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b417647b95c4fa921624034c
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Check batch-uploaded filenames for illegal characters/sequences/names

The BadFilename text.dat is now a format string (prints the bad filename).
Use the nice progress() display status while searching for duplicate filenames.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0c5c140eceeb8012a8083f6a
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Call smb_freefilemem() instead of smb_msgmem() for files

Not that it really matters, but perhaps it'll matter in the future. And the code reads better.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7dc1bc798e5a06e2278711ea
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Fix segfault after batch-upload when no "uploads" dir specified

When there's no "uploads" directory configured by the sysop, cfg.upload_dir will be set to INVALID_DIR, which cannot be used as an index into cfg.dir[] to determine if the time used for uploading the files should be "given back" to the user.

In v3.18, we used the first file in the upload queue, if there was one, else fell back to the "uploads" dir (which had to have been defined if there were no files in the queue). So this illegal array indexing was a regression in v3.19.

Reported by Zolt n G bor on Facebook

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/51e80cb165b7f4a1e096a172
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Fix potential divide by zero

CID 330961

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7e5ab9ab05d3a20fc6446e83
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Just use our local C macro MAX()

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d785ec9fc194d967e7bcda6d
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Add a sort (alphabetical) option when listing batch queues

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7696a52f02540c1b5347ae8f
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Sort the batch queues in the .ini files as well

This insures that the 'R'emove file option will work correctly if when displayed sorted.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a0ce3cd799d2a79e4f0b5e0b
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Use the user's default download protocol for batch downloads

Oversight probably during the new filebase overhaul in v3.19. Reported by Nelgin.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5d1d586fd74709f9cd1a9fc3
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Better access enforcement to files in batch download queues

If a file gets added to a batch download queue that a user doesn't have download-access to (at the time of batch download), deal with that gracefully and consistently.

start_batch_download():
- Now checks current user access to download the file in both single-file and batch modes
- Now performs credit-check in single-file mode (wasn't doing so previously)
- totalsize of multi-file batch download queue is now calculated again (apparently removed/broken in the new filebase conversion of v3.19), so download ETA should be calculated more accurately (?) again
- Use gettimetodl() to calculate each file's download time for multi-file downloads
- Using new putnode_download() method to write node downloading "action" and ETA-in-aux fields
- The node status wasn't being updated at all before start of download in single-file mode - fixed

create_batchdn_lst() :
- Checks each file still downloadable by the user and if not, removes from the queue (and the generated list file).
- Performs credit check and removes files that exceed available user credit
- returns true only when 1 or more files is added to the batch download list file

addtobatdl()
- Removed redundant 'D' restriction check - this is handled by can_user_download() check already.
- Use the 'reason' out parameter from can_user_download() to determine which error string to display (not always CantDownloadFromDir).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9a79d265b21f513e06c98907
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Fix missing 'autohang' argument in call to protocol()

Caught by a GCC warning.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e487e3cdb5ea842006d5dd6d
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Fix warning about impossible condition.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net