• src/sbbs3/chk_ar.cpp

    From rswindell@VERT to CVS commit on Friday, May 01, 2015 19:36:13
    src/sbbs3 chk_ar.cpp 1.23 1.24
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv29923

    Modified Files:
    chk_ar.cpp
    Log Message:
    Fixed 12-year old bug (introduced in rev 1.10):
    getusrsub() returned the completely wrong sub-board number. It assumed that getusrgrp() returned a 0-based index when in fact it returns a 1-based group number. This bug was only visible when using certain @-codes (e.g. "SN",
    "SL", "SR", and "SMB_SUB_NUM") when a sub-board was open via Synchronet internal function (i.e. not via JS MsgBase class). If the current group was the last group visible to the user, this would cause a crash.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Thursday, October 12, 2017 01:47:29
    src/sbbs3 chk_ar.cpp 1.25 1.26
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv4533

    Modified Files:
    chk_ar.cpp
    Log Message:
    Fixed observed NULL-dereference in dir_op().


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Friday, August 24, 2018 13:48:16
    src/sbbs3 chk_ar.cpp 1.27 1.28
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv16992

    Modified Files:
    chk_ar.cpp
    Log Message:
    The "DOS" ARS keyword has just been a "false" trigger since v3 (1999) but
    I have a new use for it in the v3 Terminal Server, it now follows the
    "NO_DOS" option in the [bbs] section of the sbbs.ini file. So if you have multiple Win32 instances of sbbs (like I do), but only some of them
    support DOS programs, you can now use this ARS keyword to enable/disable
    access to a program based on the existance of DOS support. For example,
    I have some 16-bit DOS message editors where I had the ARS set to
    "WIN32", but on my 64-bit Windows instance of sbbs (vert.synchro.net),
    16-bit DOS programs aren't supported while on my 32-bit Windows instance (bbs.synchro.net) they are. So I needed a good run-time check for whether
    DOS programs were supported or not and this old ARS keyword seemed the
    right fit. For Linux builds, this keyword will only evaluate to true if
    built with the USE_DOSEMU option.
    This is only true of the Terminal Server - use of "DOS" ARS keyword in
    other servers and services will still just evaluate to "false".



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Saturday, July 06, 2019 18:56:45
    src/sbbs3 chk_ar.cpp 1.29 1.30
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv3594

    Modified Files:
    chk_ar.cpp
    Log Message:
    Use term_supports() for terminal capability ARS keyword checking as this does the "right thing" for auto-terminal detection mode.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Friday, September 25, 2020 18:40:12
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/93f34cf6d15bf5ebbebd678d
    Modified Files:
    src/sbbs3/chk_ar.cpp
    Log Message:
    SYSOP ARS keyword now applies to target user, not necessarily the user online

    Altere reported that listing users with access to a sub-board with an Access Requirement String (ARS) set to "SYSOP" would list all users as having access. The problem was the use of the "SYSOP" macro which checks the *current* user online (not the subject of the ARS check). Fixed by not using the SYSOP macro.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net