• src/sbbs3/logfile.cpp

    From rswindell@VERT to CVS commit on Thursday, December 11, 2014 03:05:22
    src/sbbs3 logfile.cpp 1.54 1.55
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv27975

    Modified Files:
    logfile.cpp
    Log Message:
    If user is online, log the current user alias along with the error details in the data/error.log.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Friday, August 21, 2015 22:49:27
    src/sbbs3 logfile.cpp 1.56 1.57
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv27632

    Modified Files:
    logfile.cpp
    Log Message:
    Fix warning on fprintf(fp, str) by changing from fprintf() to fputs().




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Friday, April 13, 2018 16:59:06
    src/sbbs3 logfile.cpp 1.60 1.61
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv26751

    Modified Files:
    logfile.cpp
    Log Message:
    errormsg() logs the "useron", when applicable, even for timed events (e.g.
    REP unpacking).


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thursday, October 25, 2018 19:15:09
    src/sbbs3 logfile.cpp 1.62 1.63
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv11622

    Modified Files:
    logfile.cpp
    Log Message:
    Now that sbbs_t::lputs() adds the <useron alias>, adding it here (useron=x)
    to the log message becomes redundant.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Friday, January 04, 2019 14:15:13
    src/sbbs3 logfile.cpp 1.64 1.65
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv19104

    Modified Files:
    logfile.cpp
    Log Message:
    Partially revert the change in rev 1.63: eprintf() does not log the
    <useron alias>, so we need to include it in the log message here if we
    want the current user's alias included in event related log messages
    (e.g. unpacking QWK-REP packages).



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sunday, June 23, 2019 13:12:04
    src/sbbs3 logfile.cpp 1.65 1.66
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25331

    Modified Files:
    logfile.cpp
    Log Message:
    Use ctime_r() for the error.log timestamp string rather thean timestr() -
    this insures:
    1. the timestamp always includes the seconds
    2. the tiemstamp is always in 24-hour format (no am/pm indication)

    For systems that are configured (in SCFG) for "Military" (24 hour) time format, the error.log timestamps should appear the same as before.



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Saturday, August 08, 2020 12:32:30
    src/sbbs3 logfile.cpp 1.68 1.69
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv30030

    Modified Files:
    logfile.cpp
    Log Message:
    *lower* log-levels are more severe.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sunday, December 20, 2020 17:11:56
    https://gitlab.synchro.net/main/sbbs/-/commit/48f73ca167262efb1a09078f
    Modified Files:
    src/sbbs3/logfile.cpp
    Log Message:
    Don't log errno info for ERR_CHK errormsg() calls

    The errno (global error number) information is not relevant for any sbbs "checking" type errors.
    Also, use safe_strerror() for thread-safe errno descriptions.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sunday, May 16, 2021 16:47:09
    https://gitlab.synchro.net/main/sbbs/-/commit/3d1e05e5015a0872a2a72fb7
    Modified Files:
    src/sbbs3/logfile.cpp
    Log Message:
    Log the current Git branch and hash along with every error

    This eliminates any ambiguity about what exact version was in use when each error is logged.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thursday, December 29, 2022 14:16:20
    https://gitlab.synchro.net/main/sbbs/-/commit/4908a3883646356c357f6814
    Modified Files:
    src/sbbs3/logfile.cpp
    Log Message:
    Resolve warning: ISO C++ forbids converting a string constant to `char*'

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Monday, January 30, 2023 16:00:04
    https://gitlab.synchro.net/main/sbbs/-/commit/d99905a420dd2f394c5dce69
    Modified Files:
    src/sbbs3/logfile.cpp
    Log Message:
    Lowercase the topics in hack and spam action messages

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sunday, February 25, 2024 18:06:16
    https://gitlab.synchro.net/main/sbbs/-/commit/62852439c523e1d09e6b10b1
    Modified Files:
    src/sbbs3/logfile.cpp
    Log Message:
    Don't log errno value and description as part of ERROR log msg, when 0

    If errno is 0, it's definitely no proividing anything of value here. Of
    course, sometimes errno might be non-zero and still be unrelated to the error message. <shrug>

    For Nelgin:
    !ERROR 0 (Success) in exec.cpp line 644 (js_execfile) compiling "something.js" access=0
    <nelgin> I don't quite get why a successful execution is logged as an error

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thursday, October 17, 2024 21:57:19
    https://gitlab.synchro.net/main/sbbs/-/commit/1fecea061764630c37d903bc
    Modified Files:
    src/sbbs3/logfile.cpp
    Log Message:
    Fix extra line feed (and blank line) when long (> 78 char) strings were logged

    to node.log via sbbs_t::log()

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wednesday, December 04, 2024 18:48:28
    https://gitlab.synchro.net/main/sbbs/-/commit/5f89c517d8d4a1b65f1de4bd
    Modified Files:
    src/sbbs3/logfile.cpp
    Log Message:
    De-duplicate repeated errors logged via sbbs_t::errormsg() by reducing severity

    ... from ERROR to WARNING, so the repeats won't be logged to error.log file
    and won't (normally) be sent as notifications (e.g. emails) to the sysop. The duplicates are identified as from the same source file and line number as the immediately previous logged error within the last 12 hours. String comparison doesn't really work for deduplication since if you look closely, the errors usually are *not* exact duplicates (i.e. there's a node number or a socket descriptor or something that uniquely identifies the user/client/session). Repeated errors don't increment the node's error counter either.

    This does not de-duplicate errors logged via other means (e.g. direct calls to log()/lputs(),lprintf() with a severity of LOG_ERR or higher), but will
    solve the majority of duplicate errors that can be logged from the terminal server.

    So this at least partially addresses issue #619.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net