exec newuser_signup.js NONE 1.1
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv13727

Added Files:
newuser_signup.js
Log Message:
Initial ***UNTESTED** interpretation of newuser.cpp into JavaScript.

Missing features:
logline()
sbbs_t->node_connection
cfg.sys_phonefmt
cfg.new_sif
create_sif_dat()
console.uselect() doesn't allow setting a default
bbs.good_password() doesn't accept a user argument
No obvious way to enumerate available shells

Aside from the bugs that are doubtless there, the create_newuser() function should be a drop-in replacement for bbs.newuser().




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

Re: exec/newuser_signup.js
By: deuce to CVS commit on Sun Sep 28 2014 04:25 pm

exec newuser_signup.js NONE 1.1
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv13727

Added Files:
newuser_signup.js

I will be testing the snot out of this! :)

---

[Psi-Jack -//- Decker]

þ Synchronet þ Decker's Heaven -//- bbs.deckersheaven.com

exec newuser_signup.js 1.1 1.2
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv29362

Modified Files:
newuser_signup.js
Log Message:
system.newuser wants a string; dupe_user instead of olduser; system.lastuser instead of system.lastuser()


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.2 1.3
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv29963

Modified Files:
newuser_signup.js
Log Message:
console.yesno, bbs.text


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.3 1.4
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv30561

Modified Files:
newuser_signup.js
Log Message:
I expect system.check_name(newuser.alias) would return false if newuser.alias belongs to somebody, ie. newuser. Ditto for real name if unique required.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.4 1.5
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv31115

Modified Files:
newuser_signup.js
Log Message:
:|


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.5 1.6
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv31277

Modified Files:
newuser_signup.js
Log Message:
:|


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.6 1.7
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv31320

Modified Files:
newuser_signup.js
Log Message:
set newuser.alias at what may be a more appropriate time.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.7 1.8
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv31587

Modified Files:
newuser_signup.js
Log Message:
newuser.birthdate; console.gettemplate; printf instead of console.printf.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.8 1.9
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv32054

Modified Files:
newuser_signup.js
Log Message:
hdr may be null; console.getstr instead of getstr; xtrn_area.editor keys are lowercase, apparently.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.9 1.10
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv32120

Modified Files:
newuser_signup.js
Log Message:
Random password generator likely just needs replacing, but for now use String.charCodeAt(0) instead of String.charCode() which isn't a thing.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.10 1.11
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv32402

Modified Files:
newuser_signup.js
Log Message:
Hang up on the user if they derp their new password too many times. (Should probably print a message telling them that they are derp.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.11 1.12
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv32519

Modified Files:
newuser_signup.js
Log Message:
bbs.node_val_user instead of cfg.node_valuser


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.12 1.13
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv303

Modified Files:
newuser_signup.js
Log Message:
console.print() instead of printf().
Remove incorrect SAFEPRINTF2()




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.13 1.14
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv2402

Modified Files:
newuser_signup.js
Log Message:
Various useron -> newuser conversions. Should fix a couple things.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.14 1.15
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv2426

Modified Files:
newuser_signup.js
Log Message:
Fix typo (?)




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.15 1.16
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv2447

Modified Files:
newuser_signup.js
Log Message:
online -> bbs.online




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.16 1.17
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv12277

Modified Files:
newuser_signup.js
Log Message:
Remove incorrect comment.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.17 1.18
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv12291

Modified Files:
newuser_signup.js
Log Message:
Another incorrect comment.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.18 1.19
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv13310

Modified Files:
newuser_signup.js
Log Message:
As with newuser.cpp, postpone creation of the new user entry until closer
to the end of the process.

Mark more things as impossible.

This is less likely to fail to work.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.19 1.20
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv13666

Modified Files:
newuser_signup.js
Log Message:
bbs.login() won't prompt for a password if the password is zero-length.
I feel so dirty.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.20 1.21
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv28133

Modified Files:
newuser_signup.js
Log Message:
Re-implement good_password() (ie: chkpass()) in JavaScript to allow using
an arbitrary object instead of the current user.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.21 1.22
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv28433

Modified Files:
newuser_signup.js
Log Message:
Add a function to parse @-codes in text entries... we may need a console
method to print a text.dat entry because of the magic.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.22 1.23
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv28488

Modified Files:
newuser_signup.js
Log Message:
Remove extra log entry.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.23 1.24
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv28618

Modified Files:
newuser_signup.js
Log Message:
user.pass -> user.security.password




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.24 1.25
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv28681

Modified Files:
newuser_signup.js
Log Message:
Fix typo.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.25 1.26
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv28768

Modified Files:
newuser_signup.js
Log Message:
Don't bitch about an unchanged new password.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.26 1.27
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv28931

Modified Files:
newuser_signup.js
Log Message:
Split out each password test into a separate if(), remove the old password similarity test.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.27 1.28
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv29089

Modified Files:
newuser_signup.js
Log Message:
Set first = alias when there's no space.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.28 1.29
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv29135

Modified Files:
newuser_signup.js
Log Message:
Split user.name, not user.alias for first/last name.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.29 1.30
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv29217

Modified Files:
newuser_signup.js
Log Message:
Initialize useron.zipcode and useron.phone.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.30 1.31
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv29280

Modified Files:
newuser_signup.js
Log Message:
useron.pass -> useron.security.password



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.31 1.32
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv9626

Modified Files:
newuser_signup.js
Log Message:
Fix the easy bits.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.32 1.33
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv10062

Modified Files:
newuser_signup.js
Log Message:
Go back to creating the user record early.
Add bbs.user_sync() and newuser.cached=false where appropriate.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.33 1.34
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv17580

Modified Files:
newuser_signup.js
Log Message:
Use the global user object instead of carrying around the created user object. This allows avoiding the use of bbs.user_sync() everywhere and makes certain internal magic work better.

Patch inspired by Psi-Jack's submitted patch set. Hopefully I extracted all the bug fixes.

Let the next round of testing begin!




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.34 1.35
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv5680

Modified Files:
newuser_signup.js
Log Message:
Save/restor js.auto_terminate and set to false during creation.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.35 1.36
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv5696

Modified Files:
newuser_signup.js
Log Message:
Actually set js.auto_terminate = false;




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.36 1.37
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv5777

Modified Files:
newuser_signup.js
Log Message:
When system.new_user() throws an exception, you can't newuser is undefined.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.37 1.38
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv5852

Modified Files:
newuser_signup.js
Log Message:
More Psi-Jack fixes:
user.stats is read-only... don't try changing it (this is taken care of
by syste.mnewuser()).
Don't use the newuser object after the user is logged in.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.38 1.39
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv13123

Modified Files:
newuser_signup.js
Log Message:
Copy useron to newuser before attempting to login.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.39 1.40
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv13281

Modified Files:
newuser_signup.js
Log Message:
Log and handle bbs.login() failure.
This is likely not overly useful however aside from indicating a problem.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.40 1.41
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv13388

Modified Files:
newuser_signup.js
Log Message:
Hack hack hack.
Set user.number to newuser.number and call user_sync(). login should do
this, so if this works, something is amiss.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.41 1.42
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv13472

Modified Files:
newuser_signup.js
Log Message:
Derp... set user.number to newuser.number, not newuser.password.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.42 1.43
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv618

Modified Files:
newuser_signup.js
Log Message:
Delay creating the user entry until the alias, name, and handle have all
been entered and checked.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.43 1.44
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv7305

Modified Files:
newuser_signup.js
Log Message:
So, login() sets useron, but doesn't make the global user variable point to
the internal useron user_t.
This means adding some bbs.user_sync() calls back in.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec newuser_signup.js 1.45 1.46
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv3712

Modified Files:
newuser_signup.js
Log Message:
Apply patch from Psi-Jack in 2014:

This patch fixes the user object process by ordering specific parts in a way that fixes the following problems:

Post-delayed realname and handle caused realname and handle not to be set to the user object. Moved copy_user_template_to_user to after bbs.login just before the bbs.user_sync() solved that.

Choosing not to use the randomly generated password would fail on every situation. Reordering user.security.password to be underneath user.number solved this problem.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/64ebcc5b433ba6fc858d55f2
Modified Files:
exec/newuser_signup.js
Log Message:
Add a notice clarify that this script is not actually used by anything

and suggestions how to achieve what the reader/sysop is wanting.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net