src/sbbs3 main.cpp 1.606 1.607 sbbs.h 1.405 1.406
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1363

Modified Files:
main.cpp sbbs.h
Log Message:
Resolve crash when sbbs->init() fails and the sbbs_t destructor tries to destroy the ssh_mutex (which was not initialized).


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/804226440230106bb3b9859d
Modified Files:
src/sbbs3/main.cpp sbbs.h
Log Message:
mv() simplified for the non-copy case

Constified function arguments. Source path is still case-insensitive, but destination is case-sensitive (hopefully that's not an issue).

When a "move" (!copy) is requested, a rename() is always attempted first and if successful, job done. Otherwise, we continue on with the file-copy (and then remove).

This should resolve CID 332219 (DEADCODE).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b802e8326f0c676997a7bde9
Modified Files:
src/sbbs3/main.cpp sbbs.h
Log Message:
Initialize sbbs_t member variables in class definition instead of ctor

Remove the (now) unnecessary explicit initializations (e.g. to zero, blank, etc.) from the sbbs_t constructor.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/98949dd4a2521bd8d475421e
Modified Files:
src/sbbs3/main.cpp sbbs.h
Log Message:
GCC 4.8.5 can't initialize a class char-array member with = "" syntax

This fixes issue #525

Thanks to Nelgin for providing the test platform.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/221507a8d36e31306b0e9a6d
Modified Files:
src/sbbs3/main.cpp sbbs.h
Log Message:
Reduce the Terminal Server thread outcom timeout from 80 seconds to 800 ms

Since the Terminal Server is a single thread, let's not block for long
periods of time trying to send bytes to a client (e.g. send the badip.msg
file contents to a client with a blocked IP address), effectively DoSing the terminal server.

This should address the problem reported via IRC:
<theviper4> ³Apr 9 15:38:11 viper-bbs synchronet: term Terminal Server timeout(outcom) 0000 0000
<theviper4> ³Apr 9 15:38:35 viper-bbs synchronet: term Terminal Server !ERROR 110 sending on socket 39
<theviper4> ³Apr 9 15:38:35 viper-bbs synchronet: term Terminal Server !ERROR 32 sending on socket 39
<theviper4> ³Apr 9 15:38:35 viper-bbs synchronet: term Terminal Server !ERROR 32 sending on socket 39
<theviper4> ³Apr 9 15:38:36 viper-bbs synchronet: term 0039 Telnet !CLIENT BLOCKED in ip.can: 117.95.153.33

Also, make the outcom timeout error message more helpful (e.g. include the
sock descriptor of the client) and don't use the old rioctl() function
here any more.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net