src/sbbs3 chat.cpp 1.64 1.65
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3638

Modified Files:
chat.cpp
Log Message:
Fix observed crash in guruexp(): str[c]=0 does bad stuff when is c < 0.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/sbbs3 chat.cpp 1.65 1.66
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv26365

Modified Files:
chat.cpp
Log Message:
Fix warning.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/sbbs3 chat.cpp 1.66 1.67
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv15034

Modified Files:
chat.cpp
Log Message:
Log the date/time stamp of each query/response to the data/guru.log.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/sbbs3 chat.cpp 1.68 1.69
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv4307

Modified Files:
chat.cpp
Log Message:
Fixed a couple of calls to errormsg() - bad/uninitialized arguments.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 chat.cpp 1.73 1.74
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv5489

Modified Files:
chat.cpp
Log Message:
Address several Coverity-reported issues, mainly using SAFECAT() to address buffer overrun concerns.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 chat.cpp 1.76 1.77
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv31949

Modified Files:
chat.cpp
Log Message:
Allow external chat pagers to have their "native" and "use shell" execution flags set manually in SCFG.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 chat.cpp 1.78 1.79
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv15460

Modified Files:
chat.cpp
Log Message:
Fixed bug where if you used the /W (whisper) command in multi-node chat
and then hit 'Q', it would kick you out of multi-node chat (because
the abort flag was set).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/ac94b066213538a0ef8d91aa
Modified Files:
src/sbbs3/chat.cpp
Log Message:
Don't send unsupported key-strokes (e.g. ESC) to the chat partner

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/0e76bac12f80dc5c680e751b
Modified Files:
src/sbbs3/chat.cpp
Log Message:
strcpy() -> SAFECOPY()

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/c9e4cb7916a170361c440222
Modified Files:
src/sbbs3/chat.cpp
Log Message:
Fix an off-by-one line bug in the "local side" of the split-screen-chat.

This bug would cause the split-screen separator to repeat when the local
side scrolled (if the terminal was 24 rows, bug didn't happen when local
screen was 25 rows).

This bug appears to have "always" been there. The split-screen separator is
80 columns, so that forced a line wrap on the subsequent CRLF and the local_y value was "off-by-one". Just use ansi_gotoxy() instead and put the cursor
where you think it is.

Also, support > 24 row terminals for longer chat history (bottom half only).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/06da1523e7671e8619b0bf07
Modified Files:
src/sbbs3/chat.cpp
Log Message:
Remove forced upper/lower input of node-message target

At the request of WitNik (BGGRSCYN)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/08f3f5c9783bf49ce308e6ec
Modified Files:
src/sbbs3/chat.cpp
Log Message:
Address Coverity-reported issue

Check return value from read().

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/39c82c50c2c700d83d964360
Modified Files:
src/sbbs3/chat.cpp
Log Message:
Add a debug line when wrapping split-screen chat lines.

Is this the point when the lost chars problem happens?

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/92cb63183d0178719e95b75a
Modified Files:
src/sbbs3/chat.cpp
Log Message:
Fix CID 33252: Argument cannot be negative

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9229bef09f652b69825a98d9
Modified Files:
src/sbbs3/chat.cpp
Log Message:
Add error and debug level log messages to private chat

When reading and writing characters to chat files, log each with a debug-level log message. If a read or a write fails, log with an error-level log message.

This will hopefully help root-cause and resolve issue #304.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1f04cc14152bc4312d490061
Modified Files:
src/sbbs3/chat.cpp
Log Message:
Don't log debug msgs when reading 0 (\x00) from chat.dab file, expected

This just resulted in a lot of unhelpful noise in the log output

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1cdc4d8d590b1fa1a3506bee
Modified Files:
src/sbbs3/chat.cpp
Log Message:
Fix-up the recently-added debug/error log messages

I didn't look closely enough at which write() call I was instrumenting.
This is now more useful, though I think we already found the root-cause
based on different log output ("Unexpected ansi_getxy response").

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b56bf8edcf92494e56d410aa
Modified Files:
src/sbbs3/chat.cpp
Log Message:
Sysop can chat with nodes that aren't logged-in (at logon prompt, new users)

Be sure to let them select a node even when no nodes are technically "in use". As requested by Nelgin in IRC (what, no gitlab issue?)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/44f626bbcd42e03864c73def
Modified Files:
src/sbbs3/chat.cpp
Log Message:
Add source node number to sysop notification that they're being paged to chat

Fix issue #551

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/62e2280e6e59c520eae9abb4
Modified Files:
src/sbbs3/chat.cpp
Log Message:
Fix buffer overflow in guru chat parsing engine

The trigger was this line in the recent change to guru.dat:
Unrealized potential. :-(

That open paren was parsed as the beginning of a new guru expression. A very long guru expression that overflowed the stack variable 'str' here.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5fd4f1ca4a66fa612d243c0b
Modified Files:
src/sbbs3/chat.cpp
Log Message:
A close-parenthesis in a guru.dat response string would throw-off the parser

After a negative-match of a Guru expression, we were searching for the next
'(' anywhere in the subsequent chars of the file rather than just the next
line that started with an open-parenthesis character.

This bug was the secondary cause of the buffer-overflow crash addresseed in commit 62e2280e which was triggered by my recent updates to the guru.dat.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/39934b3b272b55412a3e211c
Modified Files:
src/sbbs3/chat.cpp
Log Message:
Fix CID 33725: Use after close

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net