src/sbbs3 sbbscon.c 1.250 1.251
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28492

Modified Files:
sbbscon.c
Log Message:
* Eliminated the sbbs.ini [BBS] Options flag: USE_2ND_RLOGIN
- this option has been a default option flag for 10 years
- this option was introduced *before* the RLogin password capability
- Synchronet now always expects the login-ID (alias) to be the 2nd string received during RLogin connections (called 'server-user-name' in RFC 1282).


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/sbbs3 sbbscon.c 1.251 1.252
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv9369

Modified Files:
sbbscon.c
Log Message:
Create a "running" named mutex (on Win32 only) for use by Inno Setup install program to detect a currently running instance of sbbs.exe.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/sbbs3 sbbscon.c 1.252 1.253
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv7183

Modified Files:
sbbscon.c
Log Message:
Remove "support" for SBBS_MAGIC_FILENAMES




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/sbbs3 sbbscon.c 1.253 1.254
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv12149

Modified Files:
sbbscon.c
Log Message:
Fix typo in help output reported by PSI-Jack.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/sbbs3 sbbscon.c 1.255 1.256
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv31256

Modified Files:
sbbscon.c
Log Message:
Fix warnings.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/sbbs3 sbbscon.c 1.256 1.257
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv30926

Modified Files:
sbbscon.c
Log Message:
Enancement for ragnarok:
If "syslog" is passed as a command-line option, always send log output to syslog, even when not daemonized.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/sbbs3 sbbscon.c 1.257 1.258
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv29983

Modified Files:
sbbscon.c
Log Message:
Change the name of an unused argument - whee!


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/sbbs3 sbbscon.c 1.262 1.263
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbscon.c
Log Message:
1. Fixed "always syslog" mode Used to force log output to syslog even when
not daemonized: log output would be repeated (once with a timestamp in
the log string, once without). Now direct calls to lputs/lprintf from
sbbscon.c won't go to syslog (in this mode), but I think that's okay.
2. Change the prompt when terminating the servers: replace the ?=help and
colon implying you can enter commands with just "Termianting..." since
you can't actually type commands while a terminate is in progress.
3. Output the inactivity timeout values when waiting for servers to
terminate (e.g. because they'res till in use).
4. Report IP addresses in square-brackes in the client ('c' command) output
to differentiate from hostnames.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/sbbs3 sbbscon.c 1.264 1.265
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22885

Modified Files:
sbbscon.c
Log Message:
Resolve gcc warning: sbbscon.c:38:0: warning: "_GNU_SOURCE" redefined



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbscon.c 1.265 1.266
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv24591

Modified Files:
sbbscon.c
Log Message:
Fix WTF indentation and braces.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbscon.c 1.267 1.268
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv26607

Modified Files:
sbbscon.c
Log Message:
Stat the status thread much later.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbscon.c 1.268 1.269
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1921

Modified Files:
sbbscon.c
Log Message:
Fix reported service for stat_*() callbacks.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbscon.c 1.269 1.270
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18961

Modified Files:
sbbscon.c
Log Message:
Move all the remaining status_startup bits inside the #ifdef __unix__ block since it's not defined otherwise. Not sure if this ways intended to be
included in Windows builds or not.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbscon.c 1.272 1.273
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/jsdocs/src/sbbs3

Modified Files:
sbbscon.c
Log Message:
Build with main() rather than CIOLIB_main() if either JSDOCS_BUILD or
WITH_SDL are not defined. This should fix JSDCOS builds for those without libsdl1.2-dev installed - but really, you want SDL installed to get the
full docs, I think.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbscon.c 1.275 1.276
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv17757

Modified Files:
sbbscon.c
Log Message:
Leave the node file (node.dab) open.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbscon.c 1.277 1.278
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28985

Modified Files:
sbbscon.c
Log Message:
Clean-up some of this USE_LINUX_CAPS patch, but honestly, I think it's
time for it to go away. Using 'sudo setcap sbbs' during build seems like the better, more supported solution.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbscon.c 1.278 1.279
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv6632

Modified Files:
sbbscon.c
Log Message:
Only do the whole Linux-capabilities dance when run as root (user-id 0).
This eliminates the error messages that would be displayed/logged when attempting the SYS_capset SYSCALL, which fails when not root.

So the capabilities dance enabled with USE_LINUX_CAPS (which is automatically enabled when /usr/include/sys/capabilites.h exists, which is installed with
the libcap2-dev package) apparently is still useful if you need to start
sbbs as root: the main thread will remain as root even when the child
threads have their user-id's changed to the user specified in the [UNIX] section of sbbs.ini or on the command-line
- so reducing the enabled privilege set for this root/main thread to the minimum needed, is a good security measure. It does this reduction (call to linux_minprivs() after the call to change_user()) so I'm not exactly sure how that works, but according to Deuce, this is what's happening. :-/



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbscon.c 1.279 1.280
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv25670

Modified Files:
sbbscon.c
Log Message:
Add "version" command-line option to display version/revision details (ala the SBBSCTRL "About" dialog box) and then exit.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 sbbscon.c 1.280 1.281
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22134

Modified Files:
sbbscon.c
Log Message:
Print the target architecture of sbbs along with the target platform/OS
(e.g. Linux-armv6 for rPi).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/eb160a3f20c0af8d60e6ecd0
Modified Files:
src/sbbs3/sbbscon.c
Log Message:
Document case fall-through

Reported by Coverity

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c2ebe8edd6a02759bed4f8f8
Modified Files:
src/sbbs3/sbbscon.c
Log Message:
Only remove the pid file if it has our pid in it.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a76c6d0e35f628a1d73d1d0d
Modified Files:
src/sbbs3/sbbscon.c
Log Message:
Publish a <host>/status to represent on/offline/disconnected

Set "last will" to publish the "disconnected" status.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/731da4540cfd6a966802139a
Modified Files:
src/sbbs3/sbbscon.c
Log Message:
Fix the MQTT "last will" (must be set before connect)

Add some more "status" topic values while initializing and terminating.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e34c14d646c6949a51e3a411
Modified Files:
src/sbbs3/sbbscon.c
Log Message:
MQTT thread wasn't even attempted to be started on Windows

mqtt_thread_start() actually will fail on Windows currently because we're
using a non-thread-safe version of mosquitto.dll

This moves the mqtt thread start further up before some *nix-specific stuff,
so hopefully that's not an issue.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ce2056f4418b9acc8f304a6e
Modified Files:
src/sbbs3/sbbscon.c
Log Message:
Fix MQTT for daemonized sbbs

Need to start the MQTT init/thread-start stuff after daemonizing.

Thanks to Nelgin for letting me know this was recently broken.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2d99f2848fd9559e2f19e226
Modified Files:
src/sbbs3/sbbscon.c
Log Message:
Fix sbbs startup issue when user is specific in sbbs.ini [unix]

Bug introduced in the systemd integration (commit d02978ade98a8)
and reported by Dan_C via #synchronet at irc.synchro.net

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/29460b517156d86cf68eb887
Modified Files:
src/sbbs3/sbbscon.c
Log Message:
Log an error upon failure to create/open the pid file

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f2b85c742c40881eb0c395bb
Modified Files:
src/sbbs3/sbbscon.c
Log Message:
Setup signal blocking before MQTT (which spawns a thread)

This solves the problem of any signal (even HUP) ungracefully terminating
sbbs (on *nix) when MQTT was enabled. As reported by Nightfox on IRC.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c4d905847ba4bb2c90df81be
Modified Files:
src/sbbs3/sbbscon.c
Log Message:
Only report systemd service "READY=1" state if any server is actually ready

any server "running" is not enough because the server could still be initializing, re-initializing, or even shutting down.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7da26d404ed24ebb4dc50be9
Modified Files:
src/sbbs3/sbbscon.c
Log Message:
Set server_stopped back to FALSE if a server is restarted (via recycle)

A set_state() may be called with SERVER_STOPPED while recycling.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c831eb434f3fc9acd86e8163
Modified Files:
src/sbbs3/sbbscon.c
Log Message:
More consistent logging of errno value (and descriptions)

Should use safe_strerror() here instead... later.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a4bc8a827e1b0a944ff48693
Modified Files:
src/sbbs3/sbbscon.c
Log Message:
This is exactly the sort of race condition pthread_once() is for.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bed33851d21f05ae63ec6f62
Modified Files:
src/sbbs3/sbbscon.c
Log Message:
Free scfg before exiting to calm down valgrind() about memleaks from here

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7b5a7bdf0592a8b82ec48fbc
Modified Files:
src/sbbs3/sbbscon.c
Log Message:
Call sbbs_free_ini() during happy-path exit, to calm down valgrind

This was not a real leak, but still, good practice

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net