• src/xpdev/sockwrap.c

    From deuce@VERT to CVS commit on Friday, February 07, 2014 11:55:46
    src/xpdev sockwrap.c 1.55 1.56
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv28318

    Modified Files:
    sockwrap.c
    Log Message:
    Fix function name. The documented Windows function "WSAAddressToString"
    is, obviously, named WSAAddressToStringA() or WSAAddressToStringU().



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Friday, February 07, 2014 19:21:41
    src/xpdev sockwrap.c 1.56 1.57
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv1992

    Modified Files:
    sockwrap.c
    Log Message:
    Use getnameinfo() instead of WSAAddressToString 'cause it's more better.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Friday, March 07, 2014 15:55:07
    src/xpdev sockwrap.c 1.58 1.59
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv27743

    Modified Files:
    sockwrap.c
    Log Message:
    Make nonblocking_connect() also select() for exceptional conditions since
    Win32 make connect() failure an exceptional condition.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Wednesday, April 23, 2014 22:30:28
    src/xpdev sockwrap.c 1.59 1.60
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv30388

    Modified Files:
    sockwrap.c
    Log Message:
    Return a meaningful error value from nonblocking_connect() whenever possible. Specifically, if select(), getsockopt(), or connect() fails, return ERROR_VALUE instead of SOCKET_ERROR.

    Found by Coverity since we never checked the return value of getsockopt()




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Wednesday, April 23, 2014 23:22:06
    src/xpdev sockwrap.c 1.60 1.61
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv30888

    Modified Files:
    sockwrap.c
    Log Message:
    Coverity: Unlikely memory leak in unused recvfilesocket() function.




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From deuce@VERT to CVS commit on Thursday, August 20, 2015 00:23:12
    src/xpdev sockwrap.c 1.61 1.62
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv11844

    Modified Files:
    sockwrap.c
    Log Message:
    Fix multiple memory-corruption buts in inet_ptoaddr()
    (only impacts active FTP transfers via IPv6).




    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Wednesday, August 26, 2015 00:32:47
    src/xpdev sockwrap.c 1.63 1.64
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv28990

    Modified Files:
    sockwrap.c
    Log Message:
    A little more detail for inet_addrtop() failures, but still not working for failed login attempt client IP addresses on Windows.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net
  • From rswindell@VERT to CVS commit on Sunday, April 19, 2020 21:35:48
    src/xpdev sockwrap.c 1.67 1.68
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv19496

    Modified Files:
    sockwrap.c
    Log Message:
    Added EXCLUSIVEADDRUSE support (WinSock only).



    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Saturday, August 08, 2020 10:22:50
    src/xpdev sockwrap.c 1.69 1.70
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv8156

    Modified Files:
    sockwrap.c
    Log Message:
    Use Microsoft magic to "ignore regular line breaks in the message definition text." of socket error strings on Windows:
    strips the embedded line-feeds from the socket error description.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Saturday, August 08, 2020 11:04:02
    src/xpdev sockwrap.c 1.70 1.71
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv11757

    Modified Files:
    sockwrap.c
    Log Message:
    Trim trailing-whitespace off of Windows socket error description strings.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Saturday, August 08, 2020 19:13:57
    src/xpdev sockwrap.c 1.73 1.74
    Update of /cvsroot/sbbs/src/xpdev
    In directory cvs:/tmp/cvs-serv9008

    Modified Files:
    sockwrap.c
    Log Message:
    socket_strerror() needs to auto-correct for WinSock error ranges.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to Git commit to sbbs/master on Friday, November 20, 2020 17:10:50
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/54f165161d3c8a9cb68090c5
    Modified Files:
    src/xpdev/sockwrap.c
    Log Message:
    Fix bugs in last commit... continue abusing the CI infra.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuce@VERT to Git commit to sbbs/master on Friday, November 20, 2020 17:12:44
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/804b4bf2af968c901e74f7fc
    Modified Files:
    src/xpdev/sockwrap.c
    Log Message:
    And finally, take a pointer, return success properly.

    This one should build even on Win32.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Sunday, March 21, 2021 04:38:19
    https://gitlab.synchro.net/main/sbbs/-/commit/2890ff74180bd24979b1a98b
    Modified Files:
    src/xpdev/sockwrap.c
    Log Message:
    A poll() failure with EINTR does not mean a socket is closed.

    This won't impact Synchronet as it has a separate signal handling
    thread, but we still need to behave properly for processes that
    don't. I'm also saying that ENOMEM does not indicate a disconnection,
    though it may be better to pretend it was disconnected...

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Sunday, March 21, 2021 10:43:22
    https://gitlab.synchro.net/main/sbbs/-/commit/9765a2ea6673ef0fef41ece4
    Modified Files:
    src/xpdev/sockwrap.c
    Log Message:
    Fix poll()-based socket_check() implementation

    Was returning disconnected when it wasn't at times.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Sunday, March 21, 2021 14:31:12
    https://gitlab.synchro.net/main/sbbs/-/commit/c53a903d90ffc62b681e059b
    Modified Files:
    src/xpdev/sockwrap.c
    Log Message:
    We still need to peek a byte to tell that recv is done with poll()

    Not all implementations set POLLHUP when a TCP socket is half-closed.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Monday, March 22, 2021 21:45:51
    https://gitlab.synchro.net/main/sbbs/-/commit/e6e83a5d66d8e38f00000c4d
    Modified Files:
    src/xpdev/sockwrap.c
    Log Message:
    Properly set buffer size when calling getsockopt()

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, April 10, 2021 13:08:14
    https://gitlab.synchro.net/main/sbbs/-/commit/90ca5a36c511c97538784089
    Modified Files:
    src/xpdev/sockwrap.c
    Log Message:
    Finally document socket_check() behaviour.

    Tweak the poll() implementation to match.

    Should fix #248

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, April 10, 2021 13:13:56
    https://gitlab.synchro.net/main/sbbs/-/commit/3fa3ad981f51aa082c07abf8
    Modified Files:
    src/xpdev/sockwrap.c
    Log Message:
    Add more detail to socket_check() comment

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, May 21, 2021 20:04:42
    https://gitlab.synchro.net/main/sbbs/-/commit/baa72abe9c9ed0b56bfde91e
    Modified Files:
    src/xpdev/sockwrap.c
    Log Message:
    Make inet_ptoaddr() not crash and work with IPv4 address strings

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Saturday, April 30, 2022 18:56:34
    https://gitlab.synchro.net/main/sbbs/-/commit/6de0ebc0d5c8fc4a5fba8064
    Modified Files:
    src/xpdev/sockwrap.c
    Log Message:
    Fix xp_inet_pton: was just writing 0x02 (address family)to 'dst', always

    Tried using this function in a new project and didn't work. My guess: it wasn't tested. <looks at Deuce>

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, February 21, 2024 06:36:38
    https://gitlab.synchro.net/main/sbbs/-/commit/5bc000c5ba8137ff5be8d3b8
    Modified Files:
    src/xpdev/sockwrap.c
    Log Message:
    Fix warning on Win64 build

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net