src/xpdev xpbeep.c 1.84 1.85
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv9417

Modified Files:
xpbeep.c
Log Message:
Fix warning.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/xpdev xpbeep.c 1.86 1.87
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv12883

Modified Files:
xpbeep.c
Log Message:
Coverity discovered not checking malloc() return.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/xpdev xpbeep.c 1.87 1.88
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv30644

Modified Files:
xpbeep.c
Log Message:
Coverity bug: From the pthread standard:
"Attempting to destroy a locked mutex results in undefined behavior."




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/xpdev xpbeep.c 1.88 1.89
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv31042

Modified Files:
xpbeep.c
Log Message:
Coverity bug: Fix potential memory leaks when exiting xp_play_sample_thread(). Overhaul of the sample allocation by setting it to NULL when it's copied to something that will free it, and for Win32, wait for the currently playing sample (if any) to complete before returning, and free the handle then.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/xpdev xpbeep.c 1.89 1.90
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv31956

Modified Files:
xpbeep.c
Log Message:
Finish the memory leak fix for xp_play_sample_thread() to account for the
case where the handle_type becomes invalid somehow (exceptionall unlikely)




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/xpdev xpbeep.c 1.90 1.91
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv1837

Modified Files:
xpbeep.c
Log Message:
The SDL audio system continues to play silence after the sample is done.
This means waiting for sdl.GetAudioStatus()!=SDL_AUDIO_PLAYING is an
infinite loop. Pause the audio after the tone is completed to prevent this.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/xpdev xpbeep.c 1.91 1.92
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv4427

Modified Files:
xpbeep.c
Log Message:
Make the decision on having to close each time through the loop, not once
at the first pass!

This should fix delays between notes on any platform that has any delay when opening or closing an audio device.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/xpdev xpbeep.c 1.92 1.93
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv20834

Modified Files:
xpbeep.c
Log Message:
If malloc() fails, uninitialized value would be passed to xp_dlclose()



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/xpdev xpbeep.c 1.93 1.94
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv11659

Modified Files:
xpbeep.c
Log Message:
Fix loop boundaries when cleaning up tone tail.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

src/xpdev xpbeep.c 1.95 1.96
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv9039

Modified Files:
xpbeep.c
Log Message:
Fix warning.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/xpdev xpbeep.c 1.96 1.97
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv12411

Modified Files:
xpbeep.c
Log Message:
Fix memory leak found by scan-build.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/xpdev xpbeep.c 1.99 1.100
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv12008

Modified Files:
xpbeep.c
Log Message:
Part two of xpbeep overhaul... remove duplicated code, fix leaks, fix
races, etc.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/xpdev xpbeep.c 1.100 1.101
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv21901

Modified Files:
xpbeep.c
Log Message:
Fix some warnings.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/xpdev xpbeep.c 1.102 1.103
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv6227

Modified Files:
xpbeep.c
Log Message:
SDL needs a copy of the sample as well (ie: it keeps it around and free()s
it itself)




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/xpdev xpbeep.c 1.103 1.104
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv10313

Modified Files:
xpbeep.c
Log Message:
Ignore the result of snd_pcm_drain() rather than waiting for it to work.
Call snd_pcm_prepare() before every sample.

Should fix bug #2
https://sourceforge.net/p/syncterm/tickets/2/



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/xpdev xpbeep.c 1.107 1.108
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv19922

Modified Files:
xpbeep.c
Log Message:
Only access PU from one thread because it's shit.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/xpdev xpbeep.c 1.108 1.109
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv22647

Modified Files:
xpbeep.c
Log Message:
Remove debug printf()




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/xpdev xpbeep.c 1.109 1.110
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv25184

Modified Files:
xpbeep.c
Log Message:
More rhobust pulseaudio fail-through.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/xpdev xpbeep.c 1.110 1.111
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv26118

Modified Files:
xpbeep.c
Log Message:
I thought I removed this debug output already...




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/xpdev xpbeep.c 1.111 1.112
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv12690

Modified Files:
xpbeep.c
Log Message:
xptone_open() is also a valid first call... put the pthread_once() in there
as well.
Fixes https://sf.net/p/syncterm/tickets/14/
and https://sf.net/p/syncterm/tickets/16/




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/xpdev xpbeep.c 1.112 1.113
Update of /cvsroot/sbbs/src/xpdev
In directory cvs:/tmp/cvs-serv4877

Modified Files:
xpbeep.c
Log Message:
Fix last commit for #ifndef XPDEV_THREAD_SAFE



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/123f60d7afd45bf788bedf42
Modified Files:
src/xpdev/xpbeep.c
Log Message:
Fix ALSA output on Linux

It seems that the "real" ALSA will actually silently fail if you
try to clear errors when no errors have occured. The FreeBSD
emulation of ALSA does not have this insane requirement, so this
went unnoticed for the 1.1 release.

I suspect that this actually fixes SF bug 24, because ALSA is
preferred over pulseaudio.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/dc1d24b3b16cc0210c56cfd1
Modified Files:
src/xpdev/xpbeep.c
Log Message:
Re-enable PulseAudio, ensure the handle is set to NULL on close.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/fc9f3d6e3a62fa3e288cdaf4
Modified Files:
src/xpdev/xpbeep.c
Log Message:
Do what was likely intended by 8b6b7b7c

The previous attempt completely disabled pulse audio.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e07b57962248e5cc907ca032
Modified Files:
src/xpdev/xpbeep.c
Log Message:
When trying to open pulse, play a millisecond of silence

This allows the playback thread to open the device and errors to
be checked. Otherwise, the first sound won't play.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e07d1380e650ce7992444f1f
Modified Files:
src/xpdev/xpbeep.c
Log Message:
Fix bug in last commit (extra parameter)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0ef63571e50584c81e2e3da4
Modified Files:
src/xpdev/xpbeep.c
Log Message:
Remove debug crap.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/606762311f25c816bdb153ee
Modified Files:
src/xpdev/xpbeep.c
Log Message:
Fix the single-threaded build:

error: `handle_mutex' undeclared

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d5e788518f41cbfddf9b3273
Modified Files:
src/xpdev/xpbeep.c
Log Message:
Fix race condition when handle is opened by playing a sample.

Caused a SyncTERM hang if it played a FG beep.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/574712547b2d63bf5dcab0f9
Modified Files:
src/xpdev/xpbeep.c
Log Message:
Another Windows warning about constiness.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2e2ab2510aa35d61fda176c1
Modified Files:
src/xpdev/xpbeep.c
Log Message:
Fix some warnings.

We can't use const protection for the sample buffer because the Win32
API takes non-const buffers. For standard implicit conversions,
simply disable the warning where it occurs on purpose. It appears
that MSVC builds use the equivilent of -Wconversion (which isn't even
part of -Wall).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1c47d84c7c55b6f6cffc0e06
Modified Files:
src/xpdev/xpbeep.c
Log Message:
_MSC_VER is the macro name you're looking for there :-)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/abf1cd9ee46327a9d17cba0b
Modified Files:
src/xpdev/xpbeep.c
Log Message:
Actually remove the const the comment says I can't have.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/63cec349ee714376a2649e5f
Modified Files:
src/xpdev/xpbeep.c
Log Message:
Remove need_copy variable when it won't be used.

Fixes Coverity issue.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ea42fffa92392454971c1cfd
Modified Files:
src/xpdev/xpbeep.c
Log Message:
Keep pointers to dll_handle around to solence Coverity issues.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net