exec imapservice.js 1.40 1.41
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv29262

Modified Files:
imapservice.js
Log Message:
Fix encode_string() to properly handle quotes.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec imapservice.js 1.41 1.42
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv31996

Modified Files:
imapservice.js
Log Message:
Win32 doesn't do %C. Use %Y (which it does support) instead.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec imapservice.js 1.42 1.43
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv32283

Modified Files:
imapservice.js
Log Message:
RFC2060 added a modified UTF-7 encoding for mbox names which makes '&' a special
character. Escape/parse it correctly to prevent subs with & in them from freaking out IMAP clients.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec imapservice.js 1.43 1.44
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv32393

Modified Files:
imapservice.js
Log Message:
Add missing ) before DigitalMan notices... damn.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec imapservice.js 1.44 1.45
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv988

Modified Files:
imapservice.js
Log Message:
Add support for search rages specified both by offset and by UID... ie:

1 UID SEARCH 1:100 UID 500:600

This may fix the iOS problems with the IMAP service.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

Re: exec/imapservice.js
By: deuce to CVS commit on Thu Jan 09 2014 04:04 am

exec imapservice.js 1.44 1.45
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv988

Modified Files:
imapservice.js
Log Message:
Add support for search rages specified both by offset and by UID... ie:

1 UID SEARCH 1:100 UID 500:600

This may fix the iOS problems with the IMAP service.

It does! It does fix the iOS problems with the IMAP service!

digital man

Synchronet "Real Fact" #6:
The name "Synchronet" was suggested by Steve Deppe (Ille Homine Albe) in 1991. Norco, CA WX: 54.3øF, 83.0% humidity, 3 mph SSE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec imapservice.js 1.45 1.46
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv27725

Modified Files:
imapservice.js
Log Message:
Fix the user/%04.imap key generation to quit adding all those .seen
suffixes already.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec imapservice.js 1.46 1.47
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv25389

Modified Files:
imapservice.js
Log Message:
DigitalMan said closing cloent.socket is bad.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec imapservice.js 1.47 1.48
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv29655

Modified Files:
imapservice.js
Log Message:
Remove messages from the department of redundancy department which aren't
there anymore after this commit.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec imapservice.js 1.48 1.49
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv1709

Modified Files:
imapservice.js
Log Message:
Fix up error reported by Ragnorok (thanks!) regarding the STATUS command.

It appears the some clients don't obey this bit of the RFC:
The STATUS command MUST NOT be used as a "check for new
messages in the selected mailbox" operation




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec imapservice.js 1.49 1.50
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv25614

Modified Files:
imapservice.js
Log Message:
Only commit to recvline() for one second, not 1800... when shutting down Synchronet, this timeout has to expire before the service thread exits.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec imapservice.js 1.50 1.51
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv32662

Modified Files:
imapservice.js
Log Message:
Check js.terminated in the IDLE loop.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec imapservice.js 1.51 1.52
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv12017

Modified Files:
imapservice.js
Log Message:
Syncjslint warnings... move RFC822HEADER into 822header.js from imapservice.js




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ telnet://vert.synchro.net

exec imapservice.js 1.53 1.54
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv18204

Modified Files:
imapservice.js
Log Message:
Fix a few issues in IMAP handling....

1) Accept (and ignore) empty lines from remote
2) Explicitly call the garbage collector to prevent memory hoarding
3) If we fail to fetch a header, make up a dummy one




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.54 1.55
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv27951

Modified Files:
imapservice.js
Log Message:
Handle an uncommon error a bit better... maybe.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.55 1.56
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv32723

Modified Files:
imapservice.js
Log Message:
It seems many IMAP clients open multiple connections to the server, and
expect the Seen flags to be coherent across them... support this by leaving
the users IMAP status file open, and holding a lock on the first byte.

We now need to flush changes to the status file more often, and we need
to call file.flush() before unlocking.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.56 1.57
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv20031

Modified Files:
imapservice.js
Log Message:
Pass the base to get_base_code() so that commands such as STATUS that don't have a selected base can use it.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.57 1.58
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv22290

Modified Files:
imapservice.js
Log Message:
Pass the index to operate on to apply_seen.
Fixes issues with STATUS command.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.58 1.59
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv23019

Modified Files:
imapservice.js
Log Message:
Open the config file unbuffered to help with concurrency.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.59 1.60
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv26737

Modified Files:
imapservice.js
Log Message:
Ensure we can open the message base before including it in a LIST/LSUB response.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.60 1.61
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv27175

Modified Files:
imapservice.js
Log Message:
Add -d and -r options to control debug and debugRX respectively... no need
to spam the log unless you're working on the script itself.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.61 1.62
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv27363

Modified Files:
imapservice.js
Log Message:
Typo in last commit? Say it ain't so!



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.62 1.63
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv19672

Modified Files:
imapservice.js
Log Message:
Support "binary" storage of Seen flags. This greatly reduces the size of
the data/users/000x.imap files when many messages have been seen.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.63 1.64
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv25580

Modified Files:
imapservice.js
Log Message:
Only unlock/save the config if it's been opened.
Fixes errors on sessions that do not authenticate before disconnecting.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.64 1.65
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv1878

Modified Files:
imapservice.js
Log Message:
cfgile -> cfgfile




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.65 1.66
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv19960

Modified Files:
imapservice.js
Log Message:
Check if the socket is connected or not in the wait loop.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.66 1.67
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv8898

Modified Files:
imapservice.js
Log Message:
is_connected is not a method.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.67 1.68
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv5392

Modified Files:
imapservice.js
Log Message:
Stop using unused netattr bit definitions.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.68 1.69
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv26016

Modified Files:
imapservice.js
Log Message:
Enfoce the LOGINDISABLED capability.
Do not use LOGINDISABLED with TLS connections.
Add support for CRAM-MD5 so it's RFC-3501 compliant to log in without TLS.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.69 1.70
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv28070

Modified Files:
imapservice.js
Log Message:
Fix typo.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.70 1.71
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv16583

Modified Files:
imapservice.js
Log Message:
Return an error when STATUS is called with an invalid sub.
May help with the invalid STATUS roundcube is sending from Krueger.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.71 1.72
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv12689

Modified Files:
imapservice.js
Log Message:
All calls to MsgBase.get_msg_header() need the "expand fields" option
disabled since the header may later be written back to disk. Should fix
error reported by Ragnarok (DOCKSUD):
imapservice.js line 1763: Error: Message header has 'expanded fields'



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.72 1.73
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv13164

Modified Files:
imapservice.js
Log Message:
Fix apparent bug in set_seen_flag(): wasn't passing the message header to base.put_msg_header(). I just happened to notice this while making the last
fix committed. I'm guessing this particular code path hasn't been tested (?)



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.73 1.74
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv17283

Modified Files:
imapservice.js
Log Message:
Rub some case-desinsitizing lotion on some regexs.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.74 1.75
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv8513

Modified Files:
imapservice.js
Log Message:
MSG_VERIFIED isn't a thing. Replace with MSG_VALIDATED.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

exec imapservice.js 1.75 1.76
Update of /cvsroot/sbbs/exec
In directory cvs:/tmp/cvs-serv11198

Modified Files:
imapservice.js
Log Message:
Resolve error on line 2017: TypeError: args[0].search is not a function
when using iOS (iPad) mail client.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/7831a1c1de4379362bc931c4
Modified Files:
exec/imapservice.js
Log Message:
Fix what appears to be an extra close paren in the eval() statement here

<nelgin> Oct 12 16:05:41 bbs synchronet: srvc 0099 IMAPv4-TLS RECV: a UID SEARCH FROM "Michiel"
<nelgin> Oct 12 16:05:41 bbs synchronet: srvc 0099 IMAPv4-TLS !JavaScript /sbbs/exec/imapservice.js line 1867: SyntaxError: missing ; before statement
<nelgin> I got a different type of error

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/601a9fd5c9019e796a1c4035
Modified Files:
exec/imapservice.js
Log Message:
Fix line 1172: ReferenceError: SCAN_CFG_NEW is not defined

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1fc2657fb74666d597ca753d
Modified Files:
exec/imapservice.js
Log Message:
Fix exception when line is null

imapservice.js line 736: TypeError: line is null

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5cb71b903d507865bffd0217
Modified Files:
exec/imapservice.js
Log Message:
Resolve line 712: Error: can't convert parseInt(line) to an integer

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0bd86726916aa0cf4f3ffc13
Modified Files:
exec/imapservice.js
Log Message:
Don't overwrite the base global with the index base when reading config

This falls squarely into the "How did that ever work?" category.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c967d666b2173c2d04e46a24
Modified Files:
exec/imapservice.js
Log Message:
Rename variable for consistency.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/93b91ee77ae194970b429c85
Modified Files:
exec/imapservice.js
Log Message:
Fix two isses with IMAP service...

1) user.number immediately after login() remains zero, but changes
"sometime" after. Avoid using user.number right after login()
call to generate filename. All data/user/0000.imap files can
be deleted after this change.
2) Saving Seen data would modify the object storing it when binary
seen values were used. Use JSON.parse(JSON.stringify() to make
a copy before saving and restore it afterward. Should fix issue
reported by nickshanks1 over IRC.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7b3303e7890a73cd173ae4a8
Modified Files:
exec/imapservice.js
Log Message:
Check for invalid line thing...

Implicated in possible infinite loop/OOM problems.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9e22b06fc5dc99f582bb3b30
Modified Files:
exec/imapservice.js
Log Message:
Improve error message

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/45f6979765f51dfd725a467c
Modified Files:
exec/imapservice.js
Log Message:
Ensure line isn't valid is it's not read in parse_string()

Thus appears to have been the root cause of the infinite loop/memory
issue. Basically, line was never replaced if it didn't match
^{[0-9]+}$ and didn't result in a number when passed to parseInt()
This resulted in an infinite loop that kept pushing zero-length
strings into an array.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b376fc4921c58c0e3f9f5a2c
Modified Files:
exec/imapservice.js
Log Message:
Guard against Seen being undefined when saving config.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/dbed4f1a7cdd31e71f838d40
Modified Files:
exec/imapservice.js
Log Message:
Fix last commit... there are bits that aren't Seen that are saved

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7993ca0c16241ece57a2769e
Modified Files:
exec/imapservice.js
Log Message:
Some more fixes...

Fix bseen calculation and saving
Only save seen data after all repsonses have been sent
Stop processing when the socket has been closed

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0ed2c5120ac61523dbffd713
Modified Files:
exec/imapservice.js
Log Message:
Fix TypeError: args[1].toUpperCase is not a function

Issue #389 reported by Keyop:
srvc 0324 IMAPS <Keyop> !JavaScript /sbbs/exec/imapservice.js line 653: TypeError: args[1].toUpperCase is not a function

I'm not sure how you reproduce this error or what type args[1] is
(apparently, not a string), but this fix it regardless. Please let me
know.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a7468eaa3752118744bc4a0e
Modified Files:
exec/imapservice.js
Log Message:
Throw more interesting errors when a continuation line read fails

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/698583017282f94fb813213e
Modified Files:
exec/imapservice.js
Log Message:
Handle invalid credentials in imapservice

Fixes #401

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bbe3042acf2029e2798012d1
Modified Files:
exec/imapservice.js
Log Message:
Wrap the entire search logic in a try/catch statement

This should effectively turn script-terminating errors into just warnings and thus at least working-around issue #397: the exceptions will be logged as warnings intead of errors, but still logged.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c6515aa6b972bdcb6987e102
Modified Files:
exec/imapservice.js
Log Message:
Wrap the body of parse_command() in a try/catch to turn errors into warnings

As requested by Keyop in #synchrob0yyz

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0335c9796ce7bea2551f75c4
Modified Files:
exec/imapservice.js
Log Message:
Fix error when client supplies invalid Base64 string during auth

IIRC, the error was undefined has no properties or split() is not a function, something like that.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net