src/sbbs3 sbbsecho.c 1.221 1.222
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv25548

Modified Files:
sbbsecho.c
Log Message:
Fix bug reported by Wilfred van Velzen 2:280/464 introduced in rev 218: system's address was being added to SEEN-BY list twice when destination zone was different than the system's zone.
Another experimental change for Joe (1:249/303) and Wilfred: when parsing SEEN-BYs from incoming packets, assume the zone of the nodes in the SEEN-BYs
is the same as the origin zone of the packet, rather than the destination zone of the packet.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.224 1.225
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv30226

Modified Files:
sbbsecho.c
Log Message:
Quick "fix" for "%compression none" areafix command.
May fix a crash, may eat your cat. If it breaks, you get to keep both
the pieces.




---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.225 1.226
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv31439

Modified Files:
sbbsecho.c
Log Message:
More fixin's for the crash reported by access_d.




---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.226 1.227
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22141

Modified Files:
sbbsecho.c
Log Message:
More fixin's for %compression none.



---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.227 1.228
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22625

Modified Files:
sbbsecho.c
Log Message:
Add a bit more %compresson none paranoia.




---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

deuce wrote to CVS commit <=-

Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22625

Modified Files:
sbbsecho.c
Log Message:
Add a bit more %compresson none paranoia.

I take it this will be part of tomorrow's dev file?

Enjoy

Bill

Telnet: bbs.tequilamockingbirdonline.net
IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
Radio: radio.tequilamockingbirdonline.net:8010/live


... Look TWICE.... Save a life. Motorcycles are EVERYWHERE!!
--- MultiMail/Win32 v0.49
� Synchronet � TequilaMockingbird Online - TELNET: bbs.tequilamockingbirdonline.net

src/sbbs3 sbbsecho.c 1.228 1.229
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv24055

Modified Files:
sbbsecho.c
Log Message:
More %compression NONE fixin'
DAMN YOU ALAN!



---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.229 1.230
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14930

Modified Files:
sbbsecho.c
Log Message:
Clean up alter_config() a *lot*. Should now support unlimited line lengths. Note that it still assumes that teach arctype uses one line only. It will only add
the specified node to one line, but every time it comes across a line with
the old type, it will replace it with a new line containing every node which uses
the old type. This is likely not what you want, so only use a single USEPACKER line per archiver type is you're modifying this by hand.

I'm looking at you access_d. Your welcome.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.230 1.231
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14990

Modified Files:
sbbsecho.c
Log Message:
No need to ensure ushorts are >= 0




---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

Re: src/sbbs3/sbbsecho.c
By: deuce to CVS commit on Tue Oct 29 2013 02:18 pm

src/sbbs3 sbbsecho.c 1.230 1.231
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14990

Modified Files:
sbbsecho.c
Log Message:
No need to ensure ushorts are >= 0

unless ushorts are still in the washer.

"Practise safe Lunch, Use a Condiment"


---
� Synchronet � Three Stooges Gentlemens Club - Las Vegas, Nv - tsgc.dyndns.org

src/sbbs3 sbbsecho.c 1.231 1.232
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv25028

Modified Files:
sbbsecho.c
Log Message:
Fix bug reported by Joe Delahaye:
Uplinks configured as "passive nodes" were still added to the seen-by lines
of messages posted locally or passing through the system.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.233 1.234
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv7791

Modified Files:
sbbsecho.c
Log Message:
Reimplement the zone-blind threshold logic: if *both* the local AKA zone and the compared (e.g. SEEN-BY, PATH) zone are equal to or less than the threshold, then the zone will be considered a local (not foreign) zone. (for access_d) Also, add logic to check for nodes with an illegal net value of 0 and exclude from PATH: lines. Reportedly, messages coming from Mike Powel's system (1:2320/105.1), running SBBSecho v2.12, have a path line with a node "0/0"
in it - reported by Wilfred van Velzen (2:280/464).


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.234 1.235
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20687

Modified Files:
sbbsecho.c
Log Message:
Beautification of netmail_arealist(): no functional change (yet).


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.235 1.236
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20979

Modified Files:
sbbsecho.c
Log Message:
Fix %UNLINKED AreaFix command response for configurations which use the ELIST_ONLY option: include unlinked echoes from "additional echolists" in the response (rather than just "None.").
Created and used area_is_linked() function for the commonly copy/pasted code for checking if a specific node address is already linked with a specific area.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.236 1.237
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv21422

Modified Files:
sbbsecho.c
Log Message:
Resolve GCC error: 'for' loop initial declarations are only allowed in C99 mode Better/more log output when receiving AreaFix requests for echo/area lists.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.237 1.238
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv21623

Modified Files:
sbbsecho.c
Log Message:
Enable the delfile() (remove file retry loop) function for Win32 builds to see it resolves Joe's errors with areas.bbs modifications via AreaFix on Windows.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.238 1.239
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv21845

Modified Files:
sbbsecho.c
Log Message:
Fix reversed logic for %QUERY and %UNLINKED areafix requests introduced in
rev 236 (this this one, access===D).


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.239 1.240
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22491

Modified Files:
sbbsecho.c
Log Message:
Fix compile failure in delfile() (for Windows only).
Fix %LIST AreaFix response for ELIST_ONLY mode.
Fix %UNLINKED AreaFix response for non-ELIST_ONLY mode (include echolists).
Fix alter_areas() crash introduced in rev. 236 (j was not valid here).




---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.240 1.241
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22855

Modified Files:
sbbsecho.c
Log Message:
Sort AreaFix area list request (e.g. %LIST, %QUERY, %UNLINKED) results (alphabetically) since pulling/merging from multiple lists (add'l echolists
and the areas.bbs) often creates a confusing mix of sorted and unsorted area names.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.241 1.242
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv4923

Modified Files:
sbbsecho.c
Log Message:
Remove trailing white-space from received area-fix commands.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.242 1.243
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv25024

Modified Files:
sbbsecho.c
Log Message:
Bug-fix: packetized messages following an AreaFix netmail message would be skipped/ignored: import_netmail() moves the file position to the end of the message but returns non-zero (-2) when encountering an AreaFix message
and the calling code assumes a non-zero return value indicates an error and
the file position is somewhere *before* the end of the message (the NUL char). Resolved by saving the current file position before calling import_netmail() and restoring it after, so it matters not what improt_netmail does with the file pointer or what the return value is (in this case).
Thanks for the report, Joe!


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.243 1.244
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv16673

Modified Files:
sbbsecho.c
Log Message:
Lots of string copy clean-up hoping to fix Joe's reported crashes in strupr().


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.244 1.245
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv16858

Modified Files:
sbbsecho.c
Log Message:
Get rid of tempname(), use tempnam() instead (supported everywhere we care).


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.245 1.246
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv7683

Modified Files:
sbbsecho.c
Log Message:
Fix error reported by access_d...
SAFECOPY() ain't safe for pointers... use strdup() since that's what we
want anyway.




---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.246 1.247
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv8000

Modified Files:
sbbsecho.c
Log Message:
Resolve warning C4047: '=' : 'char *' differs in levels of indirection from 'int'


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.247 1.248
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1127

Modified Files:
sbbsecho.c
Log Message:
Additional paranoia around additional echolist parsing in reponse to areafix requests - should handle more unexpected echolist lines (e.g. extra long, blank or whatever). Hopefully resolves crashes in strdup() Joe is seeing.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.249 1.250
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1036

Modified Files:
sbbsecho.c
Log Message:
Fix compile error introduced in previous commit: smb_faddrtoa(), not faddrtoa()


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.250 1.251
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3281

Modified Files:
sbbsecho.c
Log Message:
Since the beginning of time, a "PASSWORD" areafix command would remove
all AREAFIX lines except for the one that was updated.

This is apparently "bad". Stop doing this bad thing (We'll still delete AREAFIX lines without an address though).




---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.251 1.252
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3464

Modified Files:
sbbsecho.c
Log Message:
While I'm looking at it, something similar appears to be happening with USEPACKER...
Basically, if there are more than one USEPACKER lines of the same archive
type as the new one, the user will be added to the first instance of the USEPACKER, and every other USEPACKER line of the same type will be deleted.

We likely don't want to do that either.




---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.252 1.253
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3883

Modified Files:
sbbsecho.c
Log Message:
Fix bug reported by access_d: was routing mail (when using a FLO mailer) even when the destination node was configured for "Direct". Apparently others have been working around this issue with a "Route to" configuration directive to route a node's netmail to itself. This work-around should no longer be necessary, but anyone that was depending on the old behavior (routing mail
for nodes configured as "Direct") will need to adjust their configuration.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.253 1.254
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv7245

Modified Files:
sbbsecho.c
Log Message:
Fix bug which caused the tear-line detection/conversion and origin line detection/conversion when exporting message text not work if the message contained line-feed terminated lines.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.254 1.255
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14891

Modified Files:
sbbsecho.c
Log Message:
Fix bug where sbbsecho export pointer would be "fixed" to zero if the message base could not be opened for some reason.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.255 1.256
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22361

Modified Files:
sbbsecho.c
Log Message:
Log the netmail attribute value (from the message header) for debugging Access_D's reported problem with re-routed netmail.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.257 1.258
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv21870

Modified Files:
sbbsecho.c
Log Message:
Fix compile errors introduced with redefinition of post_t
for sbbs_t::loadposts().


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.258 1.259
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv9988

Modified Files:
sbbsecho.c
Log Message:
Attempt to address Psi-Jack's reported problem:
Don't pack netmail that has the "SENT" attribute flag set.
Set the "SENT" attribute flag in netmail (.msg) files so if they're not deleted they won't be repacked/sent again later.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

Re: src/sbbs3/sbbsecho.c
By: rswindell to CVS commit on Tue Jul 21 2015 06:01 pm

Modified Files:
sbbsecho.c
Log Message:
Attempt to address Psi-Jack's reported problem:
Don't pack netmail that has the "SENT" attribute flag set.
Set the "SENT" attribute flag in netmail (.msg) files so if they're not deleted they won't be repacked/sent again later.

Tested and failed. *.msg files packed still retain Unsent status, and are still being sent every run.

Tested outbound packing using:

sbbsecho -linfd
Confirmed in sbbsecho 2.27-Linux (rev 1.249)

)))[Psi-Jack -//- Decker]

---
� Synchronet � Decker's Heaven -//- bbs.deckersheaven.com

Re: src/sbbs3/sbbsecho.c
By: Psi-Jack to rswindell on Tue Jul 21 2015 11:15 pm

Re: src/sbbs3/sbbsecho.c
By: rswindell to CVS commit on Tue Jul 21 2015 06:01 pm

Modified Files:
sbbsecho.c
Log Message:
Attempt to address Psi-Jack's reported problem:
Don't pack netmail that has the "SENT" attribute flag set.
Set the "SENT" attribute flag in netmail (.msg) files so if they're
not deleted they won't be repacked/sent again later.

Tested and failed. *.msg files packed still retain Unsent status, and are still being sent every run.

Tested outbound packing using:

sbbsecho -linfd
Confirmed in sbbsecho 2.27-Linux (rev 1.249)

Hold that thought.. It is working, but doing other wierd things.

Sent flag did get set, second run of sbbsecho -linfd did not pack the netmail, however, I was sending to my point node in testing.

Test node received it, acted like it came from the right address, but TO the same address, not the point node address. Re-sent it back to the main node, Synchronet on the main node then took that message, which was empty, and squashed the 1.msg with that new blank netmail message, not using 2.msg, or proper next message number..

Packate type was 2+, trying 2.2 and 2 to see if any differences occur on this issue.

The fact it literally squashes the original netmail is a bit concerning. (by squash, I mean effectively deletes/erases it, because it becomes empty, and because it gets overwritten as empty, then sbbsecho deletes that...)

)))[Psi-Jack -//- Decker]

---
� Synchronet � Decker's Heaven -//- bbs.deckersheaven.com

Re: src/sbbs3/sbbsecho.c
By: Psi-Jack to rswindell on Tue Jul 21 2015 11:15 pm

Re: src/sbbs3/sbbsecho.c
By: rswindell to CVS commit on Tue Jul 21 2015 06:01 pm

Modified Files:
sbbsecho.c
Log Message:
Attempt to address Psi-Jack's reported problem:
Don't pack netmail that has the "SENT" attribute flag set.
Set the "SENT" attribute flag in netmail (.msg) files so if they're
not deleted they won't be repacked/sent again later.

Tested and failed. *.msg files packed still retain Unsent status, and are still being sent every run.

Tested outbound packing using:

sbbsecho -linfd
Confirmed in sbbsecho 2.27-Linux (rev 1.259)

Reverted back to 1.258 (correction made on earlier post, not 1.249 but 1.259)

Something totally messes up the mailing to a point node with 1.259. Once I updated, when I would send mail from 1:135/371 to 1:135/371.1, the point node system would receive it as it if were addressed to 1:135/371, send it back to 1:135/371, empty, 1:135/371 would see an empty netmail, kill it, send a package back to 1:135/371.1, empty, and the point node would kill it because it's empty there too. That would end the cycle of it all.

)))[Psi-Jack -//- Decker]

---
� Synchronet � Decker's Heaven -//- bbs.deckersheaven.com

src/sbbs3 sbbsecho.c 1.259 1.260
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3270

Modified Files:
sbbsecho.c
Log Message:
Fix bug in previous commit (seek to the end of the netmail msg header after modifying the 'attr' field).
Also, only set the "SENT" attribute flag if the told not to delete netmail. This will reduce the risk to those using SBBSecho without the -d option.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.260 1.261
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv5250

Modified Files:
sbbsecho.c
Log Message:
Fix: set the correct "SENT" flag value, as reported by Psi-Jack.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

rswindell wrote to CVS commit <=-

src/sbbs3 sbbsecho.c 1.259 1.260
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3270

Modified Files:
sbbsecho.c
Log Message:
Fix bug in previous commit (seek to the end of the netmail msg header after modifying the 'attr' field).
Also, only set the "SENT" attribute flag if the told not to delete netmail. This will reduce the risk to those using SBBSecho without the
-d option.

Rob...

Will this be in the daily dev tomorrow?


--

Bill

Telnet: tequilamockingbirdonline.net
Web: bbs.tequilamockingbirdonline.net
FTP: ftp.tequilamockingbirdonline.net:2121
IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
Radio: radio.tequilamockingbirdonline.net:8010/live


... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
--- MultiMail/Win32 v0.50
� Synchronet � TequilaMockingbird Online - Toms River, NJ

Re: Re: src/sbbs3/sbbsecho.c
By: Bill McGarrity to rswindell on Wed Jul 22 2015 08:15 pm

rswindell wrote to CVS commit <=-

src/sbbs3 sbbsecho.c 1.259 1.260
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3270

Modified Files:
sbbsecho.c
Log Message:
Fix bug in previous commit (seek to the end of the netmail msg header after modifying the 'attr' field).
Also, only set the "SENT" attribute flag if the told not to delete netmail. This will reduce the risk to those using SBBSecho without the -d option.

Rob...

Will this be in the daily dev tomorrow?

It should be. The only time the daily dev build isn't updated (every morning) is when the build fails for some reason.

digital man

Synchronet "Real Fact" #58:
Synchronet apparel and merchandise can be purchased at cafepress.com/synchronet Norco, CA WX: 79.2�F, 62.0% humidity, 15 mph SE wind, 0.00 inches rain/24hrs

---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

Digital Man wrote to Bill McGarrity <=-

Re: Re: src/sbbs3/sbbsecho.c
By: Bill McGarrity to rswindell on Wed Jul 22 2015 08:15 pm

rswindell wrote to CVS commit <=-

src/sbbs3 sbbsecho.c 1.259 1.260
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3270

Modified Files:
sbbsecho.c
Log Message:
Fix bug in previous commit (seek to the end of the netmail msg header after modifying the 'attr' field).
Also, only set the "SENT" attribute flag if the told not to delete netmail. This will reduce the risk to those using SBBSecho without the -d option.

Rob...

Will this be in the daily dev tomorrow?

It should be. The only time the daily dev build isn't updated (every morning) is when the build fails for some reason.

Thank you sir!!


--

Bill

Telnet: tequilamockingbirdonline.net
Web: bbs.tequilamockingbirdonline.net
FTP: ftp.tequilamockingbirdonline.net:2121
IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
Radio: radio.tequilamockingbirdonline.net:8010/live


... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
--- MultiMail/Win32 v0.50
� Synchronet � TequilaMockingbird Online - Toms River, NJ

src/sbbs3 sbbsecho.c 1.261 1.262
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv29984

Modified Files:
sbbsecho.c
Log Message:
Fix warnings.




---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.262 1.263
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv24011

Modified Files:
sbbsecho.c
Log Message:
Fix warning.




---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.263 1.264
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22861

Modified Files:
sbbsecho.c
Log Message:
Create BSO/FLO .REQ files for outbound file requests at the request (?) of Psi-Jack.
Move the common outbound directory creation logic into a function.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.264 1.265
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv23500

Modified Files:
sbbsecho.c
Log Message:
Append-to rather than over-write .req files, just incase one already exists. Needs a line-ending too, to support multple file requests in a single .req file.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.265 1.266
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv13625

Modified Files:
sbbsecho.c
Log Message:
Fixed typo in recent commit.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.266 1.267
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18170

Modified Files:
sbbsecho.c
Log Message:
Fix problem reported by PSI-Jack and Bill Chaney: when no msg areas are defined in the system's areas.bbs file, SBBSecho would terminate prematurely with an error: "No areas defined in <path/to>areas.bbs". This would prevent SBBSecho from importing inbound netmail and packing outbound netmail, for example.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.267 1.268
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv11437

Modified Files:
sbbsecho.c
Log Message:
Half-assed work-arounds for Accession/AxisD/Access_D/Nick:
1. If the PATH kludge line only contains 1 address, don't use it for circular path detection.
2. If the last address of the PATH kludge line is the system's address, don't add the system's address to the PATH.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.269 1.270
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv30718

Modified Files:
sbbsecho.c
Log Message:
Create the NetMail directory if it doesn't already exist, in pkt_to_msg(), apparently SCFG wasn't creating this directory and SBBS only created it if you sent FTN netmail from the terminal server.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.271 1.272
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv11921

Modified Files:
sbbsecho.c
Log Message:
Address a couple of concerns from Accession:
Don't add TZUTC kludge lines to exported netmail and echomail messages when there is already a TZUTC FidoNet control line in the message header (unexpected but apparently, GoldEd+ does this).
If there are other duplicate FTN control/kludge lines created by SBBSecho exporting messages added to SMBs by GoldEd+, we should address those too, even though I believe in most cases, you should configure the editor to *not* add these header fields in the first place.
Do not convert exisiting Origin Line's to effectively comments (replacing * with # in " * Origin") if the current sub-board has been configured to not add network tag/origin-lines.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.272 1.273
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22813

Modified Files:
sbbsecho.c
Log Message:
Fix crash in create_netmail(() introduced in last commit, when processing area-fix requests or generating any netmail not from the mail base.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

Re: src/sbbs3/sbbsecho.c
By: rswindell to CVS commit on Wed Dec 09 2015 09:15 pm

Still having issues. When a script tries to create an email/netmail or an NNTP Reader tries to upload a message the following error is generated:

Dec 10 08:31:53 bbs synchronet: srvc 0024 NNTP !JavaScript /sbbs/exec/nntpservice.js line 836: Error: Error -110 adding SENDERNETADDR field to message header
--- SBBSecho 2.30-Linux
* Origin: Electronic Warfare BBS: Telnet://bbs.ewbbs.net (0:0/0)
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

Re: src/sbbs3/sbbsecho.c
By: Fat Rastus to rswindell on Thu Dec 10 2015 08:44 am

Re: src/sbbs3/sbbsecho.c
By: rswindell to CVS commit on Wed Dec 09 2015 09:15 pm

Still having issues.

Maybe I misssed it, did you report a problem before?

When a script tries to create an email/netmail or an
NNTP Reader tries to upload a message the following error is generated:

Dec 10 08:31:53 bbs synchronet: srvc 0024 NNTP !JavaScript /sbbs/exec/nntpservice.js line 836: Error: Error -110 adding SENDERNETADDR field to message header

Thanks for the bug report. It should be fixed now.

digital man

Synchronet "Real Fact" #65:
Synchronet was conceived of and mostly developed in southern California.
Norco, CA WX: 65.0�F, 47.0% humidity, 3 mph E wind, 0.00 inches rain/24hrs

---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.272 1.273
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22813

Modified Files:
sbbsecho.c
Log Message:
Fix crash in create_netmail(() introduced in last commit, when processing area-fix requests or generating any netmail not from the mail base.

so that why I was having problems, the last few days, when someone netmail my sbbsecho, it had problems or didn't work the way it should


---

Rob Starr
Lord Time SysOp of
Time Warp of the Future BBS
Telnet://Time.Darktech.Org:24 or
Telnet://Time.Synchro.Net:24 (qwk or ftn & e-mail)
ICQ # 11868133 or # 70398519 Jabber : lordtime2000@gmail.com
Yahoo : lordtime2000 AIM : LordTime20000 MSN : Lord Time
Astra : lord_time X-Box : Lord Time 2000 oovoo : lordtime2000
---
� Synchronet � Time Warp of the Future BBS - Home of League 10 IBBS Games

src/sbbs3 sbbsecho.c 1.273 1.274
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27473

Modified Files:
sbbsecho.c
Log Message:
Additional debug-level log output anytime SBBSecho creates or appends a BSO/FLO file or creates a netmail message (*.msg) file. This will hopefully help to provide that evidence that either:
A. there is a bug in SBBSecho with regards to passing mail to downlinks, or:
B. Michiel van der Vlist is just a whimpering ass-hat


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

Hello rswindell,

On 30 Dec 15 10:44, rswindell wrote to CVS commit:

src/sbbs3 sbbsecho.c 1.273 1.274
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27473

Modified Files:
sbbsecho.c
Log Message:
Additional debug-level log output anytime SBBSecho creates or appends
a BSO/FLO file or creates a netmail message (*.msg) file. This will hopefully help to provide that evidence that either: A. there is a bug
in SBBSecho with regards to passing mail to downlinks, or: B. Michiel
van der Vlist is just a whimpering ass-hat

LMFAO. This is definitely getting copy/pasted. You just made my day much more enjoyable.

Regards,
Nick

--- GoldED+/LNX 1.1.5-b20151129
* Origin: thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin) (723:1/701)
� Synchronet � thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

src/sbbs3 sbbsecho.c 1.275 1.276
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv12549

Modified Files:
sbbsecho.c
Log Message:
Fix GCC build error introduced in last commit (and a couple warnings).


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.277 1.278
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv15175

Modified Files:
sbbsecho.c
Log Message:
More debug-level log message changes/additions.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 1.278 1.279
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22493

Modified Files:
sbbsecho.c
Log Message:
Attempt to addres Bill McGarrity's reported error:
2016-01-20 06:06:39 ERROR line 1836 renaming c:\fd\outbound\20060640.pk_ to c:\fd\outbound\20060640.pkt
I think this is because the file 200606040.pkt already existed when the
.pk_ temp file was created and thus the rename will fail (can't rename over
an existing file) and then the packet is sent to the wrong link.
When generating a packet name, keep incrementing until both the .pkt and
.pk_ variants do not already exist. This should fix this scenario.



---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 3.1 3.2
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv13162

Modified Files:
sbbsecho.c
Log Message:
Better error message for AREAS.BBS parsing problem (discovered by Lord Time): Display parsed FTN addresss instead of string from AREAS.BBS file. Hopefully this provides a better clue as to what is happening with his configuration.



---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 3.2 3.3
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28913

Modified Files:
sbbsecho.c
Log Message:
Detect invalid Area File (AREAS.BBS) lines, report as a warning, and don't
try to parse the link addresses.
Example invalid line (echo-tag cannot contain spaces):
VADA Virtual Advanced BBS Support 1:261/38


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 3.3 3.4
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1325

Modified Files:
sbbsecho.c
Log Message:
No more malloc.h please... apparently it's needed for alloca() on Win32,
but it doesn't look like that's used here...



---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 3.4 3.5
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1388

Modified Files:
sbbsecho.c
Log Message:
Comment out empry if statement.




---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 3.5 3.6
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv6216

Modified Files:
sbbsecho.c
Log Message:
Bug-fix: insure ctrl dir value (read from SBBSCTRL env var) ends in a path separator (/ or \) before checking for mutex file.
Don't require an exact match [node:x] section in sbbsecho.ini for every link
in the area file (areas.bbs).


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 3.9 3.10
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv24362

Modified Files:
sbbsecho.c
Log Message:
Fix log output for "filtering due to age" message.


---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

Hiya Rob...

rswindell wrote to CVS commit <=-

src/sbbs3 sbbsecho.c 3.9 3.10
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv24362

Modified Files:
sbbsecho.c
Log Message:
Fix log output for "filtering due to age" message.

OK... in seeing yours and deuce's info here, I downloaded the latest rev update from this morning. The new sbbsecho locks up totally. Here is the Windows info from the lockup:

Problem signature:
Problem Event Name: APPCRASH
Application Name: sbbsecho.exe
Application Version: 0.0.0.0
Application Timestamp: 5718d044
Fault Module Name: sbbsecho.exe
Fault Module Version: 0.0.0.0
Fault Module Timestamp: 5718d044
Exception Code: c0000005
Exception Offset: 0002dc4e
OS Version: 6.0.6002.2.2.0.274.10
Locale ID: 1033
Additional Information 1: 6b6b
Additional Information 2: 5d30f7473d03206ee7cab825049a8704
Additional Information 3: 8f54
Additional Information 4: 6c0aa36107156dd00f32b85c4d5fd0cb

Read our privacy statement:
http://go.microsoft.com/fwlink/?linkid=50163&clcid=0x0409

I am not sure what deuce was doing with the FTN_domains.ini part as I don't have that ini file in my CRTL folder. I am using 2+ PKT type. Changing that to 2.2 will create that .INI?

Either way I reverted back to the previous version of sbbsecho.

Thanks

--

Bill

Telnet: tequilamockingbirdonline.net
Web: bbs.tequilamockingbirdonline.net
FTP: ftp.tequilamockingbirdonline.net:2121
IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
Radio: radio.tequilamockingbirdonline.net:8010/live


... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
--- MultiMail/Win32 v0.50
� Synchronet � TequilaMockingbird Online - Toms River, NJ

Re: Re: src/sbbs3/sbbsecho.c
By: Bill McGarrity to rswindell on Thu Apr 21 2016 11:55 am

OK... in seeing yours and deuce's info here, I downloaded the latest rev update from this morning. The new sbbsecho locks up totally. Here is the Windows info from the lockup:

Problem signature:
Problem Event Name: APPCRASH

Thanks. Fix is imminent.

I am not sure what deuce was doing with the FTN_domains.ini part as I don't have that ini file in my CRTL folder. I am using 2+ PKT type. Changing that to 2.2 will create that .INI?

No, the 2.2 packets will include the proper domain *if* the FTN_domains.ini exists (and is used), otherwise "fidonet" is always used as the src & dest domain values for type 2.2 packets.

digital man

Synchronet "Real Fact" #56:
Synchronet introduced Telnet, FTP, SMTP and POP3 support w/v3.00a-Win32 in 2000.
Norco, CA WX: 81.2�F, 21.0% humidity, 6 mph SE wind, 0.00 inches rain/24hrs

---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

Digital Man wrote to Bill McGarrity <=-

Re: Re: src/sbbs3/sbbsecho.c
By: Bill McGarrity to rswindell on Thu Apr 21 2016 11:55 am

OK... in seeing yours and deuce's info here, I downloaded the latest rev update from this morning. The new sbbsecho locks up totally. Here is the Windows info from the lockup:

Problem signature:
Problem Event Name: APPCRASH

Thanks. Fix is imminent.

Great... glad I could help.

I am not sure what deuce was doing with the FTN_domains.ini part as I don't have that ini file in my CRTL folder. I am using 2+ PKT type. Changing that to 2.2 will create that .INI?

No, the 2.2 packets will include the proper domain *if* the FTN_domains.ini exists (and is used), otherwise "fidonet" is always
used as the src & dest domain values for type 2.2 packets.

OK... so in using the ftn_domain.ini, what is the proper syntax of the file?

z1 = Fidonet
z2 = Fidonet
z24 = Sportnet

etc??

Thanks in advance!!


--

Bill

Telnet: tequilamockingbirdonline.net
Web: bbs.tequilamockingbirdonline.net
FTP: ftp.tequilamockingbirdonline.net:2121
IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
Radio: radio.tequilamockingbirdonline.net:8010/live


... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
--- MultiMail/Win32 v0.50
� Synchronet � TequilaMockingbird Online - Toms River, NJ

Re: Re: src/sbbs3/sbbsecho.c
By: Bill McGarrity to Digital Man on Fri Apr 22 2016 07:24 am

OK... so in using the ftn_domain.ini, what is the proper syntax of the file?

A full config with two domains would currently be something like this:

[fidonet]
Zones=1,2,3,4,5,6,7
DNSSuffix=binkp.net
OutboundRoot=/sbbs/fido/fido

[othernet]
Zones=31337
DNSSuffix=other.net
OutboundRoot=/sbbs/fido/othernet

SBBSEcho will only use the section name, Zones line, and OutboundRoot keys.

In the future, there is likely to be a NodeList option as well (that SBBSEcho will also not use).

---
� Synchronet � The future of BBSing

Deuce wrote to Bill McGarrity <=-

Re: Re: src/sbbs3/sbbsecho.c
By: Bill McGarrity to Digital Man on Fri Apr 22 2016 07:24 am

OK... so in using the ftn_domain.ini, what is the proper syntax of the file?

A full config with two domains would currently be something like this:

[fidonet]
Zones=1,2,3,4,5,6,7
DNSSuffix=binkp.net
OutboundRoot=/sbbs/fido/fido

[othernet]
Zones=31337
DNSSuffix=other.net
OutboundRoot=/sbbs/fido/othernet

SBBSEcho will only use the section name, Zones line, and OutboundRoot keys.

In the future, there is likely to be a NodeList option as well (that SBBSEcho will also not use).

Gotcha.... thank you!!


--

Bill

Telnet: tequilamockingbirdonline.net
Web: bbs.tequilamockingbirdonline.net
FTP: ftp.tequilamockingbirdonline.net:2121
IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
Radio: radio.tequilamockingbirdonline.net:8010/live


... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
--- MultiMail/Win32 v0.50
� Synchronet � TequilaMockingbird Online - Toms River, NJ

src/sbbs3 sbbsecho.c 3.10 3.11
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv25611

Modified Files:
sbbsecho.c
Log Message:
Possible bug fix for Joe Delahaye: don't include duplicate area tags in
areafix responses to %LIST and %UNLINKED requests. If the same echo tag
was listed in multiple additional echolists, it was possible it would
appear multiple times in the areafix response list.



---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 3.11 3.12
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27550

Modified Files:
sbbsecho.c
Log Message:
Fix bug reported by Accession: Error "maximum open files reached"
(paraphrased) encountered when performing a echomail rescan for link(s):
When a packet reaches the configured "maximum packet size", finalize the
packet immediately (terminate the packet and close the file) rather than waiting until the very end of all SBBSecho operations.



---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

Re: src/sbbs3/sbbsecho.c
By: rswindell to CVS commit on Wed Apr 27 2016 14:15:12

Possible bug fix for Joe Delahaye: don't include duplicate area tags in areafix responses to %LIST and %UNLINKED requests. If the same echo tag was listed in multiple additional echolists, it was possible it would appear multiple times in the areafix response list.

As in my answer to Bill, changing the false to true fixed the problem. At least for me. I'll ask the downlink to check as well. In the meantime if this is part of the dailies I'll download it.
--- SBBSecho 3.00-Win32
* Origin: The Lions Den BBS, Trenton, On, CDN (1:249/303)
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

Re: src/sbbs3/sbbsecho.c
By: Joe Delahaye to rswindell on Wed Apr 27 2016 07:49 pm

Re: src/sbbs3/sbbsecho.c
By: rswindell to CVS commit on Wed Apr 27 2016 14:15:12

Possible bug fix for Joe Delahaye: don't include duplicate area tags in areafix responses to %LIST and %UNLINKED requests. If the same echo tag was listed in multiple additional echolists, it was possible it would appear multiple times in the areafix response list.

As in my answer to Bill, changing the false to true fixed the problem. At least for me. I'll ask the downlink to check as well. In the meantime if this is part of the dailies I'll download it.

If you have the same echo tag listed in multiple "additional echolists", then I could see the duplicate problem occurring. The code (unchanged from SBBSecho v2) already checks for duplicates between the echolists and the area file (areas.bbs).

digital man

Synchronet "Real Fact" #5:
Synchronet version 3 for Linux and FreeBSD development began in 2001.
Norco, CA WX: 66.0�F, 54.0% humidity, 9 mph E wind, 0.00 inches rain/24hrs

---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

Re: src/sbbs3/sbbsecho.c
By: Digital Man to Joe Delahaye on Wed Apr 27 2016 17:15:07

If you have the same echo tag listed in multiple "additional echolists", then I could see the duplicate problem occurring. The code (unchanged from SBBSecho v2) already checks for duplicates between the echolists and the area file (areas.bbs).

I have 2 echo lists, set up as you told me how. just the full fido echo name is listed in those. One is marked "Allowed", and the other is marked "Private". The flags used to be ALLO and SECR. They now are ALLOWED and SECRET, since it will now take many more characters. There are no dupes between these two lists. Areas.bbs is the only one that has all those names in it, but in areas.bbs format. Nothing has changed from the original setup in that respect. I requested my downlink to try another %list in areafix again. I just received a netmail. I will let you know if he succeed, but I see no reason he would not :)
--- SBBSecho 3.00-Win32
* Origin: The Lions Den BBS, Trenton, On, CDN (1:249/303)
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

Re: src/sbbs3/sbbsecho.c
By: Joe Delahaye to Digital Man on Wed Apr 27 2016 10:02 pm

Re: src/sbbs3/sbbsecho.c
By: Digital Man to Joe Delahaye on Wed Apr 27 2016 17:15:07

If you have the same echo tag listed in multiple "additional echolists", then I could see the duplicate problem occurring. The code (unchanged from SBBSecho v2) already checks for duplicates between the echolists and the area file (areas.bbs).

I have 2 echo lists, set up as you told me how. just the full fido echo name is listed in those. One is marked "Allowed", and the other is marked "Private". The flags used to be ALLO and SECR. They now are ALLOWED and SECRET, since it will now take many more characters. There are no dupes between these two lists. Areas.bbs is the only one that has all those names in it, but in areas.bbs format. Nothing has changed from the original setup in that respect. I requested my downlink to try another %list in areafix again. I just received a netmail. I will let you know if he succeed, but I see no reason he would not :)

I see that the logic (for v2 and v3) could contain dupes in the %list response for areas *not* connected and in both the area file (areas.bbs) and one or more echo lists. That is now fixed in v3 in CVS.

digital man

Synchronet/BBS Terminology Definition #32:
REP = QWK Reply
Norco, CA WX: 53.9�F, 69.0% humidity, 5 mph NNE wind, 0.00 inches rain/24hrs

---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

Re: src/sbbs3/sbbsecho.c
By: Digital Man to Joe Delahaye on Thu Apr 28 2016 00:24:51

I see that the logic (for v2 and v3) could contain dupes in the %list response for areas *not* connected and in both the area file (areas.bbs) and one or more echo lists. That is now fixed in v3 in CVS.

OK, I have downloaded the daily this morning (Eastern TIme), also got the latest js to change over the cfg file.

; Converted from /sbbs/ctrl\sbbsecho.cfg using sbbsecho_upgrade.js 1.11

I now see the all the archivers in echocfg.
--- SBBSecho 3.00-Win32
* Origin: The Lions Den BBS, Trenton, On, CDN (1:249/303)
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

Re: src/sbbs3/sbbsecho.c
By: Joe Delahaye to Digital Man on Thu Apr 28 2016 10:47 am

Re: src/sbbs3/sbbsecho.c
By: Digital Man to Joe Delahaye on Thu Apr 28 2016 00:24:51

I see that the logic (for v2 and v3) could contain dupes in the %list response for areas *not* connected and in both the area file (areas.bbs) and one or more echo lists. That is now fixed in v3 in CVS.

OK, I have downloaded the daily this morning (Eastern TIme), also got the latest js to change over the cfg file.

; Converted from /sbbs/ctrl\sbbsecho.cfg using sbbsecho_upgrade.js 1.11

I now see the all the archivers in echocfg.

Okay, thanks for the update.

Here is the history of that script: http://cvs.synchro.net/cgi-bin/viewcvs.cgi/exec/sbbsecho_upgrade.js?sortby=date &view=log

The oldest version that could be expected to work reasonably well with SBBSecho v3 was rev 1.9. And there were 2 bug fixes since then.

digital man

Synchronet/BBS Terminology Definition #30:
NUL = ASCII 0
Norco, CA WX: 67.2�F, 49.0% humidity, 7 mph ESE wind, 0.00 inches rain/24hrs

---
� Synchronet � Vertrauen � Home of Synchronet � telnet://vert.synchro.net

src/sbbs3 sbbsecho.c 3.36 3.37
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv818

Modified Files:
sbbsecho.c
Log Message:
Fix bug reported by Ray Quinn: node inbox paths (configured in sbbsecho.ini
or via echocfg) were not automatically slash-terminated. So if the user did not provide the trailing slash (or backslash on Windows), then the bundles and packets in an inbox could not be extracted/imported.
Also, fixed the truncation of area descriptions in the badareas.lst file.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert|cvs|bbs].synchro.net

src/sbbs3 sbbsecho.c 3.38 3.39
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22209

Modified Files:
sbbsecho.c
Log Message:
Resolve warning.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.39 3.40
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv8630

Modified Files:
sbbsecho.c
Log Message:
Track new stats per invocation of SBBSecho and report during the "signoff" ("Exiting") log message: packets sent, packets imported, bundles sent, and bundles unpacked.
Signoff log messages is always logged when in "Debug" log level.
Stat groups that are all zeroes are not logged in the "signoff" message.
The inbound, secure_inbound, and outbound directories are now "full pathed", meaning relative paths become absolute paths, forward-slashes become backslashes (on Windows), etc. This makes the command-line generated and using these paths less likely to be incompatible with archive unpackers.
The configured inbound/outbound paths are now logged in "Debug" log level mode. The optional "outgoing_sem" (used by binkit or tickit.js) is now touched under more circumstances (e.g. outbound bundle created without exporting any new mail).
No longer log the "writing" bad areas file debug output.

Area Manager changes:
- Bug-fix: %PASSWORD was setting the wrong key in the [node] section of the
sbbsecho.ini file (areafix_pwd -> AreafixPwd).
- Enhancement: %PKTPWD command may now be used to change the ndoe's packet
password. This change takes effect immediately, so additional packets in the
same session or bundle would need to use the new password. This can be
changes to take effect the next time SBBSecho is invoked instead, if desired. - Aliases for AreaMgr commands for commonly supported synonymous commands:
%PWD -> %PASSWORD
%COMPRESS -> %COMPRESSION
%PAUSE -> %PASSIVE
%RESUME -> %ACTIVE



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.41 3.42
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv6617

Modified Files:
sbbsecho.c
Log Message:
Addition of echostats collection, a WIP


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.42 3.43
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv6953

Modified Files:
sbbsecho.c
Log Message:
Fix bug in alter_areas() - the function for modifying the area file (areas.bbs) in response to AreaFix requests: this function attempted to support a trailing comment (beginning with a semicolon, but after any/all links) - but failed to so correctly. Since, forever. So it's unlikely sysops actually added trailing comments to their area file (or didn't provide AreaFix support to their downlinks), but this "feature" should actually work now. I considered just removing this support but decided to fix it instead, at least for now.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.45 3.46
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv17667

Modified Files:
sbbsecho.c
Log Message:
Fixed an MSVC2013 compilation errors and a couple of NULL pointer dereferences introduced in the previous commit.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.46 3.47
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv13519

Modified Files:
sbbsecho.c
Log Message:
Parse the old pre-standard TZUTCINFO kludge line in fidomsg_to_echostat_msg() Use the SBBSecho PID info as the TID field, by default, in export echostats Don't include the Total* stats that are zero, in echostats (0 is assumed) Uppercase the echotag when auto-adding a sub to the Area File.
Implemented long-awaited "bad echo" re-toss feature (use '-R' command-line option to enable).



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.47 3.48
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14499

Modified Files:
sbbsecho.c
Log Message:
Resolve several GCC warnings.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.48 3.49
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv15134

Modified Files:
sbbsecho.c
Log Message:
Resolve several GCC warnings.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.49 3.50
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1965

Modified Files:
sbbsecho.c
Log Message:
Delete messages moved from the badecho/unknown area, even if they weren't actually moved because they were dupes.
Don't attempt to auto-add subs that aren't marked as "FidoNet EchoMail" in SCFG


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

On 2017 Oct 29 23:18:56, rswindell wrote to CVS commit:

src/sbbs3 sbbsecho.c 3.49 3.50
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1965

Modified Files:
sbbsecho.c
Log Message:
Delete messages moved from the badecho/unknown area, even if they weren't actually moved because they were dupes.
Don't attempt to auto-add subs that aren't marked as "FidoNet EchoMail" in SCFG

i don't know that i'd specify "Fidonet" in that entry... just "Echomail" should
work... there are other FTNs out there and they should not be restricted from this new auto-add feature should they? ;) QWK mail is not echomail, that's for
sure :)

)\/(ark

Always Mount a Scratch Monkey
Do you manage your own servers? If you are not running an IDS/IPS yer doin' it wrong...
... Pardon me! Where did you get the idea the whistle pulls the train???
---
* Origin: (1:3634/12.73)
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Re: src/sbbs3/sbbsecho.c
By: mark lewis to digital man on Mon Oct 30 2017 06:53 am

On 2017 Oct 29 23:18:56, rswindell wrote to CVS commit:

src/sbbs3 sbbsecho.c 3.49 3.50
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1965

Modified Files:
sbbsecho.c
Log Message:
Delete messages moved from the badecho/unknown area, even if they weren't actually moved because they were dupes.
Don't attempt to auto-add subs that aren't marked as "FidoNet EchoMail" in SCFG

i don't know that i'd specify "Fidonet" in that entry... just "Echomail" should
work... there are other FTNs out there and they should not be restricted from this new auto-add feature should they? ;) QWK mail is not echomail, that's for
sure :)

It's a 25+ year old menu item under "Network Options" for sub-boards in SCFG.

digital man

This Is Spinal Tap quote #25:
Viv Savage: Have... a good... time... all the time. That's my philosophy. Norco, CA WX: 68.1�F, 60.0% humidity, 9 mph ENE wind, 0.00 inches rain/24hrs

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

On 2017 Oct 30 15:26:18, you wrote to me:

i don't know that i'd specify "Fidonet" in that entry... just
"Echomail" should work... there are other FTNs out there and they
should not be restricted from this new auto-add feature should they?
;) QWK mail is not echomail, that's for sure :)

It's a 25+ year old menu item under "Network Options" for sub-boards
in SCFG.

oh wow! hahahaha! ok, well... maybe it could be adjusted to "FTN Echomail"? that way folks might not restrict it to only fidonet? that was my first thought
when i read it ;) ;) ;)

)\/(ark

Always Mount a Scratch Monkey
Do you manage your own servers? If you are not running an IDS/IPS yer doin' it wrong...
... Our swords shall play the orators for us.
---
* Origin: (1:3634/12.73)
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Re: src/sbbs3/sbbsecho.c
By: mark lewis to Digital Man on Mon Oct 30 2017 09:33 pm

On 2017 Oct 30 15:26:18, you wrote to me:

i don't know that i'd specify "Fidonet" in that entry... just
"Echomail" should work... there are other FTNs out there and they
should not be restricted from this new auto-add feature should they?
;) QWK mail is not echomail, that's for sure :)

It's a 25+ year old menu item under "Network Options" for sub-boards
in SCFG.

oh wow! hahahaha! ok, well... maybe it could be adjusted to "FTN Echomail"? that way folks might not restrict it to only fidonet? that was my first thought
when i read it ;) ;) ;)

The online help and documentation can (and will) be sure to make it clear that's it not just for "FidoNet proper", but I hesitate to rename SCFG options that haven't changed in forever since many people have written docs and how-to's using the current naming.

digital man

Synchronet/BBS Terminology Definition #42:
SBBS = Synchronet Bulletin Board System
Norco, CA WX: 60.9�F, 82.0% humidity, 2 mph E wind, 0.00 inches rain/24hrs

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Re: src/sbbs3/sbbsecho.c
By: mark lewis to Digital Man on Mon Oct 30 2017 09:33 pm

It's a 25+ year old menu item under "Network Options" for sub-boards
in SCFG.

oh wow! hahahaha! ok, well... maybe it could be adjusted to "FTN Echomail"? that way folks might not restrict it to only fidonet? that was my first thought
when i read it ;) ;) ;)

i dont think anybody's ever had a problem.
---
� Synchronet � ::: BBSES.info - free BBS services :::

src/sbbs3 sbbsecho.c 3.51 3.52
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1162

Modified Files:
sbbsecho.c
Log Message:
Fix bug with export_echomail() introduced in rev 3.47 (Oct-29):
- If SBBSecho is run in a mode to both import and export (e.g. no command-line
options), the SMB pointer used when exporting would be crossed-up with the
last sub-board imported into. This was the cause of the mass dupe flood from
1:154/30 (mostly announcements from "New Files At War Ensemble BBS").

Added a bit more log output with regards to bad echo area configuration and re-tossing (this was not related to the bug/fix above).



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.52 3.53
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv8451

Modified Files:
sbbsecho.c
Log Message:
Fix "Bad-echo area" debug output.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.53 3.54
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv15378

Modified Files:
sbbsecho.c
Log Message:
Huge performance improvement to read_echostats():
- Don't search for the section (echo) for each key/value

Added a debug-level log entry about the number of echostats read/parsed.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Re: src/sbbs3/sbbsecho.c
By: rswindell to CVS commit on Mon Nov 06 2017 22:52:27

Hiya Rob...

src/sbbs3 sbbsecho.c 3.53 3.54 Update of /cvsroot/sbbs/src/sbbs3 In directory cvs:/tmp/cvs-serv15378

Modified Files: sbbsecho.c Log Message: Huge performance improvement
to read_echostats(): - Don't search for the section (echo) for each key/value

You ain't kidding. The previous versions since you've added echostats took about 40 seconds to run. Now it's 7 seconds for the entire mailin process.

You the best..

--

Bill

Telnet: tequilamockingbirdonline.net
Web: bbs.tequilamockingbirdonline.net
FTP: ftp.tequilamockingbirdonline.net:2121
IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: 6697
Radio: radio.tequilamockingbirdonline.net:8010/live

---
� Synchronet � TequilaMockingbird Online - Toms River, NJ

Re: src/sbbs3/sbbsecho.c
By: Bill McGarrity to rswindell on Tue Nov 07 2017 09:26 am

Re: src/sbbs3/sbbsecho.c
By: rswindell to CVS commit on Mon Nov 06 2017 22:52:27

Hiya Rob...

src/sbbs3 sbbsecho.c 3.53 3.54 Update of /cvsroot/sbbs/src/sbbs3 In directory cvs:/tmp/cvs-serv15378

Modified Files: sbbsecho.c Log Message: Huge performance improve

ement

to read_echostats(): - Don't search for the section (echo) for each key/value

You ain't kidding. The previous versions since you've added echostats took about 40 seconds to run. Now it's 7 seconds for the entire mailin process.

You the best..

Well the initial implementation was certainly not optimized. :-)

digital man

Synchronet/BBS Terminology Definition #52:
TCP = Transmission Control Protocol
Norco, CA WX: 70.8�F, 53.0% humidity, 0 mph WSW wind, 0.00 inches rain/24hrs

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Digital Man wrote to Bill McGarrity on 11-07-17 10:24 <=-

Re: src/sbbs3/sbbsecho.c
By: Bill McGarrity to rswindell on Tue Nov 07 2017 09:26 am

Re: src/sbbs3/sbbsecho.c
By: rswindell to CVS commit on Mon Nov 06 2017 22:52:27

Hiya Rob...

src/sbbs3 sbbsecho.c 3.53 3.54 Update of /cvsroot/sbbs/src/sbbs3 In directory cvs:/tmp/cvs-serv15378

Modified Files: sbbsecho.c Log Message: Huge performance

mprove

ement

to read_echostats(): - Don't search for the section (echo) for each key/value

You ain't kidding. The previous versions since you've added echostats took about 40 seconds to run. Now it's 7 seconds for the entire mailin process.

You the best..

Well the initial implementation was certainly not optimized. :-)

Hey, shit happens. I've just taken some heat from the Russians over dumping in FTSC_Public. "F" um... :)


--

Bill

Telnet: tequilamockingbirdonline.net
Web: bbs.tequilamockingbirdonline.net
FTP: ftp.tequilamockingbirdonline.net:2121
IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
Radio: radio.tequilamockingbirdonline.net:8010/live


... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
--- MultiMail/Win32 v0.50
� Synchronet � TequilaMockingbird Online - Toms River, NJ

Re: src/sbbs3/sbbsecho.c
By: Bill McGarrity to Digital Man on Tue Nov 07 2017 08:06 pm

You ain't kidding. The previous versions since you've added echostats to about 40 seconds to run. Now it's 7 seconds for the entire mailin proces

You the best..

Well the initial implementation was certainly not optimized. :-)

Hey, shit happens. I've just taken some heat from the Russians over dumping FTSC_Public. "F" um... :)

Not your fault completely Bill. Im sure Trump had 'something' to do with it.

p.s. ALmost back together here :-)

Mick


Central Ontario Remote BBS
Fidonet 1:249/307 fsxNET 21:1/156

---
� Synchronet � Central Ontario Remote - Campbellford, Cda

Hello Bill,

On Tue Nov 07 2017 20:06:00, Bill McGarrity wrote to Digital Man:

Hey, shit happens. I've just taken some heat from the Russians over dumping in FTSC_Public. "F" um... :)

I honestly wanted to tell that guy to go kill himself, but deleted a lot of text and went with a more subtle reply. ;)

Regards,
Nick

... "Не знаю. Я здесь только работаю."
--- GoldED+/LNX 1.1.5-b20170303
* Origin: thePharcyde_ distribution system (Wisconsin) (723:1/1)
� Synchronet � thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin)

Mickey wrote to Bill McGarrity on 11-07-17 21:28 <=-

Re: src/sbbs3/sbbsecho.c
By: Bill McGarrity to Digital Man on Tue Nov 07 2017 08:06 pm

You ain't kidding. The previous versions since you've added echostats to about 40 seconds to run. Now it's 7 seconds for the entire mailin proces

You the best..

Well the initial implementation was certainly not optimized. :-)

Hey, shit happens. I've just taken some heat from the Russians over dumping FTSC_Public. "F" um... :)

Not your fault completely Bill. Im sure Trump had 'something' to do
with it.

Nah... Trump fck's up enough things on his own... I'll give him a pass on this one.

p.s. ALmost back together here :-)

Great!!


--

Bill

Telnet: tequilamockingbirdonline.net
Web: bbs.tequilamockingbirdonline.net
FTP: ftp.tequilamockingbirdonline.net:2121
IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
Radio: radio.tequilamockingbirdonline.net:8010/live


... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
--- MultiMail/Win32 v0.50
� Synchronet � TequilaMockingbird Online - Toms River, NJ

Accession wrote to Bill McGarrity on 11-07-17 21:11 <=-

On Tue Nov 07 2017 20:06:00, Bill McGarrity wrote to Digital Man:

Hey, shit happens. I've just taken some heat from the Russians over dumping in FTSC_Public. "F" um... :)

I honestly wanted to tell that guy to go kill himself, but deleted a
lot of text and went with a more subtle reply. ;)

LOL... I noticed. Diplomacy is sometimes the better part of valour... :)


--

Bill

Telnet: tequilamockingbirdonline.net
Web: bbs.tequilamockingbirdonline.net
FTP: ftp.tequilamockingbirdonline.net:2121
IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
Radio: radio.tequilamockingbirdonline.net:8010/live


... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
--- MultiMail/Win32 v0.50
� Synchronet � TequilaMockingbird Online - Toms River, NJ

src/sbbs3 sbbsecho.c 3.54 3.55
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv31270

Modified Files:
sbbsecho.c
Log Message:
Fix for BSO/FLO mode: when packing netmail, if the netmail message has the "Crash" attribute set, don't route to the configured uplink.
We really should do something similar for the "DIR" FLAGS kludge line, but that's more work (and isn't easily set on a per-msg basis, like crash is), so I'll revisit that later.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.55 3.56
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv6659

Modified Files:
sbbsecho.c
Log Message:
Fix for BSO/FLO mode: when packing netmail, if the netmail message has the "Hold" attribute set, don't route to the configured uplink. Just like the last commit, but now we actually create the proper cut/hut/out filename based on the status as well.
Turns out, Crash and Hold NetMail was handled correctly in v2.x and was an un-reported regression (new bug) in v3.0.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.56 3.57
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv7959

Modified Files:
sbbsecho.c
Log Message:
Fix long-standing bug (since forever):
When packetizing netmail, the "origin" address in the created packet header
was copied from the netmail (*.msg) message file. This is fine for locally created netmail, but nof for forwarded netmail (!). This would end up creating outbound packets with a foreign source/origin address which may or may not
be deliverable.

Sort of related, if there are stray packets in the outbound directory with a foreign source/origin address - don't packetize them! Just log a msg and ignore these foreign outbound packets.

This explains at least part of the problem Nelgin reported where a routed netmail was delivered to him (on Vert) from a hop running SBBSecho v3.01 and
I saw this packet header oddity. Now, why the actual netmail message itself
had the wrong origin address has not been identified.

If your system routes netmail messages (e.g. your hub), you'll want his update!


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Re: src/sbbs3/sbbsecho.c
By: rswindell to CVS commit on Thu Nov 09 2017 12:07 am

If your system routes netmail messages (e.g. your hub), you'll want his update!

Let me restate that:

If your system routes netmail messages (e.g. you're a hub), you'll want this update!

It does amaze me how this bug was never reported, but I guess routed netmail just hasn't been widely utilized or scrutinized (when it didn't work). Thanks to Nelgin for trying all these things that theoretically should've been working for decades.

digital man

Synchronet "Real Fact" #19:
The first Synchronet BBS (Vertrauen) went live in July of 1991 (replacing WWIV).
Norco, CA WX: 57.6�F, 91.0% humidity, 0 mph S wind, 0.00 inches rain/24hrs

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.57 3.58
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Fix long-standing bug with routed (re-packed) netmail messages:
The orig address in the packed msg header is (and still is) the proper
local system address (this may be correct behavior, still checking), but
no INTL control line (FSC-0004) was added, so the packed message header
ends up defining the originating system address. So, now we include an
INTL control line in packed netmail messages which reflects the actual
origin address of the message. Thanks to Nigel Reed for helping to identify
and test this problem over the past week or so.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.59 3.60
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Squash a couple of new GCC warnings.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

rswindell wrote to CVS commit on 11-13-17 00:56 <=-

Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Squash a couple of new GCC warnings.

May want to check the cvs. The dev version hasn't updated since 11-11-17. the unix updates are ok... 3.03 r3.60 Just can't get the windoze updates.

Thanks..




--

Bill

Telnet: tequilamockingbirdonline.net
Web: bbs.tequilamockingbirdonline.net
FTP: ftp.tequilamockingbirdonline.net:2121
IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
Radio: radio.tequilamockingbirdonline.net:8010/live


... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
--- MultiMail/Win32 v0.50
� Synchronet � TequilaMockingbird Online - Toms River, NJ

rswindell wrote to CVS commit on 11-13-17 00:56 <=-

Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Squash a couple of new GCC warnings.

May want to check the cvs. The dev version hasn't updated since 11-11-17. the unix updates are ok... 3.03 r3.60 Just can't get the windoze updates.

thanks, was going to say something like that :)


---

Rob Starr
Lord Time SysOp of
Time Warp of the Future BBS
Telnet://Time.Darktech.Org:24 or
Telnet://Time.Synchro.Net:24 (qwk or ftn & e-mail)
ICQ # 11868133 or # 70398519 Jabber : lordtime2000@gmail.com
Yahoo : lordtime2000 AIM : LordTime20000 Astra : lord_time
X-Box : Lord Time 2000 oovoo : lordtime2000 Skype : lordtime@tds.net
---
� Synchronet � Time Warp of the Future BBS - Home of League 10 IBBS Games

Re: src/sbbs3/sbbsecho.c
By: Bill McGarrity to rswindell on Mon Nov 13 2017 10:21 am

rswindell wrote to CVS commit on 11-13-17 00:56 <=-

Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Squash a couple of new GCC warnings.

May want to check the cvs. The dev version hasn't updated since 11-11-17. the unix updates are ok... 3.03 r3.60 Just can't get the windoze updates.

The nightly failed to build. I expect them to build successfully tomorrow AM.

digital man

Synchronet/BBS Terminology Definition #3:
ASCII = American Standard Code for Information Interchange
Norco, CA WX: 70.4�F, 51.0% humidity, 5 mph NNE wind, 0.00 inches rain/24hrs

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Lord Time wrote to Bill McGarrity on 11-13-17 10:42 <=-

rswindell wrote to CVS commit on 11-13-17 00:56 <=-

Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Squash a couple of new GCC warnings.

May want to check the cvs. The dev version hasn't updated since 11-11-17. the unix updates are ok... 3.03 r3.60 Just can't get the windoze updates.

thanks, was going to say something like that :)

:)


--

Bill

Telnet: tequilamockingbirdonline.net
Web: bbs.tequilamockingbirdonline.net
FTP: ftp.tequilamockingbirdonline.net:2121
IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
Radio: radio.tequilamockingbirdonline.net:8010/live


... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
--- MultiMail/Win32 v0.50
� Synchronet � TequilaMockingbird Online - Toms River, NJ

Digital Man wrote to Bill McGarrity on 11-13-17 16:13 <=-

Re: src/sbbs3/sbbsecho.c
By: Bill McGarrity to rswindell on Mon Nov 13 2017 10:21 am

rswindell wrote to CVS commit on 11-13-17 00:56 <=-

Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Squash a couple of new GCC warnings.

May want to check the cvs. The dev version hasn't updated since 11-11-17. the unix updates are ok... 3.03 r3.60 Just can't get the windoze updates.

The nightly failed to build. I expect them to build successfully
tomorrow AM.

And that they did... :)

Thank you...


--

Bill

Telnet: tequilamockingbirdonline.net
Web: bbs.tequilamockingbirdonline.net
FTP: ftp.tequilamockingbirdonline.net:2121
IRC: irc.tequilamockingbirdonline.net Ports: 6661-6670 SSL: +6697
Radio: radio.tequilamockingbirdonline.net:8010/live


... Look Twice... Save a Life!!! Motorcycles are Everywhere!!!
--- MultiMail/Win32 v0.50
� Synchronet � TequilaMockingbird Online - Toms River, NJ

src/sbbs3 sbbsecho.c 3.61 3.62
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv2671

Modified Files:
sbbsecho.c
Log Message:
When packetizing netmail with an attachment (only one attached file is supported), remove the file path information from the message subject
(it's not needed and could be seen as a security issue).


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.62 3.63
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv13760

Modified Files:
sbbsecho.c
Log Message:
When exporting netmail from the "mail" base, decode multipart MIME messages to get the "plain text" part only - this solves one problem with using an Internet email program to send NetMail. The next problem (ToDo) would be to extract MIME-encoded file attachment(s) and export them the FidoNet way.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.63 3.64
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv5466

Modified Files:
sbbsecho.c
Log Message:
New feature: when exporting FTN netmail from the "mail" base, if the message has a MIME-encoded file attachment, decode that attachment into a file and attach to the message FTN-style.
- This allows sending of FTN file attached netmail using your Internet email
client.
- Only a single attachment is supported (consistent with all attachment support
in SBBSecho).
create_netmail() enhancements:
Don't add the FLAGS control line if we're in FLO-mode - this line is not used by BSO/FLO mailers.
If there is a file attachment, but the message contains a subject, add a Subject: <original subject> line to the message body, since FTN requires the attached filename be placed in the subject.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.64 3.65
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18641

Modified Files:
sbbsecho.c
Log Message:
When packetizing netmail, don't add the INTL kludge line if it already
exists in the message body.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.65 3.66
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20824

Modified Files:
sbbsecho.c
Log Message:
Fix AreaFix "HELP" command response, broken in rev 3.59, reported by
Rastus:
file_to_netmail() assumed the file pointer was at the end of the file.
This was not the case with the areamgr.hlp file (just opened, not read or seeked).
Also, added some more error logging in case of file_to_netmail() failure.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.66 3.67
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv25691

Modified Files:
sbbsecho.c
Log Message:
Don't trim trailing white-space off of incoming MSGID and REPLY (reply-id) values. Apparently since this behavior is not not universal, it causes
some systems to treat the 2 MSG-IDs (one with and one without trailing whitespace) as unique, causing potential dupes. Reported by Mark Lewis.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.67 3.68
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv30298

Modified Files:
sbbsecho.c
Log Message:
Address many (but not all) Coverity reported "issues".


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.69 3.70
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv26643

Modified Files:
sbbsecho.c
Log Message:
Add BBS name and sysop name to PING netmail response message body.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.70 3.71
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv7753

Modified Files:
sbbsecho.c
Log Message:
Fix pong response bug introduced in previous commit.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.73 3.74
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv445

Modified Files:
sbbsecho.c
Log Message:
Bug-fix: The Auto-Add-Subs feature would not create the area file (areas.bbs) if it didn't already exist.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.74 3.75
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv20684

Modified Files:
sbbsecho.c
Log Message:
Some status string (e.g. "Loading user names...") were being sent to stderr instead of stdout.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.75 3.76
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Log an error if ftouch() fails to create the outbound sem file.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.76 3.77
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Use GCC-assisted printf-style format/arg checking to find and fix instances
of lprintf() misuse.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.77 3.78
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1786

Modified Files:
sbbsecho.c
Log Message:
Attempt to address GCC v7 warnings raised by Nelgin:
warning: format not a string literal and no format arguments [-Wformat-security]


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.78 3.79
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18475

Modified Files:
sbbsecho.c
Log Message:
Bug-fix: when exporting FTN netmail from SMB "mail" base, if the netmail included an "old-style" (not MIME-encoded) file attachment (where the file path is in the subject and the FILEATTACH aux-attribute flag is set), the corresponding netmail attribute flag would not be set in the stored msg (*.msg) file. Also simplified the create_netmail() function prototype/usage, removing the "file_attached" argument (use the hdr.auxattr instead).


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.79 3.80
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
write_flofile(): if the 'infile' path contains a drive letter prefix
(e.g. "C:"), skip it on *nix and if the path contains backslashes, convert
to forward-slashes (for all OSes). This resolves an issue of sending a
netmail file-attachment that was created on a Windows/MS-DOS type system
and then scanned/exported on a *nix system. The FTN "stored message"
convention is to have the full path of the attached file in the message subject.

Hopefully nobody wants to use outbound directory names beginning with "x:"
on *nix. :-)



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.80 3.81
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv19737

Modified Files:
sbbsecho.c
Log Message:
If a bundle file cannot be unpacked after 48-hours, if the file is 0-bytes in length, just delete it (don't rename to *.?_?).


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.81 3.82
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv32044

Modified Files:
sbbsecho.c
Log Message:
When exporting msgs that came from an FTN (e.g. during a rescan), don't convert existing tear/origin lines and don't add a new origin line.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.82 3.83
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv2537

Modified Files:
sbbsecho.c
Log Message:
Add a ^ARESCANNED w:x/y.z control line to exported messages during a rescan (apparently this is a pseudo-standard supported by fastecho and other "old-school" tossers) - per mark lewis' request.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.83 3.84
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv17065

Modified Files:
sbbsecho.c
Log Message:
Address RMH's issue:
When the local system has multiple AKAs for the same zone and we are picking a origin/source address suitable for the destination address, pick the AKA that matches both the zone and net of the destination address first (if there is such a local AKA). It's the same logic used in sbbs_t::netmail() to display
the originating address, so the AKA picking logic now matches what is shown
to the netmail author and what SBBSecho will actually use.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.84 3.85
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28074

Modified Files:
sbbsecho.c
Log Message:
Another improvement to create_netmail():
If the SMB header contains a source FTN address, use that as the origin address of the netmail and do not look-up a local AKA match for the destination address.
Also, fix what appears to have been a (currently harmless) bug in smsg_to_echostat_msg(): the msg.from_net.addr is not an ASCIIZ string when net.type == NET_FIDO. Currently, source FTN addresses aren't set in echomail message headers, where the echostats come from. Could just remove
these 2 lines.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.85 3.86
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18682

Modified Files:
sbbsecho.c
Log Message:
When importing packets, don't export previously-rescanned messages
(messages which contain the RESCANNED control line) to downlinks.

Also renamed pkt_to_pkt() to write_to_pkts().



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.87 3.88
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv12172

Modified Files:
sbbsecho.c
Log Message:
When adding a new sub-board to the area file, if the sub has a "newsgroup"
name specified, use that instead of the short name as the "Echo Tag"
(Area Tag) value.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.88 3.89
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv14995

Modified Files:
sbbsecho.c
Log Message:
Fix crash (segfault) reported in AreaFix handler for "-ALL", reported
by Ragnarok@DOCKSUD.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.89 3.90
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Log an error if one or more file attachments could not be deleted when attempted.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.90 3.91
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv13077

Modified Files:
sbbsecho.c
Log Message:
Don't delete netmail file attachments: just because the netmail was exported
to .msg file doesn't mean you should delete the file attachment! The .msg
file will still be pointing to that file and it needs to be there.
SBBSecho was silently failing to delete file attachments on my system, so
I didn't see this problem. Oops. Anyway, this explains Al's problem with netmail attachments.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.92 3.93
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18679

Modified Files:
sbbsecho.c
Log Message:
Updated failure/error log messages for SMB library function call failures: always include the text description of the last error and the line number.
The logging of the smb.file string is probably redundant since that path
will likely be included in the last_error string.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.94 3.95
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv25420

Modified Files:
sbbsecho.c
Log Message:
Fix bug with AreaFix "ECHOSTATS" command: if the echotag specified was not found, it would be added to the list of echoes tracked in echostats.ini. Ideally, a negative-response message would be sent to requester in this case, but we're not doing that currently.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.96 3.97
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv1311

Modified Files:
sbbsecho.c
Log Message:
Requested change by Mark Lewis:
can we get a slight change in the sbbsecho code or maybe in echocfg so that when a link is set to passive, areafix notices are NOT sent to them even if "send notices" is specifically set to yes?


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

On 2018 Oct 28 23:29:28, rswindell wrote to CVS commit:

Modified Files:
sbbsecho.c
Log Message:
Requested change by Mark Lewis:
can we get a slight change in the sbbsecho code or maybe in echocfg so

that

when a link is set to passive, areafix notices are NOT sent to them even

if

"send notices" is specifically set to yes?

thank you... i'm guessing that the option in the config file toggles when links
change their statuses? glad to see the change wasn't very involved :)

)\/(ark

Always Mount a Scratch Monkey
Do you manage your own servers? If you are not running an IDS/IPS yer doin' it wrong...
... I generally prefer normal late-19th century cuisine. ML
---
* Origin: (1:3634/12.73)
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Re: src/sbbs3/sbbsecho.c
By: mark lewis to Digital Man on Mon Oct 29 2018 12:56 pm

On 2018 Oct 28 23:29:28, rswindell wrote to CVS commit:

Modified Files:
sbbsecho.c
Log Message:
Requested change by Mark Lewis:
can we get a slight change in the sbbsecho code or maybe in echocfg so

that

when a link is set to passive, areafix notices are NOT sent to them even

if

"send notices" is specifically set to yes?

thank you... i'm guessing that the option in the config file toggles when links
change their statuses? glad to see the change wasn't very involved :)

Right. That link setting is modifiable via areafix.

digital man

Synchronet/BBS Terminology Definition #19:
DOCSIS = Data Over Cable Service Interface Specification
Norco, CA WX: 76.9�F, 43.0% humidity, 0 mph E wind, 0.00 inches rain/24hrs

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.98 3.99
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv30801

Modified Files:
sbbsecho.c
Log Message:
Fuzzy Zone operation: make the implementation match the feature description/documentation more closely. That is, if there is an INTL kludge line in the incoming netmail message, there will be no "fuzzy" zone matching. This means that Fuzzy Zone operation will only apply to netmail messages that do *not* have an INTL kludge line (which specifies the source and destination zones already). This solves the problem reported by Mark Lewis with
unexpected Fuzzy Zone behavior (when enabled), it was over-riding the
source zone number even though it was specified (via INTL kludge) in the original netmail message body.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.99 3.100
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv17849

Modified Files:
sbbsecho.c
Log Message:
Log a notice-level message when adding a new area to the unknown/bad area list.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.100 3.101
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv18772

Modified Files:
sbbsecho.c
Log Message:
Change requested by Mark Lewis: accept area manager (areafix) netmail
requests sent to "SBBSecho" again. SBBSecho used to allow this back in
v3.02 (Nov-2017) and earlier versions, but was removed for loop-safety
since AreaMgr notifications and responses are sent from "SBBSecho", but
we have bot-loop protection built in, so that should be okay.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.102 3.103
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv8260

Modified Files:
sbbsecho.c
Log Message:
Longer, hopefully more helpful, "Authenticated EchoMail" warning log msg.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.104 3.105
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv3902

Modified Files:
sbbsecho.c
Log Message:
Restore the BRE inter-bbs netmail attachment work-around from SBBSecho v2:
If the attached file begins with a '^', ignore/skip that character in the file path. This should resolve the error reported by Ken of Section One BBS:
ERROR line 850, attachment file not found: ^C:/SBBS/XTRN/BRE777/...

SBBSecho v2.x included this work-around and it was not included in the v3 re-factoring/re-write. Of course, BRE is doing something wrong and is totally at fault here, but no one expects BRE to be fixed... ever. :-)


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.114 3.115
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv26186

Modified Files:
sbbsecho.c
Log Message:
Don't warn about free disk space for directories that don't exist.
Log free disk space errors to sbbsecho.log (as well as print to stdout).



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.115 3.116
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv11356

Modified Files:
sbbsecho.c
Log Message:
Bug-fix: Support [node:<addr>@<domain>] sections in AreaFix changes.

When processing area manager netmail messages, SBBSecho can modify
(add/change) keys in the [node:*] section of the sbbsecho.ini file. Although SBBSecho would read node sections that had a domain (e.g. 5D address) just fine when processing area manager changes and writing those changes back to the sbbsecho.ini, only 4D addresses (no "@domain") were used in the section naming. This could result in duplicate node sections being created in the sbbsecho.ini file (one with a "@domain", one without) and then "bad things" could happen (e.g. BinkP authentication failures, packet authentication failures, etc.).

Now, when SBBSecho writes linked-node setting to the sbbsecho.ini, it first checks for the full 5D address of the node and if that section exists, modify it, otherwise fall-through to the 3D/4D address of the node for the sectoin naming.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

On 2019 Jun 22 15:27:42, rswindell wrote to CVS commit:

Modified Files:
sbbsecho.c
Log Message:
Bug-fix: Support [node:<addr>@<domain>] sections in AreaFix changes.

When processing area manager netmail messages, SBBSecho can modify (add/change) keys in the [node:*] section of the sbbsecho.ini file. Although SBBSecho would read node sections that had a domain (e.g. 5D address) just fine when processing area manager changes and writing those changes back to the sbbsecho.ini, only 4D addresses (no "@domain") were used in the section naming. This could result in duplicate node sections being created in the sbbsecho.ini file (one with a "@domain", one without) and then "bad things" could happen (e.g. BinkP authentication failures, packet authentication failures, etc.).

i've seen this! never was able to spend time to try to figure out the problem so was unable to report the bug... glad to know that it has been found and fixed! yay!

Now, when SBBSecho writes linked-node setting to the sbbsecho.ini, it first checks for the full 5D address of the node and if that section exists, modify it, otherwise fall-through to the 3D/4D address of the
node for the sectoin naming.

that's like what tickit is doing when it hunts for a system's tic password... look for this and if not found, then look for the other form of address...

)\/(ark

Always Mount a Scratch Monkey
Do you manage your own servers? If you are not running an IDS/IPS yer doin' it wrong...
... Don't corner something meaner than you.
---
* Origin: (1:3634/12.73)
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.116 3.117
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Don't need lzh.h here.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.120 3.121
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv21629

Modified Files:
sbbsecho.c
Log Message:
When importing fidonet mesages, if there's a Ctrl-A char which is *not* the start of a valid control paragraph (kludge line), then convert the Ctrl-A char to an '@'. This handles the situation where someone quotes control paragraphs with Ctrl-A chars, for example, we don't want those Ctrl-A chars being misinterpreted as Ctrl-A codes causing weird colors or pauses or whatever.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

On 2019 Jul 25 21:55:18, rswindell wrote to CVS commit:

When importing fidonet mesages, if there's a Ctrl-A char which is
*not* the start of a valid control paragraph (kludge line), then
convert the Ctrl-A char to an '@'. This handles the situation where someone quotes control paragraphs with Ctrl-A chars, for example, we
don't want those Ctrl-A chars being misinterpreted as Ctrl-A codes
causing weird colors or pauses or whatever.

thanks for this! i see similar with pipe codes, too... they're used in the fidonet software listings published in the fidonet or fidogazette newsletters... i've written a note to the maintainer of that list but they are apparently busy in RL and have not gotten back to me... basically the pipe codes are being interpreted in the same manner as the ^A codes... i'm not sure how to handle it, though, other than disabling pipe codes in all fidonet areas via the template area...

)\/(ark

Once men turned their thinking over to machines in the hope that this would set
them free. But that only permitted other men with machines to enslave them.
... A bachelor lives like a king and dies like a beggar.
---
* Origin: (1:3634/12.73)
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Re: src/sbbs3/sbbsecho.c
By: mark lewis to digital man on Fri Jul 26 2019 12:10 pm

On 2019 Jul 25 21:55:18, rswindell wrote to CVS commit:

When importing fidonet mesages, if there's a Ctrl-A char which is
*not* the start of a valid control paragraph (kludge line), then convert the Ctrl-A char to an '@'. This handles the situation where someone quotes control paragraphs with Ctrl-A chars, for example, we don't want those Ctrl-A chars being misinterpreted as Ctrl-A codes causing weird colors or pauses or whatever.

thanks for this! i see similar with pipe codes, too... they're used in the fidonet software listings published in the fidonet or fidogazette newsletters... i've written a note to the maintainer of that list but they are apparently busy in RL and have not gotten back to me... basically the pipe codes are being interpreted in the same manner as the ^A codes... i'm not sure how to handle it, though, other than disabling pipe codes in all fidonet areas via the template area...

Pipe code support can only be enabled/disabled (in Synchronet) globally. :-(

digital man

Synchronet/BBS Terminology Definition #27:
FOSSIL = Fido/Opus/SEAdog Standard Interface Layer
Norco, CA WX: 90.5�F, 37.0% humidity, 4 mph N wind, 0.00 inches rain/24hrs

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Re: src/sbbs3/sbbsecho.c
By: Digital Man to mark lewis on Fri Jul 26 2019 11:47 am

Re: src/sbbs3/sbbsecho.c
By: mark lewis to digital man on Fri Jul 26 2019 12:10 pm

On 2019 Jul 25 21:55:18, rswindell wrote to CVS commit:

When importing fidonet mesages, if there's a Ctrl-A char which is *not* the start of a valid control paragraph (kludge line), then convert the Ctrl-A char to an '@'. This handles the situation where someone quotes control paragraphs with Ctrl-A chars, for example, we don't want those Ctrl-A chars being misinterpreted as Ctrl-A codes causing weird colors or pauses or whatever.

thanks for this! i see similar with pipe codes, too... they're used in the fidonet software listings published in the fidonet or fidogazette newsletters... i've written a note to the maintainer of that list but they are apparently busy in RL and have not gotten back to me... basically the pipe codes are being interpreted in the same manner as the ^A codes... i'm not sure how to handle it, though, other than disabling pipe codes in all fidonet areas via the template area...

Pipe code support can only be enabled/disabled (in Synchronet) globally. :-(

Before today... :-)

digital man

Synchronet/BBS Terminology Definition #40:
IMAP = Internet Message Access Protocol
Norco, CA WX: 94.5�F, 34.0% humidity, 4 mph NNE wind, 0.00 inches rain/24hrs

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.122 3.123
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv8880

Modified Files:
sbbsecho.c
Log Message:
Remove unused variable.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.123 3.124
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv10902

Modified Files:
sbbsecho.c
Log Message:
For Mark Lewis:
When writing non-bundle file paths/names to BSO/FLO files, don't use the
delete (^) prefix unless the message has the "Kill Sent" attribute set. This seems kind of wrong to me. The KFS "Kill File Sent" flag has been defined in FSC-0053 since 1992, that seems more likely the appropriate flag to determine if a message attachment should be deleted (or not) after being sent. But parsing/using the "Flags" control line flags isn't already in SBBSecho, so
I'll just punt for now and do what Mark asked for. <shrug>



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

On 2019 Jul 29 22:25:52, rswindell wrote to CVS commit:

Modified Files:
sbbsecho.c
Log Message:
For Mark Lewis:
When writing non-bundle file paths/names to BSO/FLO files, don't use the delete (^) prefix unless the message has the "Kill Sent" attribute set. This seems kind of wrong to me.

you are correct... it is wrong... the main thing i wanted/needed was for sbbsecho to not kill file attaches... their deletion appeared to be being triggered by the KillSent bit...

The KFS "Kill File Sent" flag has been defined in FSC-0053 since 1992, that seems more likely the appropriate flag to determine if a message attachment should be deleted (or not) after being sent. But
parsing/using the "Flags" control line flags isn't already in
SBBSecho,

exactly...

so I'll just punt for now and do what Mark asked for. <shrug>

the main thing is the files are no longer killed... attached files really should be uncoupled from the KillSent bit completely... they should only be killed if the KFS flag is set if/when sbbsecho implements the Flags control line... yes, i was slightly confused and kept thinking about the KFS flag... plus my brain was burnt from fixing makenl's C code... it has been a long time since i've done any C stuff like that and once i got it figured out, the fix was only like 8 lines added and 2 changed :lol:

)\/(ark

Once men turned their thinking over to machines in the hope that this would set
them free. But that only permitted other men with machines to enslave them.
... But if the handwriting on the wall is a forgery?
---
* Origin: (1:3634/12.73)
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Re: src/sbbs3/sbbsecho.c
By: mark lewis to digital man on Wed Jul 31 2019 08:30 pm

On 2019 Jul 29 22:25:52, rswindell wrote to CVS commit:

Modified Files:
sbbsecho.c
Log Message:
For Mark Lewis:
When writing non-bundle file paths/names to BSO/FLO files, don't use the delete (^) prefix unless the message has the "Kill Sent" attribute set. This seems kind of wrong to me.

you are correct... it is wrong... the main thing i wanted/needed was for sbbsecho to not kill file attaches... their deletion appeared to be being triggered by the KillSent bit...

The KFS "Kill File Sent" flag has been defined in FSC-0053 since 1992, that seems more likely the appropriate flag to determine if a message attachment should be deleted (or not) after being sent. But parsing/using the "Flags" control line flags isn't already in
SBBSecho,

exactly...

so I'll just punt for now and do what Mark asked for. <shrug>

the main thing is the files are no longer killed...

They will be if the KILLSENT flag is sent (which is normal).

attached files really
should be uncoupled from the KillSent bit completely... they should only be killed if the KFS flag is set if/when sbbsecho implements the Flags control line... yes, i was slightly confused and kept thinking about the KFS flag... plus my brain was burnt from fixing makenl's C code... it has been a long time since i've done any C stuff like that and once i got it figured out, the fix was only like 8 lines added and 2 changed :lol:

Okay. I'll probably just add the KFS flag checking and remove the checking of the KILLSENT attr bit for that logic.

digital man

Synchronet/BBS Terminology Definition #9:
BSO = Binkley Style Outbound
Norco, CA WX: 66.2�F, 87.0% humidity, 0 mph SSE wind, 0.00 inches rain/24hrs

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.124 3.125
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv19947

Modified Files:
sbbsecho.c
Log Message:
If SBBSecho imports a message with a "CHRS" control line with a value of "UTF-8", set the msg's auxattr MSG_HFIELDS_UTF8 flag because FTS-5003 states:
"The character set identifier applies to all parts of the message,
including the header information and the control lines like origin
and tear line."



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.125 3.126
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv29414

Modified Files:
sbbsecho.c
Log Message:
Use the \1FLAGS KFS (parsed crudely from netmail .msg body text) to trigger file-attachment deletion in write_flofile() - not the KILLSENT attribute flag. Export the SMB MSG_KILLSENT auxattr from SMB mail to FTN netmail \1FLAGS KFS.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.126 3.127
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv22270

Modified Files:
sbbsecho.c
Log Message:
Export a default CHRS: (charset) value of "UTF-8" when any of the header fields contain UTF-8 characters.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.127 3.128
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv2831

Modified Files:
sbbsecho.c
Log Message:
Same as previous commit, but for EchoMail this time (!).



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.128 3.129
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv30083

Modified Files:
sbbsecho.c
Log Message:
Revamp the 0-byte inbound bundle handling:
- Don't ever try to unpack a 0-byte file.
- Don't log anything or try delete if the file is < 24 hours old.
- Try to delete the file if it's >= 24 hours old (and log a msg, INFO-level).




---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.129 3.130
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv4469

Modified Files:
sbbsecho.c
Log Message:
If failure to find a .msg netmail file attachment, don't bail (immediately exit), just log the error and continue processing. Reported by wkitty42.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.130 3.131
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Add missing %s printf args.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.131 3.132
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv17560

Modified Files:
sbbsecho.c
Log Message:
Log the process-ID (PID) on the debug-level log lines: "invoked" and "exiting" Always log the "exiting" line when exiting with a non-zero error level.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.132 3.133
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv10170

Modified Files:
sbbsecho.c
Log Message:
When importing FTN TZUTC values, don't get fancy trying to convert to a US standard time-zone (e.g. -0300 == EST) as this is not accurate when daylight saving time is in effect (-0400 == EDT or AST?).



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.133 3.134
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv10866

Modified Files:
sbbsecho.c
Log Message:
Fix possible NULL-dereference in pack_netmail(), likely the problem that Alterego reported, would cause a crash if the netmail message did *not* have
a FLAGS kludge line.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

Re: src/sbbs3/sbbsecho.c
By: rswindell to CVS commit on Sun Aug 18 2019 12:04 pm

Fix possible NULL-dereference in pack_netmail(), likely the problem that Alterego reported, would cause a crash if the netmail message did *not* have a FLAGS kludge line.

Ahh, you might have found it?

I'll rebuild and try with the same message anyway...
...���*

... Nursing Law: All the IV trees are at the other end of the hall.

---
� Synchronet � Alterant | an SBBS in Docker on Pi!

Re: src/sbbs3/sbbsecho.c
By: Alterego to Digital Man on Mon Aug 19 2019 08:21 am

Re: src/sbbs3/sbbsecho.c
By: rswindell to CVS commit on Sun Aug 18 2019 12:04 pm

Fix possible NULL-dereference in pack_netmail(), likely the problem that Alterego reported, would cause a crash if the netmail message did *not* have a FLAGS kludge line.

Ahh, you might have found it?

I think so.

I'll rebuild and try with the same message anyway...

Thanks!

digital man

Synchronet "Real Fact" #37:
Synchronet's Windows Control Panel is built with Borland C++ Builder.
Norco, CA WX: 84.4�F, 46.0% humidity, 15 mph NE wind, 0.00 inches rain/24hrs

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.134 3.135
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv28445

Modified Files:
sbbsecho.c
Log Message:
Using the new lookup_user() function for destinatino user name look-ups.


---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.136 3.137
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Beautify the "Adding sub-board" log message a bit.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

src/sbbs3 sbbsecho.c 3.137 3.138
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/home/rswindell/sbbs/src/sbbs3

Modified Files:
sbbsecho.c
Log Message:
Log a notice-level msg if the configured areafile can't be opened.



---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net