Hey! I fixed the two errors which prevented Milliway's from playing. How should I contribute my changes? It just took a few quick fixes to mc.js, not a big deal, but now this awesome game works.

---
þ Synchronet þ Pay no attention to that man behind the curtain!

Re: Milliway's Casino
By: ASCII Express to All on Thu Jan 30 2014 06:04 pm

Well unfortunately fixing a few bugs seems to have introduced more. I get NaN for my money, then when it reads it as 0 it enters an infinite loop when Bruno comes. Hmm...

---
þ Synchronet þ Pay no attention to that man behind the curtain!

Re: Milliway's Casino
By: ASCII Express to All on Thu Jan 30 2014 06:04 pm

Hey! I fixed the two errors which prevented Milliway's from playing. How should I contribute my changes? It just took a few quick fixes to mc.js,
not a big deal, but now this awesome game works.

I have also fixed them and comitted the changes to CVS. If you update from CVS, you should get the latest with fixes.

If you're going to be contributing, you'll want to have the CVS versions available at the very least.

---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)

Re: Milliway's Casino
By: Deuce to ASCII Express on Thu Jan 30 2014 23:55:39

Hey! I fixed the two errors which prevented Milliway's from playing.
How should I contribute my changes? It just took a few quick fixes to
mc.js, not a big deal, but now this awesome game works.

I have also fixed them and comitted the changes to CVS. If you update from CVS, you should get the latest with fixes.

If you're going to be contributing, you'll want to have the CVS versions available at the very least.

Yep, indeed. When using a repository such as CVS, it's best to update your versions before making changes, especially if you're going to be committing changes back. Otherwise you might accidentlly overwrite changes that someone else has made with older code somewhere else in the file(s).

Also, if you want to make changes to something that someone else has worked on recently, it's best to contact them to tell/ask them about the changes you want to make. If something has been worked on recently, it's very possible that the other author may be making the same changes you want to make.

Nightfox

---
þ Synchronet þ Digital Distortion BBS - digitaldistortionbbs.com

Re: Milliway's Casino
By: Deuce to ASCII Express on Thu Jan 30 2014 11:55 pm

I have also fixed them and comitted the changes to CVS. If you update from CVS, you should get the latest with fixes.

I just updated according to the instructions in the wiki. Now running it gives me the following:

!JavaScript /home/bbs/sbbs/exec/load/recordfile.js line 85: ReferenceError: RecordFileRecord_Put is not defined
!JavaScript /home/bbs/sbbs/xtrn/mc/shared.js line 227: ReferenceError: player is not defined

I backed up my exec directory, and temporarily replaced recordfile.js and the game worked. I still got some NaN errors but one thing at a time.

By the way KNK works beautifully now, thanks for fixing that!

---
þ Synchronet þ Pay no attention to that man behind the curtain!

Re: Milliway's Casino
By: ASCII Express to Deuce on Sat Feb 01 2014 06:38 pm

!JavaScript /home/bbs/sbbs/exec/load/recordfile.js line 85:
ReferenceError: RecordFileRecord_Put is not defined
!JavaScript /home/bbs/sbbs/xtrn/mc/shared.js line 227: ReferenceError: player is not defined

Thanks, I'll get this fixed tonight.

I backed up my exec directory, and temporarily replaced recordfile.js and the game worked. I still got some NaN errors but one thing at a time.

How are you getting them?

---
http://DuckDuckGo.com/ a better search engine that respects your privacy.
þ Synchronet þ My Brand-New BBS (All the cool SysOps run STOCK!)